Skip to contentSkip to conversation

netlink: specs: Add missing bitset attrs to ethtool spec

PATCH Applied Donald Hunter 3 participants 3 messages Oct 18, 2024 – Oct 23, 2024

Subsystems (4)
Networking Network drivers Networking ethtool YAML netlink (YNL)
lore
Share & tools
lore

Donald Hunter

author maintainer
#0 lore raw

PATCH 1/1 netlink: specs: Add missing bitset attrs to ethtool spec

There are a couple of attributes missing from the 'bitset' attribute-set in the ethtool netlink spec. Add them to the spec.

Reported-by Kory Maincent <[email protected]>
Closes https://lore.kernel.org/netdev/20241017180551.1259bf5c@kmaincent-XPS-13-7390/ open here
Signed-off-by Donald Hunter <[email protected]>
---
 Documentation/netlink/specs/ethtool.yaml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/netlink/specs/ethtool.yaml +6 -1
index 6a050d755b9c..f6c5d8214c7e 100644
@@ -96,7 +96,12 @@ attribute-sets:
         name: bits
         type: nest
         nested-attributes: bitset-bits
-
+      -
+        name: value
+        type: binary
+      -
+        name: mask
+        type: binary
   -
     name: string
     attributes:
Signature · 1 line
2.47.0
Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 2 lines · On Fri, 18 Oct 2024 10:06:30 +0100 Donald Hunter <[email protected]>…

There are a couple of attributes missing from the 'bitset' attribute-set in the ethtool netlink spec. Add them to the spec.

Reviewed-by Kory Maincent <[email protected]>
Tested-by Kory Maincent <[email protected]>

Thank you!

Quoted 25 lines
Reported-by Kory Maincent <[email protected]>

Closes:
https://lore.kernel.org/netdev/20241017180551.1259bf5c@kmaincent-XPS-13-7390/

Signed-off-by Donald Hunter <[email protected]> ---
 Documentation/netlink/specs/ethtool.yaml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/Documentation/netlink/specs/ethtool.yaml index 6a050d755b9c..f6c5d8214c7e 100644 --- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml

Documentation/netlink/specs/ethtool.yaml +6 -1
@@ -96,7 +96,12 @@ attribute-sets:
         name: bits
         type: nest
         nested-attributes: bitset-bits
-
+      -
+        name: value
+        type: binary
+      -
+        name: mask
+        type: binary
   -
     name: string
     attributes:
Signature · 3 lines
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
CI Applied
#2 lore raw
In reply to Donald Hunter
This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:

Quoted 8 lines · On Fri, 18 Oct 2024 10:06:30 +0100 you wrote:

There are a couple of attributes missing from the 'bitset' attribute-set in the ethtool netlink spec. Add them to the spec.

Reported-by Kory Maincent <[email protected]>
Closes https://lore.kernel.org/netdev/20241017180551.1259bf5c@kmaincent-XPS-13-7390/ open here
Signed-off-by Donald Hunter <[email protected]>

[...]

Here is the summary with links:
- [net-next,v1] netlink: specs: Add missing bitset attrs to ethtool spec

    https://git.kernel.org/netdev/net-next/c/b0b3683419b4

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html