Skip to contentSkip to conversation

media: v4l2-core: constify the class struct

PATCH In review Bartosz Golaszewski 2 participants 5 messages Oct 18, 2024 – Oct 31, 2024 1 message not in the archive Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: v4l2-core: constify the class struct

From: Bartosz Golaszewski <[email protected]>

All functions that take the class address as argument expect a const pointer so we can make the video class constant.

---
 drivers/media/v4l2-core/v4l2-dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/v4l2-core/v4l2-dev.c +1 -1
index dbd6fba93179..5bcaeeba4d09 100644
@@ -229,7 +229,7 @@ static void v4l2_device_release(struct device *cd)
 		v4l2_device_put(v4l2_dev);
 }
 
-static struct class video_class = {
+static const struct class video_class = {
 	.name = VIDEO_NAME,
 	.dev_groups = video_device_groups,
 };
Signature · 1 line
2.43.0

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 13 lines · Patchwork Integration

Dear Bartosz Golaszewski:

The unreliable Media-CI system has found some issues with your series.
Check the report at: https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/65292429/artifacts/report.htm

Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.

If you believe that the CI is wrong, kindly reply-all to this email.

Check the latest rules for contributing your patches at Documentation/process.

Quoted 9 lines

Best regards, and Happy Hacking!

# Broken Tests
## Test [static-upstream:test-coccinelle](https://gitlab.freedesktop.org/linux-media/users/patchwork/-/jobs/65292423)
- **[stderr](https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/65292423/artifacts/junit/test-coccinelle.err.txt):**

```
drivers/media/platform/raspberrypi/rp1-cfe/cfe.c:2326:2-9: line 2326 is redundant because platform_get_irq() already prints an error
```

I think this is a false positive.

Bart

#3 lore raw

Hi Bartosz

It is indeed. Sorry about that. We have already landed the fix.

Sorry for the noise

Quoted 29 lines · Bartosz Golaszewski
Quoted 13 lines · Patchwork Integration

Dear Bartosz Golaszewski:

The unreliable Media-CI system has found some issues with your series.
Check the report at: https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/65292429/artifacts/report.htm

Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.

If you believe that the CI is wrong, kindly reply-all to this email.

Check the latest rules for contributing your patches at Documentation/process.

Quoted 9 lines

Best regards, and Happy Hacking!

# Broken Tests
## Test [static-upstream:test-coccinelle](https://gitlab.freedesktop.org/linux-media/users/patchwork/-/jobs/65292423)
- **[stderr](https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/65292423/artifacts/junit/test-coccinelle.err.txt):**

```
drivers/media/platform/raspberrypi/rp1-cfe/cfe.c:2326:2-9: line 2326 is redundant because platform_get_irq() already prints an error
```

I think this is a false positive.

Bart

Signature · 1 line
Ricardo Ribalda
#4 lore raw
Quoted 7 lines · Ricardo Ribalda

Hi Bartosz

It is indeed. Sorry about that. We have already landed the fix.

Sorry for the noise

Can this be picked up then?

Bart

#5 lore raw
Quoted 5 lines · Bartosz Golaszewski
Quoted 3 lines · Ricardo Ribalda

Hi Bartosz

Quoted 8 lines
Quoted 4 lines

It is indeed. Sorry about that. We have already landed the fix.

Sorry for the noise

Can this be picked up then?

Bart

Ping