Skip to contentSkip to conversation

drm/i915/display: Fuse bit for power management disable removed

PATCH Superseded Clint Taylor 3 participants 3 messages Oct 18, 2024 – Oct 23, 2024

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/i915/display: Fuse bit for power management disable removed

Starting with Display 13 the fuse bit to disable Display PM has been removed.

v2: Bit removed starting with Display13 (MattR)
BSPEC: 69464

---
 drivers/gpu/drm/i915/display/intel_display_device.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_display_device.c +4 -2
index aa22189e3853..1ec72ac2320a 100644
@@ -1659,8 +1659,10 @@ static void __intel_display_device_info_runtime_init(struct drm_i915_private *i9
 		if (dfsm & SKL_DFSM_DISPLAY_HDCP_DISABLE)
 			display_runtime->has_hdcp = 0;
 
-		if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE)
-			display_runtime->fbc_mask = 0;
+		if (DISPLAY_VER(i915) < 13) {
+			if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE)
+				display_runtime->fbc_mask = 0;
+		}
 
 		if (DISPLAY_VER(i915) >= 11 && (dfsm & ICL_DFSM_DMC_DISABLE))
 			display_runtime->has_dmc = 0;
Signature · 1 line
2.25.1
#1 lore raw

✗ Fi.CI.BAT: failure for drm/i915/display: Fuse bit for power management disable removed (rev2)

== Series Details ==

== Series Details ==

Series: drm/i915/display: Fuse bit for power management disable removed (rev2)
URL : https://patchwork.freedesktop.org/series/139583/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_15562 -> Patchwork_139583v2
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_139583v2 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_139583v2, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139583v2/index.html

Participating hosts (41 -> 40)
------------------------------

Missing (1): fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_139583v2:

### IGT changes ###

#### Possible regressions ####

* igt@gem_sync@basic-all:
- bat-atsm-1: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-atsm-1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139583v2/bat-atsm-1/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_139583v2 that come from known issues:

### IGT changes ###

#### Possible fixes ####

* igt@i915_selftest@live:
- bat-dg2-8: [DMESG-FAIL][3] ([i915#12133] / [i915#9500]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-dg2-8/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139583v2/bat-dg2-8/igt@[email protected]
- {bat-arlh-3}: [ABORT][5] ([i915#12133]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-arlh-3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139583v2/bat-arlh-3/igt@[email protected]

* igt@i915_selftest@live@workarounds:
- {bat-arlh-3}: [ABORT][7] ([i915#12061]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-arlh-3/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139583v2/bat-arlh-3/igt@i915_selftest@[email protected]
- bat-dg2-8: [DMESG-FAIL][9] ([i915#9500]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-dg2-8/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139583v2/bat-dg2-8/igt@i915_selftest@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#12133]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12133
[i915#9500]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9500

Build changes
-------------

* Linux: CI_DRM_15562 -> Patchwork_139583v2

CI-20190529: 20190529
CI_DRM_15562: fe768c9d3f0cfbe30a1dddf3ae2319d1e04a4403 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8080: 20fcbc59241a16c84d12f4f6ba390fb46fd65a36 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_139583v2: fe768c9d3f0cfbe30a1dddf3ae2319d1e04a4403 @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139583v2/index.html

#2 lore raw
In reply to Clint Taylor
Quoted 4 lines · Clint Taylor

Starting with Display 13 the fuse bit to disable Display PM has been removed.

v2: Bit removed starting with Display13 (MattR)

Nitpicks: we should write this out as "display version 13" in the two places above rather than treating it as a proper noun. Also, there should be a blank line here after the changelog before the git trailers start.

Quoted 1 line

BSPEC: 69464

We should use/add 50075 here, since that's the page that actually shows exactly when the bit was removed in the Xe1 era. 69464 is the Xe2 page that just confirms that it's still gone in Xe2.

Quoted 12 lines
---
 drivers/gpu/drm/i915/display/intel_display_device.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_display_device.c +0 -0
index aa22189e3853..1ec72ac2320a 100644

drivers/gpu/drm/i915/display/intel_display_device.c static void __intel_display_device_info_runtime_init(struct drm_i915_private *i9 · line 1662

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_display_device.c +1 -2
@@ -1659,8 +1659,10 @@ static void __intel_display_device_info_runtime_init(struct drm_i915_private *i9
 		if (dfsm & SKL_DFSM_DISPLAY_HDCP_DISABLE)
 			display_runtime->has_hdcp = 0;
 
-		if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE)
-			display_runtime->fbc_mask = 0;
+		if (DISPLAY_VER(i915) < 13) {

Both DG2 and ADL-P share display version 13 and according to bspec 50075, the bit does still exist on DG2. So we probably need the condition to be "IS_DG2 || ver < 13."

Matt

Quoted 9 lines
drivers/gpu/drm/i915/display/intel_display_device.c +3 -0
+			if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE)
+				display_runtime->fbc_mask = 0;
+		}
 
 		if (DISPLAY_VER(i915) >= 11 && (dfsm & ICL_DFSM_DMC_DISABLE))
 			display_runtime->has_dmc = 0;
Signature · 1 line
2.25.1
Signature · 4 lines
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation