iio: magnetometer; bmc150_magn: Drop most likely fake ACPI IDs
PATCH 1/1 iio: magnetometer; bmc150_magn: Drop most likely fake ACPI IDs
The commits in question do not proove that ACPI IDs exist. Quite likely it was a cargo cult addition while doing that for DT-based enumeration. Drop most likely fake ACPI IDs.
The to be removed IDs has been checked against the following resources:
1) DuckDuckGo
2) Google
3) MS catalog: https://www.catalog.update.microsoft.com/Search.aspx
This gives no useful results in regard to DSDT, moreover, the official vendor IDs in the registry for Bosh are BSG and BOSC.
--- drivers/iio/magnetometer/bmc150_magn_i2c.c | 9 --------- drivers/iio/magnetometer/bmc150_magn_spi.c | 9 --------- 2 files changed, 18 deletions(-)
drivers/iio/magnetometer/bmc150_magn_i2c.c +0 -9
@@ -38,14 +38,6 @@ static void bmc150_magn_i2c_remove(struct i2c_client *client)bmc150_magn_remove (&client->dev); } -static const struct acpi_device_id bmc150_magn_acpi_match[] = { - {"BMC150B" ,0 }, - {"BMC156B" ,0 }, - {"BMM150B" ,0 }, - {}, -}; -MODULE_DEVICE_TABLE (acpi, bmc150_magn_acpi_match); -static const struct i2c_device_id bmc150_magn_i2c_id[] = { {"bmc150_magn" }, {"bmc156_magn" },
@@ -67,7 +59,6 @@ static struct i2c_driver bmc150_magn_driver = { .driver = { .name = "bmc150_magn_i2c", .of_match_table = bmc150_magn_of_match, - .acpi_match_table = bmc150_magn_acpi_match, .pm = &bmc150_magn_pm_ops, }, .probe = bmc150_magn_i2c_probe,
drivers/iio/magnetometer/bmc150_magn_spi.c +0 -9
@@ -41,20 +41,11 @@ static const struct spi_device_id bmc150_magn_spi_id[] = { };MODULE_DEVICE_TABLE (spi, bmc150_magn_spi_id); -static const struct acpi_device_id bmc150_magn_acpi_match[] = { - {"BMC150B" ,0 }, - {"BMC156B" ,0 }, - {"BMM150B" ,0 }, - {}, -}; -MODULE_DEVICE_TABLE (acpi, bmc150_magn_acpi_match); -static struct spi_driver bmc150_magn_spi_driver = { .probe = bmc150_magn_spi_probe, .remove = bmc150_magn_spi_remove, .id_table = bmc150_magn_spi_id, .driver = { - .acpi_match_table = bmc150_magn_acpi_match, .name ="bmc150_magn_spi" , }, };
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac
Hi,
Quoted 4 lines · Andy Shevchenko
The commits in question do not proove that ACPI IDs exist. Quite likely it was a cargo cult addition while doing that for DT-based enumeration. Drop most likely fake ACPI IDs.
Quoted 8 lines
The to be removed IDs has been checked against the following resources:
1) DuckDuckGo
2) Google
3) MS catalog: https://www.catalog.update.microsoft.com/Search.aspx
This gives no useful results in regard to DSDT, moreover, the official vendor IDs in the registry for Bosh are BSG and BOSC.Signed-off-by Andy Shevchenko <[email protected]>
These HIDs are also not used in my acpidump collection (mostly BYT / CHT models):
Regards,
Hans
Quoted 57 lines
--- drivers/iio/magnetometer/bmc150_magn_i2c.c | 9 --------- drivers/iio/magnetometer/bmc150_magn_spi.c | 9 --------- 2 files changed, 18 deletions(-)drivers/iio/magnetometer/bmc150_magn_i2c.c +0
-9@@ -38,14 +38,6 @@ static void bmc150_magn_i2c_remove(struct i2c_client *client)bmc150_magn_remove (&client->dev); } -static const struct acpi_device_id bmc150_magn_acpi_match[] = { - {"BMC150B" ,0 }, - {"BMC156B" ,0 }, - {"BMM150B" ,0 }, - {}, -}; -MODULE_DEVICE_TABLE (acpi, bmc150_magn_acpi_match); -static const struct i2c_device_id bmc150_magn_i2c_id[] = { {"bmc150_magn" }, {"bmc156_magn" },@@ -67,7 +59,6 @@ static struct i2c_driver bmc150_magn_driver = { .driver = { .name = "bmc150_magn_i2c", .of_match_table = bmc150_magn_of_match, - .acpi_match_table = bmc150_magn_acpi_match, .pm = &bmc150_magn_pm_ops, }, .probe = bmc150_magn_i2c_probe,drivers/iio/magnetometer/bmc150_magn_spi.c +0
-9@@ -41,20 +41,11 @@ static const struct spi_device_id bmc150_magn_spi_id[] = { };MODULE_DEVICE_TABLE (spi, bmc150_magn_spi_id); -static const struct acpi_device_id bmc150_magn_acpi_match[] = { - {"BMC150B" ,0 }, - {"BMC156B" ,0 }, - {"BMM150B" ,0 }, - {}, -}; -MODULE_DEVICE_TABLE (acpi, bmc150_magn_acpi_match); -static struct spi_driver bmc150_magn_spi_driver = { .probe = bmc150_magn_spi_probe, .remove = bmc150_magn_spi_remove, .id_table = bmc150_magn_spi_id, .driver = { - .acpi_match_table = bmc150_magn_acpi_match, .name ="bmc150_magn_spi" , }, };
Jonathan Cameron
maintainerQuoted 14 lines · On Sat, 19 Oct 2024 12:03:19 +0200 Hans de Goede <[email protected]> wrote:
Hi,
Quoted 11 lines · Andy Shevchenko
The commits in question do not proove that ACPI IDs exist. Quite likely it was a cargo cult addition while doing that for DT-based enumeration. Drop most likely fake ACPI IDs.
The to be removed IDs has been checked against the following resources:
1) DuckDuckGo
2) Google
3) MS catalog: https://www.catalog.update.microsoft.com/Search.aspx
This gives no useful results in regard to DSDT, moreover, the official vendor IDs in the registry for Bosh are BSG and BOSC.
Quoted 8 lines
Quoted 1 line
Signed-off-by Andy Shevchenko <[email protected]>These HIDs are also not used in my acpidump collection (mostly BYT / CHT models):
Reviewed-by Hans de Goede <[email protected]>
Some more multichip package devices in here. Anyhow, on same basis as the previous I'll apply the patch and we'll see if anyone shouts.
Jonathan
Quoted 66 lines
Regards,
Hans
Quoted 57 lines
--- drivers/iio/magnetometer/bmc150_magn_i2c.c | 9 --------- drivers/iio/magnetometer/bmc150_magn_spi.c | 9 --------- 2 files changed, 18 deletions(-)drivers/iio/magnetometer/bmc150_magn_i2c.c +0
-9@@ -38,14 +38,6 @@ static void bmc150_magn_i2c_remove(struct i2c_client *client)bmc150_magn_remove (&client->dev); } -static const struct acpi_device_id bmc150_magn_acpi_match[] = { - {"BMC150B" ,0 }, - {"BMC156B" ,0 }, - {"BMM150B" ,0 }, - {}, -}; -MODULE_DEVICE_TABLE (acpi, bmc150_magn_acpi_match); -static const struct i2c_device_id bmc150_magn_i2c_id[] = { {"bmc150_magn" }, {"bmc156_magn" },@@ -67,7 +59,6 @@ static struct i2c_driver bmc150_magn_driver = { .driver = { .name = "bmc150_magn_i2c", .of_match_table = bmc150_magn_of_match, - .acpi_match_table = bmc150_magn_acpi_match, .pm = &bmc150_magn_pm_ops, }, .probe = bmc150_magn_i2c_probe,drivers/iio/magnetometer/bmc150_magn_spi.c +0
-9@@ -41,20 +41,11 @@ static const struct spi_device_id bmc150_magn_spi_id[] = { };MODULE_DEVICE_TABLE (spi, bmc150_magn_spi_id); -static const struct acpi_device_id bmc150_magn_acpi_match[] = { - {"BMC150B" ,0 }, - {"BMC156B" ,0 }, - {"BMM150B" ,0 }, - {}, -}; -MODULE_DEVICE_TABLE (acpi, bmc150_magn_acpi_match); -static struct spi_driver bmc150_magn_spi_driver = { .probe = bmc150_magn_spi_probe, .remove = bmc150_magn_spi_remove, .id_table = bmc150_magn_spi_id, .driver = { - .acpi_match_table = bmc150_magn_acpi_match, .name ="bmc150_magn_spi" , }, };