Skip to contentSkip to conversation

dt-bindings: arm: rockchip: add Radxa ROCK 5C

PATCH RESEND Applied FUKAUMI Naoki 4 participants 7 messages Oct 21, 2024 – Nov 10, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND v2 1/3 dt-bindings: arm: rockchip: add Radxa ROCK 5C

Add devicetree binding for the Radxa ROCK 5C.

Radxa ROCK 5C is a 8K computer for everything[1] using the Rockchip RK3588S2 chip.

[1] https://radxa.com/products/rock5/5c

---
Changes in v2:
- none

---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
index 70bd2e4d1195..01d03f2157e1 100644
@@ -890,6 +890,11 @@ properties:
           - const: radxa,rock-5b
           - const: rockchip,rk3588
 
+      - description: Radxa ROCK 5C
+        items:
+          - const: radxa,rock-5c
+          - const: rockchip,rk3588s
+
       - description: Radxa ROCK S0
         items:
           - const: radxa,rock-s0
Signature · 7 lines
2.43.0


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#1 lore raw

PATCH RESEND v2 2/3 arm64: dts: rockchip: add Radxa ROCK 5C

Radxa ROCK 5C is a 8K computer for everything[1] using the Rockchip RK3588S2 chip:

- Rockchip RK3588S2
- Quad A76 and Quad A55 CPU
- 6 TOPS NPU
- up to 32GB LPDDR4x RAM
- eMMC / SPI flash connector
- Micro SD Card slot
- Gigabit ethernet port (supports PoE with add-on PoE HAT)
- WiFi6 / BT5.4
- 1x USB 3.0 Type-A HOST port
- 1x USB 3.0 Type-A OTG port
- 2x USB 2.0 Type-A HOST port
- 1x USB Type-C 5V power port

[1] https://radxa.com/products/rock5/5c

---
Changes in v2:
- sort nodes alphanumerically
- add gpu node

---
 arch/arm64/boot/dts/rockchip/Makefile         |   3 +-
 .../boot/dts/rockchip/rk3588s-rock-5c.dts     | 868 ++++++++++++++++++
 2 files changed, 870 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
arch/arm64/boot/dts/rockchip/Makefile +2 -1
index 8e1025cb5d20..be583d82650f 100644
@@ -156,6 +156,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-indiedroid-nova.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-khadas-edge2.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-nanopi-r6s.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-nanopi-r6c.dtb
-dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-odroid-m2.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5c.dtb
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts new file +868 -0

868 lines not on this page · raw message

Signature · 7 lines
2.43.0


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#2 lore raw

PATCH RESEND v2 3/3 arm64: dts: rockchip: Enable HDMI0 on rock-5c

In reply to FUKAUMI Naoki

Add the necessary DT changes to enable HDMI0 on Radxa ROCK 5C.

---
Changes in v2
- sort nodes alphanumerically
- fix pinctrl for hdmi0

---
 .../boot/dts/rockchip/rk3588s-rock-5c.dts     | 52 +++++++++++++++++++
 1 file changed, 52 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +52 -0
index c80428305f0b..9b14d5383cdc 100644
@@ -8,6 +8,7 @@
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/leds/common.h>
 #include <dt-bindings/pinctrl/rockchip.h>
+#include <dt-bindings/soc/rockchip,vop2.h>
 #include "rk3588s.dtsi"
 
 / {
@@ -35,6 +36,17 @@ analog-sound {
 			  "Headphone", "Headphones";
 	};
 
+	hdmi0-con {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi0_con_in: endpoint {
+				remote-endpoint = <&hdmi0_out_con>;
+			};
+		};
+	};
+
 	leds {
 		compatible = "gpio-leds";
 		pinctrl-names = "default";
@@ -245,6 +257,31 @@ &gpu {
 	status = "okay";
 };
 
+&hdmi0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&hdmim0_tx0_cec
+		     &hdmim1_tx0_hpd
+		     &hdmim0_tx0_scl
+		     &hdmim0_tx0_sda>;
+	status = "okay";
+};
+
+&hdmi0_in {
+	hdmi0_in_vp0: endpoint {
+		remote-endpoint = <&vp0_out_hdmi0>;
+	};
+};
+
+&hdmi0_out {
+	hdmi0_out_con: endpoint {
+		remote-endpoint = <&hdmi0_con_in>;
+	};
+};
+
+&hdptxphy_hdmi0 {
+	status = "okay";
+};
+
 &i2c0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&i2c0m2_xfer>;
@@ -866,3 +903,18 @@ &usb_host1_ohci {
 &usb_host2_xhci {
 	status = "okay";
 };
+
+&vop_mmu {
+	status = "okay";
+};
+
+&vop {
+	status = "okay";
+};
+
+&vp0 {
+	vp0_out_hdmi0: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
+		reg = <ROCKCHIP_VOP2_EP_HDMI0>;
+		remote-endpoint = <&hdmi0_in_vp0>;
+	};
+};
Signature · 7 lines
2.43.0


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#3 lore raw

Re: [PATCH v2 RESEND 3/3] arm64: dts: rockchip: Enable HDMI0 on rock-5c

kernel test robot noticed the following build errors:

Hi FUKAUMI,

kernel test robot noticed the following build errors:

[auto build test ERROR on rockchip/for-next]
[also build test ERROR on robh/for-next linus/master v6.12-rc4 next-20241021] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/FUKAUMI-Naoki/arm64-dts-rockchip-add-Radxa-ROCK-5C/20241021-171353
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
patch link:    https://lore.kernel.org/r/20241021090548.1052-3-naoki%40radxa.com
patch subject: [PATCH v2 RESEND 3/3] arm64: dts: rockchip: Enable HDMI0 on rock-5c
config: arm64-randconfig-001-20241022 (https://download.01.org/0day-ci/archive/20241022/[email protected]/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241022/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

>> Error: arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts:260.1-7 Label or path hdmi0 not found
>> Error: arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts:269.1-10 Label or path hdmi0_in not found
>> Error: arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts:275.1-11 Label or path hdmi0_out not found
>> FATAL ERROR: Syntax error parsing input tree

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for MODVERSIONS
Depends on [n]: MODULES [=y] && !COMPILE_TEST [=y]
Selected by [y]:
- RANDSTRUCT_FULL [=y] && (CC_HAS_RANDSTRUCT [=y] || GCC_PLUGINS [=n]) && MODULES [=y]

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
maintainer Applied
#5 lore raw
In reply to FUKAUMI Naoki
Quoted 8 lines · FUKAUMI Naoki

Add devicetree binding for the Radxa ROCK 5C.

Radxa ROCK 5C is a 8K computer for everything[1] using the Rockchip RK3588S2 chip.

[1] https://radxa.com/products/rock5/5c

[...]

Applied, thanks!

[1/3] dt-bindings: arm: rockchip: add Radxa ROCK 5C

      commit: 3920c37ea8ddc43e8f54083ed227f123acfa6ed2
[2/3] arm64: dts: rockchip: add Radxa ROCK 5C
      commit: 0173113ea6d7646fa0d7fd4d09b272d38a9ab9af

[3/3] arm64: dts: rockchip: Enable HDMI0 on rock-5c
--> I've folded this patch into patch2, as the hdmi
controller on rk3588 was added earlier.

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>
#6 lore raw

Hi,

Thanks!

Quoted 8 lines · Heiko Stuebner
Quoted 7 lines · FUKAUMI Naoki

Add devicetree binding for the Radxa ROCK 5C.

Radxa ROCK 5C is a 8K computer for everything[1] using the Rockchip RK3588S2 chip.

[1] https://radxa.com/products/rock5/5c

Quoted 8 lines
Quoted 1 line

[...]

Applied, thanks!

[1/3] dt-bindings: arm: rockchip: add Radxa ROCK 5C

       commit: 3920c37ea8ddc43e8f54083ed227f123acfa6ed2
[2/3] arm64: dts: rockchip: add Radxa ROCK 5C
       commit: 0173113ea6d7646fa0d7fd4d09b272d38a9ab9af

I forgot to add cd-gpios in sdmmc ;)
I'll make fix patch soon.

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Quoted 5 lines

[3/3] arm64: dts: rockchip: Enable HDMI0 on rock-5c
--> I've folded this patch into patch2, as the hdmi
controller on rk3588 was added earlier.

Best regards,