e2fsprogs: removed 'sed -u' option
PATCH v2 1/1 e2fsprogs: removed 'sed -u' option
From: Aditya Tayade <[email protected]>
In embedded box, sed might be provided another providers like Busybox, hence use generic options whenever possible./bin/sed -> /etc/alternatives/sed/etc/alternatives/sed -> /bin/busybox.nosuid
Here used 'sed -u' option is not necessary, hence removed it.
Fixes below error:
sed: invalid option -- 'u'
Also added 'set -eux' option which halts execution of the script on any failures.
--- meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest +2 -1
@@ -1,7 +1,8 @@ #!/bin/sh +set -eux cd ./test -SKIP_SLOW_TESTS=yes ./test_script | sed -u -e '/:[[:space:]]ok/s/^/PASS: /' -e '/:[[:space:]]failed/s/^/FAIL: /' -e '/:[[:space:]]skipped/s/^/SKIP: /' +SKIP_SLOW_TESTS=yes ./test_script | sed -e '/:[[:space:]]ok/s/^/PASS: /' -e '/:[[:space:]]failed/s/^/FAIL: /' -e '/:[[:space:]]skipped/s/^/SKIP: /' rm -rf /var/volatile/tmp/*e2fsprogs* rm -f tmp-* rm -f *.tmp
Signature · 1 line
2.25.1
This needs to be accepted for master branch first. Also, dunfell is EOL and no patches are accepted.
Alex
Quoted 48 lines · Pawan Badganchi via lists.openembedded.org
From: Aditya Tayade <[email protected]>
In embedded box, sed might be provided another providers like Busybox, hence use generic options whenever possible.
/bin/sed->/etc/alternatives/sed/etc/alternatives/sed->/bin/busybox.nosuidHere used 'sed -u' option is not necessary, hence removed it.
Fixes below error:
sed: invalid option -- 'u'Also added 'set -eux' option which halts execution of the script on any failures.
Signed-off-by Aditya Tayade <[email protected]>Signed-off-by Pawan Badganchi <[email protected]>--- meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest +2
-2@@ -1,7 +1,8 @@ #!/bin/sh +set -eux cd ./test -SKIP_SLOW_TESTS=yes ./test_script | sed -u -e '/:[[:space:]]ok/s/^/PASS: /' -e '/:[[:space:]]failed/s/^/FAIL: /' -e '/:[[:space:]]skipped/s/^/SKIP: /' +SKIP_SLOW_TESTS=yes ./test_script | sed -e '/:[[:space:]]ok/s/^/PASS: /' -e '/:[[:space:]]failed/s/^/FAIL: /' -e '/:[[:space:]]skipped/s/^/SKIP: /' rm -rf /var/volatile/tmp/*e2fsprogs* rm -f tmp-* rm -f *.tmp --2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#206115): https://lists.openembedded.org/g/openembedded-core/message/206115
Mute This Topic: https://lists.openembedded.org/mt/109130461/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-