Skip to contentSkip to conversation

package/arm-gnu-toolchain: Add support check for x86_64 and aarch64

PATCH Applied Bryce Johnson 2 participants 8 messages Oct 22, 2024 – Dec 11, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 package/arm-gnu-toolchain: Add support check for x86_64 and aarch64

---
 package/Config.in.host                   | 1 +
 package/arm-gnu-toolchain/Config.in.host | 4 ++++
 2 files changed, 5 insertions(+)
 create mode 100644 package/arm-gnu-toolchain/Config.in.host
package/Config.in.host +1 -0
index e4fbee4f2a..360ba9dad6 100644
@@ -5,6 +5,7 @@ menu "Host utilities"
 	source "package/agent-proxy/Config.in.host"
 	source "package/amlogic-boot-fip/Config.in.host"
 	source "package/android-tools/Config.in.host"
+	source "package/arm-gnu-toolchain/Config.in.host"
 	source "package/asn1c/Config.in.host"
 	source "package/babeltrace2/Config.in.host"
 	source "package/bmap-tools/Config.in.host"
package/arm-gnu-toolchain/Config.in.host new file +4 -0
new file mode 100644
index 0000000000..dfd30e5223
@@ -0,0 +1,4 @@
+config BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN_SUPPORTS
+	bool "host arm-gnu-toolchain"
+	default y if BR2_HOSTARCH = "aarch64"
+	default y if BR2_HOSTARCH = "x86_64"
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 2/3 boot/arm-trusted-firmware: use HOST_ARM_GNU_TOOLCHAIN_SUPPORTS

To check for valid x86_64 or aarch64 configuration for arm32 toolchain

---
 boot/arm-trusted-firmware/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
boot/arm-trusted-firmware/Config.in +1 -1
index 5ba4e08370..4a5c7dc89c 100644
@@ -249,7 +249,7 @@ config BR2_TARGET_ARM_TRUSTED_FIRMWARE_NEEDS_DTC
 config BR2_TARGET_ARM_TRUSTED_FIRMWARE_NEEDS_ARM32_TOOLCHAIN
 	bool "Needs arm-none-eabi toolchain"
 	depends on BR2_aarch64
-	depends on BR2_HOSTARCH = "x86_64"
+	depends on BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN_SUPPORTS
 	help
 	  Select this option if your ATF board configuration requires
 	  an ARM32 bare metal toolchain to be available.
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

PATCH 3/3 boot/ti-k3-r5-loader: use HOST_ARM_GNU_TOOLCHAIN_SUPPORTS

In reply to Bryce Johnson

To check for valid x86_64 or aarch64 configuration for arm32 toolchain

---
 boot/ti-k3-r5-loader/Config.in | 1 +
 1 file changed, 1 insertion(+)
boot/ti-k3-r5-loader/Config.in +1 -0
index 8c7898ebf6..fe429bb8b4 100644
@@ -1,6 +1,7 @@
 config BR2_TARGET_TI_K3_R5_LOADER
 	bool "ti-k3-r5-loader"
 	depends on BR2_aarch64
+	depends on BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN_SUPPORTS
 	select BR2_TARGET_TI_K3_BOOT_FIRMWARE # binman
 	help
 	  Separate U-Boot SPL build for R5 core on TI's K3 processors.
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw

Re: [Buildroot] [PATCH 3/3] boot/ti-k3-r5-loader: use HOST_ARM_GNU_TOOLCHAIN_SUPPORTS

Hi Bryce!

On October 22, 2024 thus sayeth Bryce Johnson:

Quoted 12 lines

To check for valid x86_64 or aarch64 configuration for arm32 toolchain

---
 boot/ti-k3-r5-loader/Config.in | 1 +
 1 file changed, 1 insertion(+)
boot/ti-k3-r5-loader/Config.in +0 -0
index 8c7898ebf6..fe429bb8b4 100644

boot/ti-k3-r5-loader/Config.in line 4

Quoted 4 lines
boot/ti-k3-r5-loader/Config.in +1 -0
@@ -1,6 +1,7 @@
 config BR2_TARGET_TI_K3_R5_LOADER
 	bool "ti-k3-r5-loader"
 	depends on BR2_aarch64
+	depends on BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN_SUPPORTS

This package is really only here for TI's K3 SoCs. Would it make sense to drop the BR2_aarch64 here for this or to keep BR2_aarch64?

~Bryan
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw

Re: [Buildroot] [PATCH 3/3] boot/ti-k3-r5-loader: use HOST_ARM_GNU_TOOLCHAIN_SUPPORTS

Hey Bryan,
Not sure on that one. I think the BR2_aarch64 is there since the am6* that use the ti-k3-r5-loader are all aarch64 application processors even though the R5 is 32bit? My guess is it probably isn't needed. Any reason someone would want to build the am62* as 32-bit, then there might be an issue with having that there.

Bryce

Quoted 24 lines · Bryan Brattlof

Hi Bryce!

On October 22, 2024 thus sayeth Bryce Johnson:

Quoted 12 lines

To check for valid x86_64 or aarch64 configuration for arm32 toolchain

---
 boot/ti-k3-r5-loader/Config.in | 1 +
 1 file changed, 1 insertion(+)
boot/ti-k3-r5-loader/Config.in +0 -0
index 8c7898ebf6..fe429bb8b4 100644

boot/ti-k3-r5-loader/Config.in line 4

Quoted 4 lines
boot/ti-k3-r5-loader/Config.in +1 -0
@@ -1,6 +1,7 @@
 config BR2_TARGET_TI_K3_R5_LOADER
      bool "ti-k3-r5-loader"
      depends on BR2_aarch64
+     depends on BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN_SUPPORTS

This package is really only here for TI's K3 SoCs. Would it make sense to drop the BR2_aarch64 here for this or to keep BR2_aarch64?

Quoted 1 line

~Bryan

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#5 lore raw

Re: [Buildroot] [PATCH 3/3] boot/ti-k3-r5-loader: use HOST_ARM_GNU_TOOLCHAIN_SUPPORTS

Quoted 10 lines · Bryce Johnson

Hey Bryan,
Not sure on that one. I think the BR2_aarch64 is there since the am6* that use the ti-k3-r5-loader are all aarch64 application processors even though the R5 is 32bit? My guess is it probably isn't needed. Any reason someone would want to build the am62* as 32-bit, then there might be an issue with having that there.

Bryce

Oops, top posted by accident!

Bryce
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#6 lore raw

Re: [Buildroot] [PATCH 3/3] boot/ti-k3-r5-loader: use HOST_ARM_GNU_TOOLCHAIN_SUPPORTS

On November 4, 2024 thus sayeth Bryce Johnson:

Quoted 9 lines · Bryce Johnson
Quoted 8 lines

Hey Bryan,
Not sure on that one. I think the BR2_aarch64 is there since the am6* that use the ti-k3-r5-loader are all aarch64 application processors even though the R5 is 32bit? My guess is it probably isn't needed. Any reason someone would want to build the am62* as 32-bit, then there might be an issue with having that there.

Ah thanks! Yeah I didn't notice it until your patch.

Quoted 2 lines

Oops, top posted by accident!

no worries :)

~Bryan
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#7 lore raw
In reply to Bryce Johnson

Hello Bryce, All,

Le 23/10/2024 à 00:54, Bryce Johnson a écrit :

Quoted 1 line

I slightly improved the commit log.

Applied to master, thanks.

Best regards,
Romain

Quoted 24 lines
---
 package/Config.in.host                   | 1 +
 package/arm-gnu-toolchain/Config.in.host | 4 ++++
 2 files changed, 5 insertions(+)
 create mode 100644 package/arm-gnu-toolchain/Config.in.host
package/Config.in.host +1 -0
index e4fbee4f2a..360ba9dad6 100644
@@ -5,6 +5,7 @@ menu "Host utilities"
 	source "package/agent-proxy/Config.in.host"
 	source "package/amlogic-boot-fip/Config.in.host"
 	source "package/android-tools/Config.in.host"
+	source "package/arm-gnu-toolchain/Config.in.host"
 	source "package/asn1c/Config.in.host"
 	source "package/babeltrace2/Config.in.host"
 	source "package/bmap-tools/Config.in.host"
package/arm-gnu-toolchain/Config.in.host new file +0 -0
new file mode 100644
index 0000000000..dfd30e5223

package/arm-gnu-toolchain/Config.in.host line 4

Quoted 4 lines
package/arm-gnu-toolchain/Config.in.host new file +4 -0
@@ -0,0 +1,4 @@
+config BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN_SUPPORTS
+	bool "host arm-gnu-toolchain"
+	default y if BR2_HOSTARCH = "aarch64"
+	default y if BR2_HOSTARCH = "x86_64"

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot