Skip to contentSkip to conversation

mfd: cs42l43: Prepare support for updated bios patch

PATCH In review Maciej Strozek 2 participants 4 messages Oct 23, 2024

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: cs42l43: Prepare support for updated bios patch

Newer bios patch firmware versions now require use of the shadow register interface, which was previously only required by the full firmware, update the check accordingly.

---
 drivers/mfd/cs42l43.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/mfd/cs42l43.c +3 -1
index 3b4efb294471..35a633457a93 100644
@@ -48,6 +48,7 @@
 
 #define CS42L43_MCU_SUPPORTED_REV		0x2105
 #define CS42L43_MCU_SHADOW_REGS_REQUIRED_REV	0x2200
+#define CS42L43_BIOS_SHADOW_REGS_REQUIRED_REV	0x1002
 #define CS42L43_MCU_SUPPORTED_BIOS_REV		0x0001
 
 #define CS42L43_VDDP_DELAY_US			50
@@ -773,7 +774,8 @@ static int cs42l43_mcu_update_step(struct cs42l43 *cs42l43)
 	 * Later versions of the firmwware require the driver to access some
 	 * features through a set of shadow registers.
 	 */
-	shadow = mcu_rev >= CS42L43_MCU_SHADOW_REGS_REQUIRED_REV;
+	shadow = (mcu_rev >= CS42L43_MCU_SHADOW_REGS_REQUIRED_REV) ||
+		 (bios_rev >= CS42L43_BIOS_SHADOW_REGS_REQUIRED_REV);
 
 	ret = regmap_read(cs42l43->regmap, CS42L43_BOOT_CONTROL, &secure_cfg);
 	if (ret) {

--
2.34.1

#1 lore raw

PATCH v2 1/1 spi: cs42l43: Correct name of ACPI property

Fixes 439fbc97502a ("spi: cs42l43: Add bridged cs35l56 amplifiers")

---
v2: Corrected the Fixes tag to point to right commit

 drivers/spi/spi-cs42l43.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-cs42l43.c +1 -1
index cdc61cd089ad..9d747ea69926 100644
@@ -267,7 +267,7 @@ static bool cs42l43_has_sidecar(struct fwnode_handle *fwnode)
 			continue;
 
 		ret = fwnode_property_read_u32(ext_fwnode,
-					       "01fa-cirrus-sidecar-instances",
+					       "01fa-sidecar-instances",
 					       &val);
 
 		fwnode_handle_put(ext_fwnode);

--
2.34.1

#2 lore raw

Re: [PATCH v2] spi: cs42l43: Correct name of ACPI property

W dniu śro, 23.10.2024 o godzinie 11∶06 +0100, użytkownik Maciej

Quoted 4 lines · Strozek
Fixes 439fbc97502a ("spi: cs42l43: Add bridged cs35l56 amplifiers")

---

Sorry, sent this old spi v2 patch in error, please ignore

Signature · 2 lines
Regards,
Maciej