mm/codetag: uninline and move pgalloc_tag_copy and pgalloc_tag_split
Subsystems (4)
Suren Baghdasaryan
maintainerPATCH 1/1 mm/codetag: uninline and move pgalloc_tag_copy and pgalloc_tag_split
pgalloc_tag_copy() and pgalloc_tag_split() are sizable and outside of any performance-critical paths, so it should be fine to uninline them. Also move their declarations into pgalloc_tag.h which seems like a more appropriate place for them.
No functional changes other than uninlining.
---
Applies over mm-unstable
include/linux/mm.h | 58 ------------------------------------- include/linux/pgalloc_tag.h | 5 ++++ lib/alloc_tag.c | 48 ++++++++++++++++++++++++++++++ 3 files changed, 53 insertions(+), 58 deletions(-)
include/linux/mm.h +0 -58
@@ -4165,62 +4165,4 @@ static inline int do_mseal(unsigned long start, size_t len_in, unsigned long fla }#endif -#ifdef CONFIG_MEM_ALLOC_PROFILING -static inline void pgalloc_tag_split (struct folio *folio,int old_order,int new_order) -{ -int i; -struct alloc_tag *tag; -unsigned int nr_pages =1 << new_order; - -if (!mem_alloc_profiling_enabled ()) -return ; - - tag =pgalloc_tag_get (&folio->page); -if (!tag) -return ; - -for (i = nr_pages; i < (1 << old_order); i += nr_pages) { -union pgtag_ref_handle handle; -union codetag_ref ref; - -if (get_page_tag_ref (folio_page (folio, i), &ref, &handle)) { -/* Set new reference to point to the original tag */ -alloc_tag_ref_set (&ref, tag); -update_page_tag_ref (handle, &ref); -put_page_tag_ref (handle); - } - } -} - -static inline void pgalloc_tag_copy (struct folio *new,struct folio *old) -{ -union pgtag_ref_handle handle; -union codetag_ref ref; -struct alloc_tag *tag; - - tag =pgalloc_tag_get (&old->page); -if (!tag) -return ; - -if (!get_page_tag_ref (&new->page, &ref, &handle)) -return ; - -/* Clear the old ref to the original allocation tag. */ -clear_page_tag_ref (&old->page); -/* Decrement the counters of the tag on get_new_folio. */ -alloc_tag_sub (&ref,folio_size (new)); -__alloc_tag_ref_set (&ref, tag); -update_page_tag_ref (handle, &ref); -put_page_tag_ref (handle); -} -#else /* !CONFIG_MEM_ALLOC_PROFILING */ -static inline void pgalloc_tag_split (struct folio *folio,int old_order,int new_order) -{ -} - -static inline void pgalloc_tag_copy (struct folio *new,struct folio *old) -{ -} -#endif /* CONFIG_MEM_ALLOC_PROFILING */ -#endif /* _LINUX_MM_H */
include/linux/pgalloc_tag.h +5 -0
@@ -230,6 +230,9 @@ static inline void pgalloc_tag_sub_pages(struct alloc_tag *tag, unsigned int nr) this_cpu_sub(tag->counters->bytes, PAGE_SIZE * nr); } +void pgalloc_tag_split (struct folio *folio,int old_order,int new_order); +void pgalloc_tag_copy (struct folio *new,struct folio *old); +void __init alloc_tag_sec_init (void );#else /* CONFIG_MEM_ALLOC_PROFILING */
@@ -241,6 +244,8 @@ static inline void pgalloc_tag_sub(struct page *page, unsigned int nr) {}static inline struct alloc_tag *pgalloc_tag_get (struct page *page) {return NULL ; }static inline void pgalloc_tag_sub_pages (struct alloc_tag *tag,unsigned int nr) {}static inline void alloc_tag_sec_init (void ) {} +static inline void pgalloc_tag_split (struct folio *folio,int old_order,int new_order) {} +static inline void pgalloc_tag_copy (struct folio *new,struct folio *old) {}#endif /* CONFIG_MEM_ALLOC_PROFILING */
lib/alloc_tag.c +48 -0
54 lines not on this page · raw message
base-commit: 9c111059234a949a4d3442a413ade19cc65ab927
Signature · 1 line
2.47.0.105.g07ac214952-goog
Quoted 9 lines · Suren Baghdasaryan
pgalloc_tag_copy()andpgalloc_tag_split()are sizable and outside of any performance-critical paths, so it should be fine to uninline them. Also move their declarations intopgalloc_tag.hwhich seems like a more appropriate place for them.
No functional changes other than uninlining.Signed-off-by Suren Baghdasaryan <[email protected]>Suggested-by Andrew Morton <[email protected]>