Skip to contentSkip to conversation

gpiolib: remove leftover spinlock bits

PATCH Applied Bartosz Golaszewski 1 participant 2 messages Oct 24, 2024 – Oct 31, 2024 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpiolib: remove leftover spinlock bits

From: Bartosz Golaszewski <[email protected]>

We no longer use any spinlocks in gpiolib.c. Stop including linux/spinlock.h and remove an outdated comment.

---
 drivers/gpio/gpiolib.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/gpio/gpiolib.c +0 -6
index ae758ba6dc3d..fa68ff574d10 100644
@@ -24,7 +24,6 @@
 #include <linux/pinctrl/consumer.h>
 #include <linux/seq_file.h>
 #include <linux/slab.h>
-#include <linux/spinlock.h>
 #include <linux/srcu.h>
 #include <linux/string.h>
 
@@ -1223,11 +1222,6 @@ struct gpio_device *gpio_device_find(const void *data,
 	struct gpio_device *gdev;
 	struct gpio_chip *gc;
 
-	/*
-	 * Not yet but in the future the spinlock below will become a mutex.
-	 * Annotate this function before anyone tries to use it in interrupt
-	 * context like it happened with gpiochip_find().
-	 */
 	might_sleep();
 
 	guard(srcu)(&gpio_devices_srcu);
Signature · 1 line
2.45.2
author Applied
#1 lore raw

From: Bartosz Golaszewski <[email protected]>

Quoted 4 lines · Bartosz Golaszewski

We no longer use any spinlocks in gpiolib.c. Stop including linux/spinlock.h and remove an outdated comment.

Applied, thanks!

[1/1] gpiolib: remove leftover spinlock bits

      commit: 01aab9fd0a838a6195863b0b019eed648f41edb2

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>