bcachefs: fix null-ptr-deref in have_stripes()
PATCH v2 1/1 bcachefs: fix null-ptr-deref in have_stripes()
c->btree_roots_known[i].b can be NULL. In this case, a NULL pointer dereference occurs, so you need to add code to check the variable.
--- fs/bcachefs/sb-downgrade.c | 3 +++ 1 file changed, 3 insertions(+)
fs/bcachefs/sb-downgrade.c +3 -0
@@ -143,6 +143,9 @@ UPGRADE_TABLE()static int have_stripes (struct bch_fs *c) { +if (IS_ERR_OR_NULL (c->btree_roots_known[BTREE_ID_stripes].b)) +return 0 ; +return !btree_node_fake (c->btree_roots_known[BTREE_ID_stripes].b); }
--
Quoted 6 lines · Jeongjun Park
c->btree_roots_known[i].b can be NULL. In this case, a NULL pointer dereference occurs, so you need to add code to check the variable.
Reported-by [email protected]Fixes 7773df19c35f ("bcachefs: metadata version bucket_stripe_sectors")Signed-off-by Jeongjun Park <[email protected]>
This looks identical to the v1? It's already in my testing branch
(But it should be in my hotfix branch, doing that now)
Quoted 19 lines
--- fs/bcachefs/sb-downgrade.c | 3 +++ 1 file changed, 3 insertions(+)fs/bcachefs/sb-downgrade.c +3
-1@@ -143,6 +143,9 @@ UPGRADE_TABLE()static int have_stripes (struct bch_fs *c) { +if (IS_ERR_OR_NULL (c->btree_roots_known[BTREE_ID_stripes].b)) +return 0 ; +return !btree_node_fake (c->btree_roots_known[BTREE_ID_stripes].b); } --
Quoted 10 lines · Kent Overstreet
Quoted 6 lines · Jeongjun Park
c->btree_roots_known[i].b can be NULL. In this case, a NULL pointer dereference occurs, so you need to add code to check the variable.
Reported-by [email protected]Fixes 7773df19c35f ("bcachefs: metadata version bucket_stripe_sectors")Signed-off-by Jeongjun Park <[email protected]>This looks identical to the v1? It's already in my testing branch
This version fix the “Fixes" tag, the original one is:
"Fixes: ("bcachefs: metadata version bucket_stripe_sectors”)"
Quoted 23 lines
(But it should be in my hotfix branch, doing that now)
Quoted 19 lines
---
fs/bcachefs/sb-downgrade.c| 3 +++1 file changed, 3 insertions(+)fs/bcachefs/sb-downgrade.c +3
-1@@ -143,6 +143,9 @@ UPGRADE_TABLE()static int have_stripes (struct bch_fs *c) { +if (IS_ERR_OR_NULL (c->btree_roots_known[BTREE_ID_stripes].b)) +return 0 ; +return !btree_node_fake (c->btree_roots_known[BTREE_ID_stripes].b); } --
Quoted 10 lines · Alan Huang
Quoted 9 lines · Kent Overstreet
Quoted 6 lines · Jeongjun Park
c->btree_roots_known[i].b can be NULL. In this case, a NULL pointer dereference occurs, so you need to add code to check the variable.
Reported-by [email protected]Fixes 7773df19c35f ("bcachefs: metadata version bucket_stripe_sectors")Signed-off-by Jeongjun Park <[email protected]>
Quoted 5 lines
Quoted 1 line
This looks identical to the v1? It's already in my testing branch
This version fix the “Fixes" tag, the original one is:
"Fixes: ("bcachefs: metadata version bucket_stripe_sectors”)"
thanks