Skip to contentSkip to conversation

nvmetcli: fix double ana groupid when save config

PATCH In review Guixin Liu 3 participants 5 messages Oct 29, 2024 – Dec 24, 2024 NVMe

lore
Share & tools
lore

Guixin Liu

author
#0 lore raw

PATCH 1/1 nvmetcli: fix double ana groupid when save config

There are two ana grpid in json file after save the config, including ana group: "ana":{"grpid"}, and "ana_grpid", remove one, still one can use both of them to set ana_grpid.

---
 nvmet/nvme.py | 1 -
 1 file changed, 1 deletion(-)
nvmet/nvme.py +0 -1
index 59efdb5..41b4845 100644
@@ -626,7 +626,6 @@ class Namespace(CFSNode):
     def dump(self):
         d = super(Namespace, self).dump()
         d['nsid'] = self.nsid
-        d['ana_grpid'] = self.grpid
         return d
 
 
Signature · 1 line
2.43.0
author
#1 lore raw

gentle ping...

Best Regards,

Guixin Liu

Quoted 21 lines · Guixin Liu

There are two ana grpid in json file after save the config, including ana group: "ana":{"grpid"}, and "ana_grpid", remove one, still one can use both of them to set ana_grpid.

---
  nvmet/nvme.py | 1 -
  1 file changed, 1 deletion(-)
nvmet/nvme.py +0 -1
index 59efdb5..41b4845 100644
@@ -626,7 +626,6 @@ class Namespace(CFSNode):
      def dump(self):
          d = super(Namespace, self).dump()
          d['nsid'] = self.nsid
-        d['ana_grpid'] = self.grpid
          return d
 
 
author
#2 lore raw

Hi Christoph,

  Could you please take a look on this patch? And also "[PATCH] nvmetcli: reservation

configuration support" which send in 2024/10/29, thanks.

Best Regards,

Guixin Liu

Quoted 26 lines · Guixin Liu

gentle ping...

Best Regards,

Guixin Liu

Quoted 19 lines · Guixin Liu

There are two ana grpid in json file after save the config, including ana group: "ana":{"grpid"}, and "ana_grpid", remove one, still one can use both of them to set ana_grpid.

---
  nvmet/nvme.py | 1 -

  1 file changed, 1 deletion(-)
nvmet/nvme.py +0 -0
index 59efdb5..41b4845 100644
@@ -626,7 +626,6 @@ class Namespace(CFSNode):

      def dump(self):
          d = super(Namespace, self).dump()
          d['nsid'] = self.nsid
-        d['ana_grpid'] = self.grpid
          return d

Reviewed-by on v1 1/1
#3 lore raw
In reply to Guixin Liu
Quoted 14 lines · Guixin Liu

There are two ana grpid in json file after save the config, including ana group: "ana":{"grpid"}, and "ana_grpid", remove one, still one can use both of them to set ana_grpid.

---
  nvmet/nvme.py | 1 -
  1 file changed, 1 deletion(-)
nvmet/nvme.py +0 -0
index 59efdb5..41b4845 100644

nvmet/nvme.py class Namespace(CFSNode): · line 631

Quoted 7 lines
nvmet/nvme.py +0 -1
@@ -626,7 +626,6 @@ class Namespace(CFSNode):
      def dump(self):
          d = super(Namespace, self).dump()
          d['nsid'] = self.nsid
-        d['ana_grpid'] = self.grpid
          return d
 
 

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke                  Kernel Storage Architect
[email protected]                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich