Skip to contentSkip to conversation

net/mlx5: fix PMD compilation in non-HWS setup

PATCH In review Gregory Etelson 2 participants 2 messages Oct 29, 2024 – Oct 30, 2024 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx5: fix PMD compilation in non-HWS setup

The PMD calls mlx5_hw_ctx_validate() function to differentiate between HWS and SWS run-time setups.

The function was not defined if HWS functionality was not enabled during meson code configuration.

The patch creates default weak mlx5_hw_ctx_validate symbol.

Fixes d3144c59ac98 ("net/mlx5: validate HWS context in meter operations")
---
 drivers/net/mlx5/mlx5_flow.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/net/mlx5/mlx5_flow.c +7 -0
index 9c43201e05..bfe757ec26 100644
@@ -12321,3 +12321,10 @@ mlx5_ctrl_flow_uc_dmac_vlan_exists(struct rte_eth_dev *dev,
 	}
 	return exists;
 }
+
+__rte_weak bool
+mlx5_hw_ctx_validate(__rte_unused const struct rte_eth_dev *dev,
+		     __rte_unused struct rte_flow_error *error)
+{
+	return false;
+}
Signature · 1 line
2.43.0
#1 lore raw

Hi,

From: Gregory Etelson <[email protected]>
Sent: Tuesday, October 29, 2024 3:34 PM
To: [email protected]
Cc: Gregory Etelson; Maayan Kashani; Raslan Darawsheh; Dariusz Sosnowski; Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad
Subject: [PATCH] net/mlx5: fix PMD compilation in non-HWS setup

The PMD calls mlx5_hw_ctx_validate() function to differentiate between HWS and SWS run-time setups.

The function was not defined if HWS functionality was not enabled during meson code configuration.

The patch creates default weak mlx5_hw_ctx_validate symbol.

Fixes d3144c59ac98 ("net/mlx5: validate HWS context in meter operations")

Patch squashed into relevant commit in next-net-mlx,

Kindest regards,
Raslan Darawsheh