Skip to contentSkip to conversation

media: remove dead TI wl128x FM radio driver

PATCH In review Lukas Bulwahn 4 participants 4 messages Oct 28, 2024 – Dec 3, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: remove dead TI wl128x FM radio driver

From: Lukas Bulwahn <[email protected]>

Commit 78fe66360ed6 ("misc: ti-st: st_kim: remove the driver") deletes the ti-st driver and its corresponding config option TI_ST.

With that deletion, the Texas Instruments WL128x FM Radio driver is now dead as well. Delete this obsolete driver.

---
 drivers/media/radio/Kconfig               |    4 -
 drivers/media/radio/Makefile              |    1 -
 drivers/media/radio/wl128x/Kconfig        |   15 -
 drivers/media/radio/wl128x/Makefile       |    7 -
 drivers/media/radio/wl128x/fmdrv.h        |  229 ---
 drivers/media/radio/wl128x/fmdrv_common.c | 1676 ---------------------
 drivers/media/radio/wl128x/fmdrv_common.h |  389 -----
 drivers/media/radio/wl128x/fmdrv_rx.c     |  820 ----------
 drivers/media/radio/wl128x/fmdrv_rx.h     |   45 -
 drivers/media/radio/wl128x/fmdrv_tx.c     |  413 -----
 drivers/media/radio/wl128x/fmdrv_tx.h     |   24 -
 drivers/media/radio/wl128x/fmdrv_v4l2.c   |  604 --------
 drivers/media/radio/wl128x/fmdrv_v4l2.h   |   20 -
 13 files changed, 4247 deletions(-)
 delete mode 100644 drivers/media/radio/wl128x/Kconfig
 delete mode 100644 drivers/media/radio/wl128x/Makefile
 delete mode 100644 drivers/media/radio/wl128x/fmdrv.h
 delete mode 100644 drivers/media/radio/wl128x/fmdrv_common.c
 delete mode 100644 drivers/media/radio/wl128x/fmdrv_common.h
 delete mode 100644 drivers/media/radio/wl128x/fmdrv_rx.c
 delete mode 100644 drivers/media/radio/wl128x/fmdrv_rx.h
 delete mode 100644 drivers/media/radio/wl128x/fmdrv_tx.c
 delete mode 100644 drivers/media/radio/wl128x/fmdrv_tx.h
 delete mode 100644 drivers/media/radio/wl128x/fmdrv_v4l2.c
 delete mode 100644 drivers/media/radio/wl128x/fmdrv_v4l2.h
drivers/media/radio/Kconfig +0 -4
index d52eccdc7eb9..72776d08046a 100644
@@ -221,10 +221,6 @@ config USB_RAREMONO
 source "drivers/media/radio/si470x/Kconfig"
 source "drivers/media/radio/si4713/Kconfig"
 
-# TI's ST based wl128x FM radio
-
-source "drivers/media/radio/wl128x/Kconfig"
-
 #
 # ISA drivers configuration
 #
drivers/media/radio/Makefile +0 -1
index cfb6af7d3bc3..1ff46f3a6ed3 100644
@@ -31,7 +31,6 @@ obj-$(CONFIG_RADIO_TIMBERDALE) += radio-timb.o
 obj-$(CONFIG_RADIO_TRUST) += radio-trust.o
 obj-$(CONFIG_RADIO_TYPHOON) += radio-typhoon.o
 obj-$(CONFIG_RADIO_WL1273) += radio-wl1273.o
-obj-$(CONFIG_RADIO_WL128X) += wl128x/
 obj-$(CONFIG_RADIO_ZOLTRIX) += radio-zoltrix.o
 
 obj-$(CONFIG_USB_DSBR) += dsbr100.o
drivers/media/radio/wl128x/Kconfig deleted +0 -15
deleted file mode 100644
index 3e7713872e3f..000000000000
@@ -1,15 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0-only
-#
-# TI's wl128x FM driver based on TI's ST driver.
-#
-config RADIO_WL128X
-	tristate "Texas Instruments WL128x FM Radio"
-	depends on VIDEO_DEV && RFKILL && TTY && TI_ST
-	depends on GPIOLIB || COMPILE_TEST
-	help
-	  Choose Y here if you have this FM radio chip.
-
-	  In order to control your radio card, you will need to use programs
-	  that are compatible with the Video For Linux 2 API.  Information on
-	  this API and pointers to "v4l2" programs may be found at
-	  <file:Documentation/userspace-api/media/index.rst>.
drivers/media/radio/wl128x/Makefile deleted +0 -7
deleted file mode 100644
index 4396ca416cfa..000000000000
@@ -1,7 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0-only
-#
-# Makefile for TI's shared transport driver based wl128x
-# FM radio.
-#
-obj-$(CONFIG_RADIO_WL128X)	+= fm_drv.o
-fm_drv-objs		:= fmdrv_common.o fmdrv_rx.o fmdrv_tx.o fmdrv_v4l2.o
drivers/media/radio/wl128x/fmdrv.h deleted +0 -229

229 lines not on this page · raw message

drivers/media/radio/wl128x/fmdrv_common.c deleted +0 -1676

1,676 lines not on this page · raw message

drivers/media/radio/wl128x/fmdrv_common.h deleted +0 -389

389 lines not on this page · raw message

drivers/media/radio/wl128x/fmdrv_rx.c deleted +0 -820

667 lines not on this page · raw message

drivers/media/radio/wl128x/fmdrv_rx.h deleted +0 -45

45 lines not on this page · raw message

drivers/media/radio/wl128x/fmdrv_tx.c deleted +0 -413

413 lines not on this page · raw message

drivers/media/radio/wl128x/fmdrv_tx.h deleted +0 -24
deleted file mode 100644
index aebdadf9e99b..000000000000

Lines of this file are not shown. View the raw message.

drivers/media/radio/wl128x/fmdrv_v4l2.c deleted +0 -604

604 lines not on this page · raw message

drivers/media/radio/wl128x/fmdrv_v4l2.h deleted +0 -20
deleted file mode 100644
index 963214e9d6f2..000000000000

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.47.0

Part of the diff is not shown here. View the raw message.

#2 lore raw
Quoted 7 lines · Bartosz Golaszewski
Quoted 6 lines · Lukas Bulwahn

From: Lukas Bulwahn <[email protected]>

Commit 78fe66360ed6 ("misc: ti-st: st_kim: remove the driver") deletes the ti-st driver and its corresponding config option TI_ST.

Quoted 8 lines
Quoted 4 lines

With that deletion, the Texas Instruments WL128x FM Radio driver is now dead as well. Delete this obsolete driver.

Amen!

Should I take this through the same tree that the misc driver was removed in? If so, please let me know.

thanks,

greg k-h

#3 lore raw

Hi Greg,

Quoted 11 lines · Greg Kroah-Hartman
Quoted 10 lines · Bartosz Golaszewski
Quoted 9 lines · Lukas Bulwahn

From: Lukas Bulwahn <[email protected]>

Commit 78fe66360ed6 ("misc: ti-st: st_kim: remove the driver") deletes the ti-st driver and its corresponding config option TI_ST.

With that deletion, the Texas Instruments WL128x FM Radio driver is now dead as well. Delete this obsolete driver.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Amen!

Should I take this through the same tree that the misc driver was removed in? If so, please let me know.

Sorry for the late reply, I missed your email. In any case, I'll take this patch.

Regards,

Hans