dt-bindings: omap: Add Samaung Galaxy Tab 2 7.0
Subsystems (3)
PATCH v2 3/6 dt-bindings: omap: Add Samaung Galaxy Tab 2 7.0
Add samsung-espresso7 codename for the 7 inch variant
--- Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/ti/omap.yaml +1 -0
@@ -136,6 +136,7 @@ properties: - motorola,droid-bionic # Motorola Droid Bionic XT875 - motorola,xyboard-mz609 - motorola,xyboard-mz617 + - samsung,espresso7 - ti,omap4-panda - ti,omap4-sdp - const: ti,omap4430
Signature · 1 line
2.43.0
PATCH v2 4/6 arm/dts: Add initial support for Galaxy Tab 2 7.0
Create a device tree for the 3 inch variants (P3100, P3110, P3113)
--- arch/arm/boot/dts/ti/omap/Makefile | 1 + .../dts/ti/omap/omap4-samsung-espresso7.dts | 70 +++++++++++++++++++ 2 files changed, 71 insertions(+) create mode 100644 arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dts
arch/arm/boot/dts/ti/omap/Makefile +1 -0
@@ -76,6 +76,7 @@ dtb-$(CONFIG_ARCH_OMAP4) += \ omap4-panda.dtb \ omap4-panda-a4.dtb \ omap4-panda-es.dtb \ + omap4-samsung-espresso7.dtb \ omap4-sdp.dtb \ omap4-sdp-es23plus.dtb \ omap4-var-dvk-om44.dtb \
arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dts new file +70 -0
70 lines not on this page · raw message
Signature · 1 line
2.43.0
Re: [PATCH v2 4/6] arm/dts: Add initial support for Galaxy Tab 2 7.0
Quoted 1 line · Mithil Bavishi
Create a device tree for the 3 inch variants (P3100, P3110, P3113)
3 inch variants of what? Describe here the hardware.
Quoted 3 lines
Signed-off-by Mithil Bavishi <[email protected]>---
Please use subject prefixes matching the subsystem. You can get them for example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory your patch is touching. For bindings, the preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Quoted 4 lines
arch/arm/boot/dts/ti/omap/Makefile | 1 + .../dts/ti/omap/omap4-samsung-espresso7.dts | 70 +++++++++++++++++++ 2 files changed, 71 insertions(+) create mode 100644 arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dts
PATCH v2 5/6 dt-bindings: omap: Add Samaung Galaxy Tab 2 10.1
In reply to Mithil BavishiAdd samsung-espresso7 codename for the 7 inch variant
--- Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/ti/omap.yaml +1 -0
@@ -137,6 +137,7 @@ properties: - motorola,xyboard-mz609 - motorola,xyboard-mz617 - samsung,espresso7 + - samsung,espresso10 - ti,omap4-panda - ti,omap4-sdp - const: ti,omap4430
Signature · 1 line
2.43.0
PATCH v2 6/6 arm/dts: Add initial support for Galaxy Tab 2 10.1
In reply to Mithil BavishiCreate a device tree for the 10 inch variants (P5100, P5110, P5113)
--- arch/arm/boot/dts/ti/omap/Makefile | 1 + .../dts/ti/omap/omap4-samsung-espresso10.dts | 102 ++++++++++++++++++ 2 files changed, 103 insertions(+) create mode 100644 arch/arm/boot/dts/ti/omap/omap4-samsung-espresso10.dts
arch/arm/boot/dts/ti/omap/Makefile +1 -0
@@ -77,6 +77,7 @@ dtb-$(CONFIG_ARCH_OMAP4) += \ omap4-panda-a4.dtb \ omap4-panda-es.dtb \ omap4-samsung-espresso7.dtb \ + omap4-samsung-espresso10.dtb \ omap4-sdp.dtb \ omap4-sdp-es23plus.dtb \ omap4-var-dvk-om44.dtb \
arch/arm/boot/dts/ti/omap/omap4-samsung-espresso10.dts new file +102 -0
102 lines not on this page · raw message
Signature · 1 line
2.43.0
Quoted 7 lines · Mithil Bavishi
Add samsung-espresso7 codename for the 7 inch variant
Signed-off-by Mithil Bavishi <[email protected]>--- Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + 1 file changed, 1 insertion(+)
This is v2, so where is the changelog? Same for all other patches. No cover letter, no changelogs in patches.
Best regards,
Krzysztof
Andreas Kemnade
maintainerAm Thu, 31 Oct 2024 09:18:49 +0100
schrieb Krzysztof Kozlowski <[email protected]>:
Quoted 12 lines · Mithil Bavishi
Quoted 7 lines
Add samsung-espresso7 codename for the 7 inch variant
Signed-off-by Mithil Bavishi <[email protected]>--- Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + 1 file changed, 1 insertion(+)This is v2, so where is the changelog? Same for all other patches. No cover letter, no changelogs in patches.
The cover letter including changelog is here:
https://lore.kernel.org/linux-omap/[email protected]/T/#t
seems like it was ripped apart somehow.
Regards,
Andreas
Quoted 12 lines · Andreas Kemnade
Am Thu, 31 Oct 2024 09:18:49 +0100
schrieb Krzysztof Kozlowski <[email protected]>:Quoted 9 lines · Mithil Bavishi
Quoted 7 lines
Add samsung-espresso7 codename for the 7 inch variant
Signed-off-by Mithil Bavishi <[email protected]>--- Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + 1 file changed, 1 insertion(+)
Quoted 7 lines
Quoted 3 lines
This is v2, so where is the changelog? Same for all other patches. No cover letter, no changelogs in patches.
The cover letter including changelog is here:
https://lore.kernel.org/linux-omap/[email protected]/T/#tseems like it was ripped apart somehow.
It's not attached to this thread. I don't have it in my mailbox. Neither did b4 when applying entire thread for review. Sending something separately or making it not accessible for review means it does not exist.
Best regards,
Krzysztof
Quoted 4 lines
It's not attached to this thread. I don't have it in my mailbox. Neither did b4 when applying entire thread for review. Sending something separately or making it not accessible for review means it does not exist.
I am not sure why was sent seperately, I'm trying to learn this workflow so it may have been a ametuer mistake from my side, apologies for that. I have notes the changes you requested and will try to apply them in v3 along with others mentioned.
Thanks a lot for your patience.
Best Regards,
Mithil