Skip to contentSkip to conversation

staging: fieldbus: Delete unused driver

PATCH In review Philipp Hortmann 2 participants 2 messages Nov 2, 2024 – Nov 5, 2024 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: fieldbus: Delete unused driver

Sven Van Asbroeck contributed this driver in 2019.

The following reasons lead to the removal:
- This driver generates maintenance workload
- only 11 patches during the last 3 years. Part of the patches seem to be motivated because of maintenance (for example - remove deprecated function)
- Maintainer lost interest, last "Reviewed-by:" is May 2021
- no blog about usage of this driver

The staging subsystem is the way for drivers into the kernel - at current speed and interest this is never going to happen. I think that fieldbus is an interesting topic. But when almost nobody cares about this driver, it does not make sense to keep it. Please consider that support will remain for years in the longterm kernels.

---
Artifacts of fieldbus in MAINTAINERS are removed with this patch. Removed artifacts in Makefile and Kconfig.

---
 MAINTAINERS                                   |   11 -
 drivers/staging/Kconfig                       |    2 -
 drivers/staging/Makefile                      |    1 -
 .../Documentation/ABI/fieldbus-dev-cdev       |   31 -
 .../ABI/sysfs-class-fieldbus-dev              |   62 -
 .../fieldbus/arcx,anybus-controller.txt       |   71 -
 .../fieldbus/Documentation/fieldbus_dev.txt   |   66 -
 drivers/staging/fieldbus/Kconfig              |   19 -
 drivers/staging/fieldbus/Makefile             |    7 -
 drivers/staging/fieldbus/TODO                 |    5 -
 drivers/staging/fieldbus/anybuss/Kconfig      |   41 -
 drivers/staging/fieldbus/anybuss/Makefile     |   10 -
 .../staging/fieldbus/anybuss/anybuss-client.h |   95 --
 .../fieldbus/anybuss/anybuss-controller.h     |   47 -
 .../staging/fieldbus/anybuss/arcx-anybus.c    |  379 -----
 .../staging/fieldbus/anybuss/hms-profinet.c   |  224 ---
 drivers/staging/fieldbus/anybuss/host.c       | 1452 -----------------
 drivers/staging/fieldbus/dev_core.c           |  344 ----
 drivers/staging/fieldbus/fieldbus_dev.h       |  114 --
 19 files changed, 2981 deletions(-)
 delete mode 100644 drivers/staging/fieldbus/Documentation/ABI/fieldbus-dev-cdev
 delete mode 100644 drivers/staging/fieldbus/Documentation/ABI/sysfs-class-fieldbus-dev
 delete mode 100644 drivers/staging/fieldbus/Documentation/devicetree/bindings/fieldbus/arcx,anybus-controller.txt
 delete mode 100644 drivers/staging/fieldbus/Documentation/fieldbus_dev.txt
 delete mode 100644 drivers/staging/fieldbus/Kconfig
 delete mode 100644 drivers/staging/fieldbus/Makefile
 delete mode 100644 drivers/staging/fieldbus/TODO
 delete mode 100644 drivers/staging/fieldbus/anybuss/Kconfig
 delete mode 100644 drivers/staging/fieldbus/anybuss/Makefile
 delete mode 100644 drivers/staging/fieldbus/anybuss/anybuss-client.h
 delete mode 100644 drivers/staging/fieldbus/anybuss/anybuss-controller.h
 delete mode 100644 drivers/staging/fieldbus/anybuss/arcx-anybus.c
 delete mode 100644 drivers/staging/fieldbus/anybuss/hms-profinet.c
 delete mode 100644 drivers/staging/fieldbus/anybuss/host.c
 delete mode 100644 drivers/staging/fieldbus/dev_core.c
 delete mode 100644 drivers/staging/fieldbus/fieldbus_dev.h
MAINTAINERS +0 -11
index b609f40e1420..e4c51d40d42b 100644
@@ -21930,17 +21930,6 @@ L:	[email protected]
 S:	Maintained
 F:	drivers/staging/media/atomisp/
 
-STAGING - FIELDBUS SUBSYSTEM
-M:	Sven Van Asbroeck <[email protected]>
-S:	Maintained
-F:	drivers/staging/fieldbus/*
-F:	drivers/staging/fieldbus/Documentation/
-
-STAGING - HMS ANYBUS-S BUS
-M:	Sven Van Asbroeck <[email protected]>
-S:	Maintained
-F:	drivers/staging/fieldbus/anybuss/
-
 STAGING - INDUSTRIAL IO
 M:	Jonathan Cameron <[email protected]>
 L:	[email protected]
drivers/staging/Kconfig +0 -2
index 4018f95a31bc..075e775d3868 100644
@@ -46,8 +46,6 @@ source "drivers/staging/vc04_services/Kconfig"
 
 source "drivers/staging/axis-fifo/Kconfig"
 
-source "drivers/staging/fieldbus/Kconfig"
-
 source "drivers/staging/vme_user/Kconfig"
 
 source "drivers/staging/gpib/Kconfig"
drivers/staging/Makefile +0 -1
index f29d66da02eb..e681e403509c 100644
@@ -13,5 +13,4 @@ obj-$(CONFIG_MOST)		+= most/
 obj-$(CONFIG_GREYBUS)		+= greybus/
 obj-$(CONFIG_BCM2835_VCHIQ)	+= vc04_services/
 obj-$(CONFIG_XIL_AXIS_FIFO)	+= axis-fifo/
-obj-$(CONFIG_FIELDBUS_DEV)	+= fieldbus/
 obj-$(CONFIG_GPIB)	 	+= gpib/
drivers/staging/fieldbus/Documentation/ABI/fieldbus-dev-cdev deleted +0 -31
deleted file mode 100644
index 45f631ea32a6..000000000000
@@ -1,31 +0,0 @@
-What:		/dev/fieldbus_devX
-Date:		December 2018
-KernelVersion:	5.1 (staging)
-Contact:	Sven Van Asbroeck <[email protected]>
-Description:
-		The cdev interface to drivers for Fieldbus Device Memory
-			(aka. Process Memory).
-
-		The following file operations are supported:
-
-		open(2)
-		Create an I/O context associated with the file descriptor.
-
-		read(2)
-		Read from Process Memory's "read area".
-		Clears POLLERR | POLLPRI from the file descriptor.
-
-		write(2)
-		Write to Process Memory's "write area".
-
-		poll(2), select(2), epoll_wait(2) etc.
-		When a "Process Memory Read Area Changed" event occurs,
-		POLLERR | POLLPRI will be set on the file descriptor.
-		Note that POLLIN | POLLOUT events are always set, because the
-		process memory area is always readable and writable.
-
-		close(2)
-		Free up the I/O context that was associated
-		with the file descriptor.
-
-Users:		TBD
drivers/staging/fieldbus/Documentation/ABI/sysfs-class-fieldbus-dev deleted +0 -62

62 lines not on this page · raw message

drivers/staging/fieldbus/Documentation/devicetree/bindings/fieldbus/arcx,anybus-controller.txt deleted +0 -71

71 lines not on this page · raw message

drivers/staging/fieldbus/Documentation/fieldbus_dev.txt deleted +0 -66

66 lines not on this page · raw message

drivers/staging/fieldbus/Kconfig deleted +0 -19
deleted file mode 100644
index b0b865acccfb..000000000000
@@ -1,19 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0-only
-menuconfig FIELDBUS_DEV
-	tristate "Fieldbus Device Support"
-	help
-	  Support for Fieldbus Device Adapters.
-
-	  Fieldbus device (client) adapters allow data exchange with a PLC aka.
-	  "Fieldbus Controller" over a fieldbus (Profinet, FLNet, etc.)
-
-	  They are typically used when a Linux device wants to expose itself
-	  as an actuator, motor, console light, switch, etc. over the fieldbus.
-
-	  This framework is designed to provide a generic interface to Fieldbus
-	  Devices from both the Linux Kernel and the userspace.
-
-	  If unsure, say no.
-
-source "drivers/staging/fieldbus/anybuss/Kconfig"
-
drivers/staging/fieldbus/Makefile deleted +0 -7
deleted file mode 100644
index bdf645d41344..000000000000
@@ -1,7 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-#
-# Makefile for fieldbus_dev drivers.
-#
-
-obj-$(CONFIG_FIELDBUS_DEV)	+= fieldbus_dev.o anybuss/
-fieldbus_dev-y			:= dev_core.o
drivers/staging/fieldbus/TODO deleted +0 -5
deleted file mode 100644
index 6d6626af4ec7..000000000000
@@ -1,5 +0,0 @@
-TODO:
--Get more people/drivers to use the Fieldbus userspace ABI. It requires
- verification/sign-off by multiple users.
-
-Contact: Sven Van Asbroeck <[email protected]>
drivers/staging/fieldbus/anybuss/Kconfig deleted +0 -41

41 lines not on this page · raw message

drivers/staging/fieldbus/anybuss/Makefile deleted +0 -10
deleted file mode 100644
index 3ad3dcc6be56..000000000000
@@ -1,10 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-#
-# Makefile for anybuss drivers.
-#
-
-obj-$(CONFIG_HMS_ANYBUSS_BUS)	+= anybuss_core.o
-anybuss_core-y			+= host.o
-
-obj-$(CONFIG_ARCX_ANYBUS_CONTROLLER) += arcx-anybus.o
-obj-$(CONFIG_HMS_PROFINET)	+= hms-profinet.o
drivers/staging/fieldbus/anybuss/anybuss-client.h deleted +0 -95

95 lines not on this page · raw message

drivers/staging/fieldbus/anybuss/anybuss-controller.h deleted +0 -47

47 lines not on this page · raw message

drivers/staging/fieldbus/anybuss/arcx-anybus.c deleted +0 -379

379 lines not on this page · raw message

drivers/staging/fieldbus/anybuss/hms-profinet.c deleted +0 -224

224 lines not on this page · raw message

drivers/staging/fieldbus/anybuss/host.c deleted +0 -1452

1,452 lines not on this page · raw message

drivers/staging/fieldbus/dev_core.c deleted +0 -344

344 lines not on this page · raw message

drivers/staging/fieldbus/fieldbus_dev.h deleted +0 -114

114 lines not on this page · raw message

Signature · 1 line
2.43.0