thunderbolt: Fix connection issue with Pluggable UD-4VPD dock
Subsystems (3)
PATCH v2 1/1 thunderbolt: Fix connection issue with Pluggable UD-4VPD dock
Rick reported that his Pluggable USB4 dock does not work anymore after upgrading to v6.10 kernel.
It looks like commit c6ca1ac9f472 ("thunderbolt: Increase sideband access polling delay") makes the device router enumeration happen later than what might be expected by the dock (although there is no such limit in the USB4 spec) which probably makes it assume there is something wrong with the high-speed link and reset it. After the link is reset the same issue happens again and again.
For this reason lower the sideband access delay from 5ms to 1ms. This seems to work fine according to Rick's testing.
---
v1: https://lore.kernel.org/linux-usb/[email protected]/
Changes from v1:
* Reword the commit message to use mainline kernel version (v6.10) instead.
drivers/thunderbolt/usb4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thunderbolt/usb4.c +1 -1
@@ -48,7 +48,7 @@ enum usb4_ba_index {/* Delays in us used with usb4_port_wait_for_bit() */ #define USB4_PORT_DELAY 50 -#define USB4_PORT_SB_DELAY 5000 +#define USB4_PORT_SB_DELAY 1000 static int usb4_native_switch_op(struct tb_switch *sw, u16 opcode, u32 *metadata, u8 *status,
Signature · 1 line
2.45.2
Quoted 13 lines · Mika Westerberg
Rick reported that his Pluggable USB4 dock does not work anymore after upgrading to v6.10 kernel.
It looks like commit
c6ca1ac9f472("thunderbolt: Increase sideband access polling delay") makes the device router enumeration happen later than what might be expected by the dock (although there is no such limit in the USB4 spec) which probably makes it assume there is something wrong with the high-speed link and reset it. After the link is reset the same issue happens again and again.For this reason lower the sideband access delay from 5ms to 1ms. This seems to work fine according to Rick's testing.
Quoted 6 lines
Reported-by Rick Lahaye <[email protected]>Tested-by Rick Lahaye <[email protected]>Fixes c6ca1ac9f472 ("thunderbolt: Increase sideband access polling delay")Signed-off-by Mika Westerberg <[email protected]>
Mika Westerberg
AppliedQuoted 14 lines · Greg KH
Quoted 13 lines · Mika Westerberg
Rick reported that his Pluggable USB4 dock does not work anymore after upgrading to v6.10 kernel.
It looks like commit
c6ca1ac9f472("thunderbolt: Increase sideband access polling delay") makes the device router enumeration happen later than what might be expected by the dock (although there is no such limit in the USB4 spec) which probably makes it assume there is something wrong with the high-speed link and reset it. After the link is reset the same issue happens again and again.For this reason lower the sideband access delay from 5ms to 1ms. This seems to work fine according to Rick's testing.
Quoted 8 lines
Quoted 6 lines
Reported-by Rick Lahaye <[email protected]>Tested-by Rick Lahaye <[email protected]>Fixes c6ca1ac9f472 ("thunderbolt: Increase sideband access polling delay")Signed-off-by Mika Westerberg <[email protected]>
Thanks!
Applied to thunderbolt.git/fixes.
Mario Limonciello
Reviewed-byQuoted 4 lines · Mika Westerberg
Quoted 3 lines · Greg KH
Quoted 2 lines · Mika Westerberg
Rick reported that his Pluggable USB4 dock does not work anymore after upgrading to v6.10 kernel.
If I'm not mistaken Rick was talking about a Dell WD19TB dock which is TBT3, not a Pluggable USB4 dock.
Nonetheless I wouldn't be surprised if other docks and devices have problems.
We have an internal report at AMD of something similar happening with TBT3 storage devices. After this lands I'll ask that team that reported it to see if it helped them too.
Quoted 18 lines
Quoted 18 lines
Quoted 17 lines
It looks like commit
c6ca1ac9f472("thunderbolt: Increase sideband access polling delay") makes the device router enumeration happen later than what might be expected by the dock (although there is no such limit in the USB4 spec) which probably makes it assume there is something wrong with the high-speed link and reset it. After the link is reset the same issue happens again and again.For this reason lower the sideband access delay from 5ms to 1ms. This seems to work fine according to Rick's testing.
Reported-by Rick Lahaye <[email protected]>Tested-by Rick Lahaye <[email protected]>Fixes c6ca1ac9f472 ("thunderbolt: Increase sideband access polling delay")Signed-off-by Mika Westerberg <[email protected]>
Quoted 6 lines
Quoted 1 line
Thanks!
Applied to thunderbolt.git/fixes.
I'm a few hours late to the party, but if you update the commit message for my above comment feel free to add my tag too.
Hi Mario,
Quoted 8 lines · Mario Limonciello
Quoted 4 lines · Mika Westerberg
Quoted 3 lines · Greg KH
Quoted 2 lines · Mika Westerberg
Rick reported that his Pluggable USB4 dock does not work anymore after upgrading to v6.10 kernel.
If I'm not mistaken Rick was talking about a Dell WD19TB dock which is TBT3, not a Pluggable USB4 dock.
To prevent any confusion; I don't own any Dell WD19TB dock. I had these issues with the UD-4VPD dock.
Quoted 25 lines
Nonetheless I wouldn't be surprised if other docks and devices have problems.
We have an internal report at AMD of something similar happening with TBT3 storage devices. After this lands I'll ask that team that reported it to see if it helped them too.
Quoted 20 lines
Quoted 19 lines
Quoted 11 lines
It looks like commit
c6ca1ac9f472("thunderbolt: Increase sideband access polling delay") makes the device router enumeration happen later than what might be expected by the dock (although there is no such limit in the USB4 spec) which probably makes it assume there is something wrong with the high-speed link and reset it. After the link is reset the same issue happens again and again.For this reason lower the sideband access delay from 5ms to 1ms. This seems to work fine according to Rick's testing.
Quoted 6 lines
Reported-by Rick Lahaye <[email protected]>Closes https://lore.kernel.org/linux- usb/[email protected]/Tested-by Rick Lahaye <[email protected]>Fixes c6ca1ac9f472 ("thunderbolt: Increase sideband access polling delay")Signed-off-by Mika Westerberg <[email protected]>
Quoted 8 lines
Quoted 3 lines
Thanks!
Applied to thunderbolt.git/fixes.
I'm a few hours late to the party, but if you update the commit message for my above comment feel free to add my tag too.
Reviewed-by Mario Limonciello <[email protected]>
Kind regards,
Rick Lahaye
Quoted 5 lines · Rick
Hi Mario,
Quoted 2 lines · Mario Limonciello
Quoted 1 line · Mika Westerberg
On Tue, Nov 05, 2024 at 11:54:55AM +0100, Greg KH wrote:
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 3 lines · Mika Westerberg
Quoted 2 lines
Rick reported that his Pluggable USB4 dock does not work anymore after upgrading to v6.10 kernel.
If I'm not mistaken Rick was talking about a Dell WD19TB dock which is TBT3, not a Pluggable USB4 dock.
To prevent any confusion; I don't own any Dell WD19TB dock. I had these issues with the UD-4VPD dock.
Oh! I see, you were saying a "me too" to the thread which was about WD19TB. Thanks for clarifying.
Quoted 39 lines
Quoted 26 lines
Nonetheless I wouldn't be surprised if other docks and devices have problems.
We have an internal report at AMD of something similar happening with TBT3 storage devices. After this lands I'll ask that team that reported it to see if it helped them too.
Quoted 20 lines
Quoted 19 lines
Quoted 11 lines
It looks like commit
c6ca1ac9f472("thunderbolt: Increase sideband access polling delay") makes the device router enumeration happen later than what might be expected by the dock (although there is no such limit in the USB4 spec) which probably makes it assume there is something wrong with the high-speed link and reset it. After the link is reset the same issue happens again and again.For this reason lower the sideband access delay from 5ms to 1ms. This seems to work fine according to Rick's testing.
Quoted 6 lines
Reported-by Rick Lahaye <[email protected]>Closes https://lore.kernel.org/linux- usb/[email protected]/Tested-by Rick Lahaye <[email protected]>Fixes c6ca1ac9f472 ("thunderbolt: Increase sideband access polling delay")Signed-off-by Mika Westerberg <[email protected]>Quoted 8 lines
Quoted 3 lines
Thanks!
Applied to thunderbolt.git/fixes.
I'm a few hours late to the party, but if you update the commit message for my above comment feel free to add my tag too.
Reviewed-by Mario Limonciello <[email protected]>Kind regards,
Rick Lahaye
Quoted 8 lines · Mario Limonciello
Quoted 4 lines · Mika Westerberg
Quoted 3 lines · Greg KH
Quoted 2 lines · Mika Westerberg
Rick reported that his Pluggable USB4 dock does not work anymore after upgrading to v6.10 kernel.
If I'm not mistaken Rick was talking about a Dell WD19TB dock which is TBT3, not a Pluggable USB4 dock.
It is Pluggable device but the report started with Dell WD19TB from another reporter (they should be CC'd).
Quoted 6 lines
Nonetheless I wouldn't be surprised if other docks and devices have problems.
We have an internal report at AMD of something similar happening with TBT3 storage devices. After this lands I'll ask that team that reported it to see if it helped them too.
I would not expect Intel device routers to fail here we have not noticed any issues even with the commit. Pluggable has their own device router IP (or at least not ours) and that kind of behaves differently.
Quoted 20 lines
Quoted 19 lines
Quoted 18 lines
Quoted 10 lines
It looks like commit
c6ca1ac9f472("thunderbolt: Increase sideband access polling delay") makes the device router enumeration happen later than what might be expected by the dock (although there is no such limit in the USB4 spec) which probably makes it assume there is something wrong with the high-speed link and reset it. After the link is reset the same issue happens again and again.For this reason lower the sideband access delay from 5ms to 1ms. This seems to work fine according to Rick's testing.
Quoted 6 lines
Reported-by Rick Lahaye <[email protected]>Tested-by Rick Lahaye <[email protected]>Fixes c6ca1ac9f472 ("thunderbolt: Increase sideband access polling delay")Signed-off-by Mika Westerberg <[email protected]>
Quoted 8 lines
Quoted 3 lines
Thanks!
Applied to thunderbolt.git/fixes.
I'm a few hours late to the party, but if you update the commit message for my above comment feel free to add my tag too.
Reviewed-by Mario Limonciello <[email protected]>
Sure, I'll add that thanks!