Skip to contentSkip to conversation

nvme: add temperature threshold hysteresis feature field definition

PATCH Superseded Tokunori Ikegami 2 participants 3 messages Nov 5, 2024 – Nov 9, 2024 NVMe

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme: add temperature threshold hysteresis feature field definition

The definition TMPTHH field supported by NVMe 2.1.

---
 include/linux/nvme.h | 2 ++
 1 file changed, 2 insertions(+)
include/linux/nvme.h +2 -0
index b58d9405d65e..68c60b0b177f 100644
@@ -1121,6 +1121,8 @@ enum {
 	NVME_TEMP_THRESH_MASK		= 0xffff,
 	NVME_TEMP_THRESH_SELECT_SHIFT	= 16,
 	NVME_TEMP_THRESH_TYPE_UNDER	= 0x100000,
+	NVME_TEMP_THRESH_HYST_SHIFT	= 22,
+	NVME_TEMP_THRESH_HYST_MASK	= 0x7,
 };
 
 struct nvme_feat_auto_pst {
Signature · 1 line
2.45.2
maintainer
#1 lore raw
Quoted 12 lines · Tokunori Ikegami

The definition TMPTHH field supported by NVMe 2.1.

---
 include/linux/nvme.h | 2 ++
 1 file changed, 2 insertions(+)
include/linux/nvme.h +0 -0
index b58d9405d65e..68c60b0b177f 100644

include/linux/nvme.h enum { · line 1126

Quoted 6 lines
include/linux/nvme.h +2 -0
@@ -1121,6 +1121,8 @@ enum {
 	NVME_TEMP_THRESH_MASK		= 0xffff,
 	NVME_TEMP_THRESH_SELECT_SHIFT	= 16,
 	NVME_TEMP_THRESH_TYPE_UNDER	= 0x100000,
+	NVME_TEMP_THRESH_HYST_SHIFT	= 22,
+	NVME_TEMP_THRESH_HYST_MASK	= 0x7,
 };

Let's not define new constants that are not used by the driver.

#2 lore raw
Quoted 1 line · Keith Busch

Let's not define new constants that are not used by the driver.

Understood so just added the driver feature to use the define by the v2 patch.