dt-bindings: PCI: snps,dw-pcie: Drop "#interrupt-cells" from example
Subsystems (4)
Rob Herring (Arm)
maintainerPATCH 1/1 dt-bindings: PCI: snps,dw-pcie: Drop "#interrupt-cells" from example
"#interrupt-cells" is not valid without a corresponding "interrupt-map" or "interrupt-controller" property. As the example has neither, drop "#interrupt-cells". This fixes a dtc interrupt_provider warning.
--- Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 1 - 1 file changed, 1 deletion(-)
Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml +0 -1
@@ -230,7 +230,6 @@ examples: interrupts = <25>, <24>; interrupt-names = "msi", "hp"; - #interrupt-cells = <1>; reset-gpios = <&port0 0 1>;
Signature · 1 line
2.45.2
Krzysztof Wilczyński
AppliedHello,
Quoted 3 lines
"#interrupt-cells" is not valid without a corresponding "interrupt-map" or "interrupt-controller" property. As the example has neither, drop "#interrupt-cells". This fixes a dtc
interrupt_providerwarning.
Applied to dt-bindings, thank you!
[01/01] dt-bindings: PCI: snps,dw-pcie: Drop "#interrupt-cells" from example
https://git.kernel.org/pci/pci/c/718c157a0b94 Krzysztof
Quoted 4 lines · Rob Herring (Arm)
"#interrupt-cells" is not valid without a corresponding "interrupt-map" or "interrupt-controller" property. As the example has neither, drop "#interrupt-cells". This fixes a dtc
interrupt_providerwarning.
But the DWC controllers have an in-built MSI controller. Shouldn't we add 'interrrupt-controller' property then?
- Mani
Quoted 20 lines
Signed-off-by Rob Herring (Arm) <[email protected]>--- Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 1 - 1 file changed, 1 deletion(-)Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml +0
-1@@ -230,7 +230,6 @@ examples: interrupts = <25>, <24>; interrupt-names = "msi", "hp"; - #interrupt-cells = <1>; reset-gpios = <&port0 0 1>;Signature · 1 line
2.45.2
Signature · 1 line
மணிவண்ணன் சதாசிவம்
Rob Herring
maintainerQuoted 9 lines · Manivannan Sadhasivam
Quoted 4 lines · Rob Herring (Arm)
"#interrupt-cells" is not valid without a corresponding "interrupt-map" or "interrupt-controller" property. As the example has neither, drop "#interrupt-cells". This fixes a dtc
interrupt_providerwarning.But the DWC controllers have an in-built MSI controller. Shouldn't we add 'interrrupt-controller' property then?
Why? Is that needed for the MSI controller to function? I don't think so.
Now we do have "interrupt-controller" present for a number of MSI providers. I suspect that's there to get OF_DECLARE to work, but I doubt we really need MSI controllers initialized early.
Rob
Quoted 9 lines · Rob Herring
Quoted 7 lines · Manivannan Sadhasivam
Quoted 4 lines · Rob Herring (Arm)
"#interrupt-cells" is not valid without a corresponding "interrupt-map" or "interrupt-controller" property. As the example has neither, drop "#interrupt-cells". This fixes a dtc
interrupt_providerwarning.
Quoted 5 lines
Quoted 2 lines
But the DWC controllers have an in-built MSI controller. Shouldn't we add 'interrrupt-controller' property then?
Why? Is that needed for the MSI controller to function? I don't think so.
No. I was asking from bindings perspective.
Quoted 4 lines
Now we do have "interrupt-controller" present for a number of MSI providers. I suspect that's there to get
OF_DECLAREto work, but I doubt we really need MSI controllers initialized early.
Again no, for this case. I was under the assumption that all interrupt providers should have the 'interrupt-controller' property in their nodes.
- Mani
Signature · 1 line
மணிவண்ணன் சதாசிவம்
Rob Herring
maintainerQuoted 19 lines · Manivannan Sadhasivam
Quoted 9 lines · Rob Herring
Quoted 7 lines · Manivannan Sadhasivam
Quoted 4 lines · Rob Herring (Arm)
"#interrupt-cells" is not valid without a corresponding "interrupt-map" or "interrupt-controller" property. As the example has neither, drop "#interrupt-cells". This fixes a dtc
interrupt_providerwarning.Quoted 5 lines
Quoted 2 lines
But the DWC controllers have an in-built MSI controller. Shouldn't we add 'interrrupt-controller' property then?
Why? Is that needed for the MSI controller to function? I don't think so.
No. I was asking from bindings perspective.
Quoted 7 lines
Quoted 4 lines
Now we do have "interrupt-controller" present for a number of MSI providers. I suspect that's there to get
OF_DECLAREto work, but I doubt we really need MSI controllers initialized early.Again no, for this case. I was under the assumption that all interrupt providers should have the 'interrupt-controller' property in their nodes.
Yes. What interrupts is the DW controller providing? Only the PCI legacy interrupts which are optional. An msi-controller and an interrupt-controller are 2 distinct providers. An MSI provider is not an interrupt provider, but an interrupt consumer. Some bindings define both, but I think many of those cases are probably wrong.
Rob
Quoted 26 lines · Rob Herring
Quoted 24 lines · Manivannan Sadhasivam
Quoted 9 lines · Rob Herring
Quoted 7 lines · Manivannan Sadhasivam
Quoted 4 lines · Rob Herring (Arm)
"#interrupt-cells" is not valid without a corresponding "interrupt-map" or "interrupt-controller" property. As the example has neither, drop "#interrupt-cells". This fixes a dtc
interrupt_providerwarning.Quoted 5 lines
Quoted 2 lines
But the DWC controllers have an in-built MSI controller. Shouldn't we add 'interrrupt-controller' property then?
Why? Is that needed for the MSI controller to function? I don't think so.
No. I was asking from bindings perspective.
Quoted 4 lines
Now we do have "interrupt-controller" present for a number of MSI providers. I suspect that's there to get
OF_DECLAREto work, but I doubt we really need MSI controllers initialized early.
Quoted 9 lines
Quoted 2 lines
Again no, for this case. I was under the assumption that all interrupt providers should have the 'interrupt-controller' property in their nodes.
Yes. What interrupts is the DW controller providing? Only the PCI legacy interrupts which are optional. An msi-controller and an interrupt-controller are 2 distinct providers. An MSI provider is not an interrupt provider, but an interrupt consumer. Some bindings define both, but I think many of those cases are probably wrong.
Ok, thanks for clarifying.
- Mani
Signature · 1 line
மணிவண்ணன் சதாசிவம்