mm-vmstat-defer-the-refresh_zone_stat_thresholds-after-all-cpus-bringup.patch removed from -mm tree
The quilt patch titled
Subject: mm/vmstat: defer the refresh_zone_stat_thresholds after all CPUs bringup
has been removed from the -mm tree. Its filename was
mm-vmstat-defer-the-refresh_zone_stat_thresholds-after-all-cpus-bringup.patch
This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Saurabh Sengar <[email protected]>
Subject: mm/vmstat: defer the refresh_zone_stat_thresholds after all CPUs bringup
Date: Sun, 11 Aug 2024 23:13:40 -0700
refresh_zone_stat_thresholds function has two loops which is expensive for higher number of CPUs and NUMA nodes.
Below is the rough estimation of total iterations done by these loops based on number of NUMA and CPUs.
Total number of iterations: nCPU * 2 * Numa * mCPU Where:
nCPU = total number of CPUs
Numa = total number of NUMA nodes
mCPU = mean value of total CPUs (e.g., 512 for 1024 total CPUs)
For the system under test with 16 NUMA nodes and 1024 CPUs, this results in a substantial increase in the number of loop iterations during boot-up when NUMA is enabled:
No NUMA = 1024*2*1*512 = 1,048,576 : Here refresh_zone_stat_thresholds
takes around 224 ms total for all the CPUs in the system under test. 16 NUMA = 1024*2*16*512 = 16,777,216 : Here refresh_zone_stat_thresholds takes around 4.5 seconds total for all the CPUs in the system under test.
Calling this for each CPU is expensive when there are large number of CPUs along with multiple NUMAs. Fix this by deferring refresh_zone_stat_thresholds to be called later at once when all the secondary CPUs are up. Also, register the DYN hooks to keep the existing hotplug functionality intact.
---
mm/vmstat.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
mm/vmstat.c renamed from mm/vmstat.c~mm-vmstat-defer-the-refresh_zone_stat_thresholds-after-all-cpus-bringup +11 -1
@@ -1933,6 +1933,7 @@ static const struct seq_operations vmsta#ifdef CONFIG_SMP static DEFINE_PER_CPU(struct delayed_work, vmstat_work);int sysctl_stat_interval__read_mostly =HZ ; +static int vmstat_late_init_done;#ifdef CONFIG_PROC_FS static void refresh_vm_stats (struct work_struct *work)
@@ -2135,7 +2136,8 @@ static void __init init_cpu_node_state(vstatic int vmstat_cpu_online (unsigned int cpu) { -refresh_zone_stat_thresholds (); +if (vmstat_late_init_done) +refresh_zone_stat_thresholds ();if (!node_state (cpu_to_node (cpu),N_CPU )) {node_set_state (cpu_to_node (cpu),N_CPU );
@@ -2167,6 +2169,14 @@ static int vmstat_cpu_dead(unsigned int return 0; } +static int __init vmstat_late_init (void ) +{ +refresh_zone_stat_thresholds (); + vmstat_late_init_done =1 ; + +return 0 ; +} +late_initcall (vmstat_late_init);#endif struct workqueue_struct *mm_percpu_wq;
_
Patches currently in -mm which might be from [email protected] are