ALSA: compress_offload: Use runtime pointer in snd_compr_poll()
Subsystems (2)
PATCH 1/1 ALSA: compress_offload: Use runtime pointer in snd_compr_poll()
runtime is not used as seen with W=1 :sound/core/compress_offload.c: In function ‘snd_compr_poll’:sound/core/compress_offload.c:409:35: error: variable ‘runtime’ set but not used [-Werror=unused-but-set-variable]
409 | struct snd_compr_runtime *runtime;
| ^~~~~~~
Instead of dropping the runtime, use it in the function in place of stream->runtime
--- sound/core/compress_offload.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
sound/core/compress_offload.c +5 -5
@@ -418,7 +418,7 @@ static __poll_t snd_compr_poll(struct file *f, poll_table *wait)guard (mutex)(&stream->device->lock); -switch (stream->runtime->state) { +switch (runtime->state) {case SNDRV_PCM_STATE_OPEN :case SNDRV_PCM_STATE_XRUN :return snd_compr_get_poll (stream) |EPOLLERR ;
@@ -426,7 +426,7 @@ static __poll_t snd_compr_poll(struct file *f, poll_table *wait)break ; } -poll_wait (f, &stream->runtime->sleep, wait); +poll_wait (f, &runtime->sleep, wait);#if IS_ENABLED (CONFIG_SND_COMPRESS_ACCEL )if (stream->direction ==SND_COMPRESS_ACCEL ) {
@@ -445,18 +445,18 @@ static __poll_t snd_compr_poll(struct file *f, poll_table *wait) avail =snd_compr_get_avail (stream);pr_debug ("avail is %ld\n" , (unsigned long )avail);/* check if we have at least one fragment to fill */ -switch (stream->runtime->state) { +switch (runtime->state) {case SNDRV_PCM_STATE_DRAINING :/* stream has been woken up after drain is complete * draining done so set stream state to stopped */ retval =snd_compr_get_poll (stream); - stream->runtime->state =SNDRV_PCM_STATE_SETUP ; + runtime->state =SNDRV_PCM_STATE_SETUP ;break ;case SNDRV_PCM_STATE_RUNNING :case SNDRV_PCM_STATE_PREPARED :case SNDRV_PCM_STATE_PAUSED : -if (avail >= stream->runtime->fragment_size) +if (avail >= runtime->fragment_size) retval =snd_compr_get_poll (stream);break ;default :
Signature · 1 line
2.47.0
Quoted 8 lines · Peter Ujfalusi
runtime is not used as seen with W=1 :
sound/core/compress_offload.c: In function ‘snd_compr_poll’:sound/core/compress_offload.c:409:35: error: variable ‘runtime’ set but not used [-Werror=unused-but-set-variable]
409 | structsnd_compr_runtime*runtime;
| ^~~~~~~Instead of dropping the runtime, use it in the function in place of
stream->runtime
Yes, it was the desired target for this change. Unfortunately unfinished. Thanks.
Signature · 2 lines
Jaroslav Kysela <[email protected]> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
Quoted 7 lines · Peter Ujfalusi
runtime is not used as seen with W=1 :
sound/core/compress_offload.c: In function ‘snd_compr_poll’:sound/core/compress_offload.c:409:35: error: variable ‘runtime’ set but not used [-Werror=unused-but-set-variable]
409 | structsnd_compr_runtime*runtime;
| ^~~~~~~
Quoted 5 lines
Instead of dropping the runtime, use it in the function in place of
stream->runtimeFixes 04177158cf98 ("ALSA: compress_offload: introduce accel operation mode")Signed-off-by Peter Ujfalusi <[email protected]>
Applied now. Thanks.
Takashi