Skip to contentSkip to conversation

of/fdt: Don't use default address cell sizes for address translation

PATCH New Rob Herring (Arm) 1 participant 1 message Nov 6, 2024 Device tree

lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 of/fdt: Don't use default address cell sizes for address translation

FDT systems should never be relying on default cell sizes. It's been a warning in dtc since 2007. The behavior here doesn't even match the unflattened code which will walk the parent nodes looking for the cell size properties (also deprecated). Furthermore, the FDT address translation code is only used in one spot by SH and for earlycon which was added 2014 and certainly isn't used on Powerpc systems.

Returning -1 values will result in an error message.

---
 drivers/of/fdt_address.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/of/fdt_address.c +2 -2
index 1dc15ab78b10..9804d7f06705 100644
@@ -55,7 +55,7 @@ static void __init fdt_bus_default_count_cells(const void *blob, int parentoffse
 		if (prop)
 			*addrc = be32_to_cpup(prop);
 		else
-			*addrc = dt_root_addr_cells;
+			*addrc = -1;
 	}
 
 	if (sizec) {
@@ -63,7 +63,7 @@ static void __init fdt_bus_default_count_cells(const void *blob, int parentoffse
 		if (prop)
 			*sizec = be32_to_cpup(prop);
 		else
-			*sizec = dt_root_size_cells;
+			*sizec = -1;
 	}
 }
 
Signature · 1 line
2.45.2