bpf: add bpf_get_cpu_cycles kfunc
Subsystems (7)
PATCH v4 1/4 bpf: add bpf_get_cpu_cycles kfunc
New kfunc to return ARCH-specific timecounter. For x86 BPF JIT converts it into rdtsc ordered call. Other architectures will get JIT implementation too if supported. The fallback is to __arch_get_hw_counter().
v3 -> v4:
* change name of the helper to bpf_get_cpu_cycles (Andrii)
* Hide the helper behind CONFIG_GENERIC_GETTIMEOFDAY to avoid exposing it on architectures which do not have vDSO functions and data
* reduce the scope of check of inlined functions in verifier to only 2, which are actually inlined.
v2 -> v3:
* change name of the helper to bpf_get_cpu_cycles_counter to explicitly mention what counter it provides (Andrii)
* move kfunc definition to bpf.h to use it in JIT.
* introduce another kfunc to convert cycles into nanoseconds as more meaningful time units for generic tracing use case (Andrii)
v1 -> v2:
* Fix incorrect function return value type to u64
* Introduce bpf_jit_inlines_kfunc_call() and use it in mark_fastcall_pattern_for_call() to avoid clobbering in case of running programs with no JIT (Eduard)
* Avoid rewriting instruction and check function pointer directly in JIT (Alexei)
* Change includes to fix compile issues on non x86 architectures
--- arch/x86/net/bpf_jit_comp.c | 28 ++++++++++++++++++++++++++++ arch/x86/net/bpf_jit_comp32.c | 14 ++++++++++++++ include/linux/bpf.h | 5 +++++ include/linux/filter.h | 1 + kernel/bpf/core.c | 11 +++++++++++ kernel/bpf/helpers.c | 13 +++++++++++++ kernel/bpf/verifier.c | 30 +++++++++++++++++++++++++++++- 7 files changed, 101 insertions(+), 1 deletion(-)
arch/x86/net/bpf_jit_comp.c +28 -0
@@ -2126,6 +2126,26 @@ st: if (is_imm8(insn->off))case BPF_JMP |BPF_CALL : {u8 *ip = image + addrs[i -1 ]; +if (insn->src_reg ==BPF_PSEUDO_KFUNC_CALL && + imm32 ==BPF_CALL_IMM (bpf_get_cpu_cycles)) { +/* Save RDX because RDTSC will use EDX:EAX to return u64 */ +emit_mov_reg (&prog, true,AUX_REG ,BPF_REG_3 ); +if (boot_cpu_has (X86_FEATURE_LFENCE_RDTSC )) +EMIT_LFENCE (); +EMIT2 (0x0F ,0x31 ); + +/* shl RDX, 32 */ +maybe_emit_1mod (&prog,BPF_REG_3 , true); +EMIT3 (0xC1 ,add_1reg (0xE0 ,BPF_REG_3 ),32 ); +/* or RAX, RDX */ +maybe_emit_mod (&prog,BPF_REG_0 ,BPF_REG_3 , true); +EMIT2 (0x09 ,add_2reg (0xC0 ,BPF_REG_0 ,BPF_REG_3 )); +/* restore RDX from R11 */ +emit_mov_reg (&prog, true,BPF_REG_3 ,AUX_REG ); + +break ; + } + func = (u8 *) __bpf_call_base + imm32;if (tail_call_reachable) {LOAD_TAIL_CALL_CNT_PTR (bpf_prog->aux->stack_depth);
@@ -3652,3 +3672,11 @@ u64 bpf_arch_uaddress_limit(void) {return 0 ; } + +/* x86-64 JIT can inline kfunc */ +bool bpf_jit_inlines_kfunc_call (s32 imm) +{ +if (imm ==BPF_CALL_IMM (bpf_get_cpu_cycles)) +return true; +return false; +}
arch/x86/net/bpf_jit_comp32.c +14 -0
@@ -2094,6 +2094,13 @@ static int do_jit(struct bpf_prog *bpf_prog, int *addrs, u8 *image,if (insn->src_reg ==BPF_PSEUDO_KFUNC_CALL ) {int err; +if (imm32 ==BPF_CALL_IMM (bpf_get_cpu_cycles)) { +if (boot_cpu_has (X86_FEATURE_LFENCE_RDTSC )) +EMIT3 (0x0F ,0xAE ,0xE8 ); +EMIT2 (0x0F ,0x31 ); +break ; + } + err =emit_kfunc_call (bpf_prog, image + addrs[i], insn, &prog);
@@ -2621,3 +2628,10 @@ bool bpf_jit_supports_kfunc_call(void) {return true; } + +bool bpf_jit_inlines_kfunc_call (s32 imm) +{ +if (imm ==BPF_CALL_IMM (bpf_get_cpu_cycles)) +return true; +return false; +}
include/linux/bpf.h +5 -0
@@ -3328,6 +3328,11 @@ void bpf_user_rnd_init_once(void);u64 bpf_user_rnd_u32 (u64 r1,u64 r2,u64 r3,u64 r4,u64 r5);u64 bpf_get_raw_cpu_id (u64 r1,u64 r2,u64 r3,u64 r4,u64 r5); +/* Inlined kfuncs */ +#if IS_ENABLED (CONFIG_GENERIC_GETTIMEOFDAY ) +u64 bpf_get_cpu_cycles (void ); +#endif +#if defined(CONFIG_NET ) bool bpf_sock_common_is_valid_access(int off, int size, enum bpf_access_type type,
include/linux/filter.h +1 -0
@@ -1111,6 +1111,7 @@ struct bpf_prog *bpf_int_jit_compile(struct bpf_prog *prog);void bpf_jit_compile (struct bpf_prog *prog);bool bpf_jit_needs_zext (void );bool bpf_jit_inlines_helper_call (s32 imm); +bool bpf_jit_inlines_kfunc_call (s32 imm);bool bpf_jit_supports_subprog_tailcalls (void );bool bpf_jit_supports_percpu_insn (void );bool bpf_jit_supports_kfunc_call (void );
kernel/bpf/core.c +11 -0
@@ -2965,6 +2965,17 @@ bool __weak bpf_jit_inlines_helper_call(s32 imm)return false; } +/* Return true if the JIT inlines the call to the kfunc corresponding to +* the imm. +* +* The verifier will not patch the insn->imm for the call to the helper if +* this returns true. +*/ +bool __weak bpf_jit_inlines_kfunc_call (s32 imm) +{ +return false; +} +/* Return TRUE if the JIT backend supports mixing bpf2bpf and tailcalls. */ bool __weak bpf_jit_supports_subprog_tailcalls (void ) {
kernel/bpf/helpers.c +13 -0
@@ -23,6 +23,9 @@#include <linux/btf_ids.h> #include <linux/bpf_mem_alloc.h> #include <linux/kasan.h> +#if IS_ENABLED (CONFIG_GENERIC_GETTIMEOFDAY ) +#include <vdso/datapage.h> +#endif #include "../../lib/kstrtox.h"
@@ -3023,6 +3026,13 @@ __bpf_kfunc int bpf_copy_from_user_str(void *dst, u32 dst__sz, const void __userreturn ret +1 ; } +#ifdef IS_ENABLED (CONFIG_GENERIC_GETTIMEOFDAY ) +__bpf_kfunc u64 bpf_get_cpu_cycles(void) +{ +return __arch_get_hw_counter (1 ,NULL ); +} +#endif +__bpf_kfunc_end_defs ();BTF_KFUNCS_START (generic_btf_ids)
@@ -3115,6 +3125,9 @@ BTF_ID_FLAGS(func, bpf_get_kmem_cache) BTF_ID_FLAGS(func, bpf_iter_kmem_cache_new, KF_ITER_NEW | KF_SLEEPABLE) BTF_ID_FLAGS(func, bpf_iter_kmem_cache_next, KF_ITER_NEXT | KF_RET_NULL | KF_SLEEPABLE) BTF_ID_FLAGS(func, bpf_iter_kmem_cache_destroy, KF_ITER_DESTROY | KF_SLEEPABLE) +#ifdef IS_ENABLED (CONFIG_GENERIC_GETTIMEOFDAY ) +BTF_ID_FLAGS(func, bpf_get_cpu_cycles, KF_FASTCALL) +#endif BTF_KFUNCS_END (common_btf_ids) static const struct btf_kfunc_id_set common_kfunc_set = {
kernel/bpf/verifier.c +29 -1
@@ -16273,6 +16273,24 @@ static bool verifier_inlines_helper_call(struct bpf_verifier_env *env, s32 imm) } } +/* True if fixup_kfunc_call() replaces calls to kfunc number 'imm', +* replacement patch is presumed to follow bpf_fastcall contract +* (see mark_fastcall_pattern_for_call() below). +*/ +static bool verifier_inlines_kfunc_call (struct bpf_verifier_env *env,s32 imm) +{ +const struct bpf_kfunc_desc *desc =find_kfunc_desc (env->prog, imm,0 ); + +if (!env->prog->jit_requested) +return false; + +if (desc->func_id == special_kfunc_list[KF_bpf_cast_to_kern_ctx] || + desc->func_id == special_kfunc_list[KF_bpf_rdonly_cast]) +return true; + +return false; +} +/* Same as helper_fastcall_clobber_mask() but for kfuncs, see comment above */ static u32 kfunc_fastcall_clobber_mask (struct bpf_kfunc_call_arg_meta *meta) {
@@ -16400,7 +16418,10 @@ static void mark_fastcall_pattern_for_call(struct bpf_verifier_env *env,return ; clobbered_regs_mask =kfunc_fastcall_clobber_mask (&meta); - can_be_inlined =is_fastcall_kfunc_call (&meta); + can_be_inlined =is_fastcall_kfunc_call (&meta) && + (verifier_inlines_kfunc_call (env, call->imm) || + (meta.btf == btf_vmlinux && +bpf_jit_inlines_kfunc_call (call->imm))); }if (clobbered_regs_mask ==ALL_CALLER_SAVED_REGS )
@@ -20402,6 +20423,7 @@ static int fixup_kfunc_call(struct bpf_verifier_env *env, struct bpf_insn *insn, struct bpf_insn *insn_buf, int insn_idx, int *cnt) { const struct bpf_kfunc_desc *desc; +s32 imm = insn->imm;if (!insn->imm) {verbose (env,"invalid kernel function call not eliminated in verifier pass\n" );
@@ -20488,6 +20510,12 @@ static int fixup_kfunc_call(struct bpf_verifier_env *env, struct bpf_insn *insn, node_offset_reg, insn, insn_buf, cnt); }else if (desc->func_id == special_kfunc_list[KF_bpf_cast_to_kern_ctx] || desc->func_id == special_kfunc_list[KF_bpf_rdonly_cast]) { +if (!verifier_inlines_kfunc_call (env, imm)) { +verbose (env,"verifier internal error: kfunc id %d is not defined in checker\n" , + desc->func_id); +return -EFAULT ; + } + insn_buf[0 ] =BPF_MOV64_REG (BPF_REG_0 ,BPF_REG_1 ); *cnt =1 ; }else if (is_bpf_wq_set_callback_impl_kfunc (desc->func_id)) {
Signature · 1 line
2.43.5
PATCH v4 2/4 bpf: add bpf_cpu_cycles_to_ns helper
The new helper should be used to convert cycles received by bpf_get_cpu_cycle() into nanoseconds.
v4:
* change helper name to bpf_cpu_cycles_to_ns.
* hide it behind CONFIG_GENERIC_GETTIMEOFDAY to avoid exposing on unsupported architectures.
--- arch/x86/net/bpf_jit_comp.c | 22 ++++++++++++++++++++++ arch/x86/net/bpf_jit_comp32.c | 19 +++++++++++++++++++ include/linux/bpf.h | 1 + kernel/bpf/helpers.c | 10 +++++++++- 4 files changed, 51 insertions(+), 1 deletion(-)
arch/x86/net/bpf_jit_comp.c +22 -0
@@ -11,6 +11,7 @@#include <linux/bpf.h> #include <linux/memory.h> #include <linux/sort.h> +#include <linux/clocksource.h> #include <asm/extable.h> #include <asm/ftrace.h> #include <asm/set_memory.h>
@@ -2146,6 +2147,24 @@ st: if (is_imm8(insn->off))break ; } +if (insn->src_reg ==BPF_PSEUDO_KFUNC_CALL && + imm32 ==BPF_CALL_IMM (bpf_cpu_cycles_to_ns) && +boot_cpu_has (X86_FEATURE_CONSTANT_TSC )) { +u32 mult, shift; + +clocks_calc_mult_shift (&mult, &shift, tsc_khz,USEC_PER_SEC ,0 ); +/* imul RAX, RDI, mult */ +maybe_emit_mod (&prog,BPF_REG_1 ,BPF_REG_0 , true); +EMIT2_off32 (0x69 ,add_2reg (0xC0 ,BPF_REG_1 ,BPF_REG_0 ), + mult); + +/* shr RAX, shift (which is less than 64) */ +maybe_emit_1mod (&prog,BPF_REG_0 , true); +EMIT3 (0xC1 ,add_1reg (0xE8 ,BPF_REG_0 ), shift); + +break ; + } + func = (u8 *) __bpf_call_base + imm32;if (tail_call_reachable) {LOAD_TAIL_CALL_CNT_PTR (bpf_prog->aux->stack_depth);
@@ -3678,5 +3697,8 @@ bool bpf_jit_inlines_kfunc_call(s32 imm) {if (imm ==BPF_CALL_IMM (bpf_get_cpu_cycles))return true; +if (imm ==BPF_CALL_IMM (bpf_cpu_cycles_to_ns) && +boot_cpu_has (X86_FEATURE_CONSTANT_TSC )) +return true;return false; }
arch/x86/net/bpf_jit_comp32.c +19 -0
@@ -12,6 +12,7 @@#include <linux/netdevice.h> #include <linux/filter.h> #include <linux/if_vlan.h> +#include <linux/clocksource.h> #include <asm/cacheflush.h> #include <asm/set_memory.h> #include <asm/nospec-branch.h>
@@ -2100,6 +2101,24 @@ static int do_jit(struct bpf_prog *bpf_prog, int *addrs, u8 *image,EMIT2 (0x0F ,0x31 );break ; } +if (imm32 ==BPF_CALL_IMM (bpf_cpu_cycles_to_ns) && +boot_cpu_has (X86_FEATURE_CONSTANT_TSC )) { +u32 mult, shift; + +clocks_calc_mult_shift (&mult, &shift, tsc_khz, +USEC_PER_SEC ,0 ); + +/* move parameter to BPF_REG_0 */ +emit_ia32_mov_r64 (true, bpf2ia32[BPF_REG_0 ], + bpf2ia32[BPF_REG_1 ], true, true, + &prog, bpf_prog->aux); +/* multiply parameter by mut */ +emit_ia32_mul_i64 (bpf2ia32[BPF_REG_0 ], + mult, true, &prog); +/* shift parameter by shift which is less than 64 */ +emit_ia32_rsh_i64 (bpf2ia32[BPF_REG_0 ], + shift, true, &prog); + } err = emit_kfunc_call(bpf_prog, image + addrs[i],
include/linux/bpf.h +1 -0
@@ -3331,6 +3331,7 @@ u64 bpf_get_raw_cpu_id(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5);/* Inlined kfuncs */ #if IS_ENABLED (CONFIG_GENERIC_GETTIMEOFDAY )u64 bpf_get_cpu_cycles (void ); +u64 bpf_cpu_cycles_to_ns (u64 cycles);#endif #if defined(CONFIG_NET )
kernel/bpf/helpers.c +9 -1
@@ -25,6 +25,7 @@#include <linux/kasan.h> #if IS_ENABLED (CONFIG_GENERIC_GETTIMEOFDAY )#include <vdso/datapage.h> +#include <asm/vdso/vsyscall.h> #endif #include "../../lib/kstrtox.h"
@@ -3031,8 +3032,14 @@ __bpf_kfunc u64 bpf_get_cpu_cycles(void) {return __arch_get_hw_counter (1 ,NULL ); } -#endif +__bpf_kfunc u64 bpf_cpu_cycles_to_ns(u64 cycles) +{ +const struct vdso_data *vd =__arch_get_k_vdso_data (); + +return mul_u64_u32_shr (cycles, vd->mult, vd->shift); +} +#endif __bpf_kfunc_end_defs ();BTF_KFUNCS_START (generic_btf_ids)
@@ -3127,6 +3134,7 @@ BTF_ID_FLAGS(func, bpf_iter_kmem_cache_next, KF_ITER_NEXT | KF_RET_NULL | KF_SLE BTF_ID_FLAGS(func, bpf_iter_kmem_cache_destroy, KF_ITER_DESTROY | KF_SLEEPABLE)#ifdef IS_ENABLED (CONFIG_GENERIC_GETTIMEOFDAY ) BTF_ID_FLAGS(func, bpf_get_cpu_cycles, KF_FASTCALL) +BTF_ID_FLAGS(func, bpf_cpu_cycles_to_ns, KF_FASTCALL)#endif BTF_KFUNCS_END (common_btf_ids)
Signature · 1 line
2.43.5
kernel test robot
build botRe: [PATCH bpf-next v4 2/4] bpf: add bpf_cpu_cycles_to_ns helper
kernel test robot noticed the following build errors:
Hi Vadim,
kernel test robot noticed the following build errors:
[auto build test ERROR on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Vadim-Fedorenko/bpf-add-bpf_cpu_cycles_to_ns-helper/20241108-051950 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master patch link: https://lore.kernel.org/r/20241107211206.2814069-2-vadfed%40meta.com patch subject: [PATCH bpf-next v4 2/4] bpf: add bpf_cpu_cycles_to_ns helper config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20241108/[email protected]/config) compiler: sh4-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241108/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
kernel/bpf/helpers.c:3030:18: warning: extra tokens at end of #ifdef directive
3030 | #ifdef IS_ENABLED(CONFIG_GENERIC_GETTIMEOFDAY)
| ^
kernel/bpf/helpers.c: In function 'bpf_get_cpu_cycles':
kernel/bpf/helpers.c:3033:16: error: implicit declaration of function '__arch_get_hw_counter' [-Wimplicit-function-declaration]
3033 | return __arch_get_hw_counter(1, NULL);
| ^~~~~~~~~~~~~~~~~~~~~
kernel/bpf/helpers.c: In function 'bpf_cpu_cycles_to_ns':
kernel/bpf/helpers.c:3038:38: error: implicit declaration of function '__arch_get_k_vdso_data' [-Wimplicit-function-declaration]
3038 | const struct vdso_data *vd = __arch_get_k_vdso_data();
| ^~~~~~~~~~~~~~~~~~~~~~
>> kernel/bpf/helpers.c:3038:38: error: initialization of 'const struct vdso_data *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
kernel/bpf/helpers.c:3040:42: error: invalid use of undefined type 'const struct vdso_data'
3040 | return mul_u64_u32_shr(cycles, vd->mult, vd->shift);
| ^~
kernel/bpf/helpers.c:3040:52: error: invalid use of undefined type 'const struct vdso_data'
3040 | return mul_u64_u32_shr(cycles, vd->mult, vd->shift);
| ^~
kernel/bpf/helpers.c: At top level:
kernel/bpf/helpers.c:3135:18: warning: extra tokens at end of #ifdef directive
3135 | #ifdef IS_ENABLED(CONFIG_GENERIC_GETTIMEOFDAY)
| ^
kernel/bpf/helpers.c: In function 'bpf_cpu_cycles_to_ns':
kernel/bpf/helpers.c:3041:1: warning: control reaches end of non-void function [-Wreturn-type]
3041 | }
| ^vim +3038 kernel/bpf/helpers.c
3035
3036 __bpf_kfunc u64 bpf_cpu_cycles_to_ns(u64 cycles)
3037 {
> 3038 const struct vdso_data *vd = __arch_get_k_vdso_data();
3039
3040 return mul_u64_u32_shr(cycles, vd->mult, vd->shift);
3041 }
3042 #endif
3043 __bpf_kfunc_end_defs();
3044
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
PATCH v4 3/4 selftests/bpf: add selftest to check rdtsc jit
In reply to Vadim Fedorenkoget_cpu_cycles() is replaced with rdtsc instruction on x86_64. Add tests to check it.
--- .../selftests/bpf/prog_tests/verifier.c | 2 + .../selftests/bpf/progs/verifier_cpu_cycles.c | 104 ++++++++++++++++++ 2 files changed, 106 insertions(+) create mode 100644 tools/testing/selftests/bpf/progs/verifier_cpu_cycles.c
tools/testing/selftests/bpf/prog_tests/verifier.c +2 -0
@@ -97,6 +97,7 @@#include "verifier_xdp_direct_packet_access.skel.h" #include "verifier_bits_iter.skel.h" #include "verifier_lsm.skel.h" +#include "verifier_cpu_cycles.skel.h" #define MAX_ENTRIES 11
@@ -223,6 +224,7 @@ void test_verifier_xdp(void) { RUN(verifier_xdp); }void test_verifier_xdp_direct_packet_access (void ) {RUN (verifier_xdp_direct_packet_access); }void test_verifier_bits_iter (void ) {RUN (verifier_bits_iter); }void test_verifier_lsm (void ) {RUN (verifier_lsm); } +void test_verifier_cpu_cycles (void ) {RUN (verifier_cpu_cycles); }void test_verifier_mtu (void ) {
tools/testing/selftests/bpf/progs/verifier_cpu_cycles.c new file +104 -0
104 lines not on this page · raw message
Signature · 1 line
2.43.5
PATCH v4 4/4 selftests/bpf: add usage example for cpu cycles kfuncs
In reply to Vadim FedorenkoThe selftest provides an example of how to measure the latency of bpf kfunc/helper call in cycles and nanoseconds.
--- .../bpf/prog_tests/test_cpu_cycles.c | 35 +++++++++++++++++++ .../selftests/bpf/progs/test_cpu_cycles.c | 25 +++++++++++++ 2 files changed, 60 insertions(+) create mode 100644 tools/testing/selftests/bpf/prog_tests/test_cpu_cycles.c create mode 100644 tools/testing/selftests/bpf/progs/test_cpu_cycles.c
tools/testing/selftests/bpf/prog_tests/test_cpu_cycles.c new file +35 -0
@@ -0,0 +1,35 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2024 Meta Inc. */ + +#include <test_progs.h> +#include "test_cpu_cycles.skel.h" + +static void cpu_cycles (void ) +{ +LIBBPF_OPTS (bpf_test_run_opts, opts); +struct test_cpu_cycles *skel; +int err, pfd; + + skel =test_cpu_cycles__open_and_load (); +if (!ASSERT_OK_PTR (skel,"test_cpu_cycles open and load" )) +return ; + + pfd =bpf_program__fd (skel->progs.bpf_cpu_cycles); +if (!ASSERT_GT (pfd,0 ,"test_cpu_cycles fd" )) + goto fail; + + err =bpf_prog_test_run_opts (pfd, &opts); +if (!ASSERT_OK (err,"test_cpu_cycles test run" )) + goto fail; + +ASSERT_NEQ (skel->bss->cycles,0 ,"test_cpu_cycles 0 cycles" ); +ASSERT_NEQ (skel->bss->ns,0 ,"test_cpu_cycles 0 ns" ); +fail: +test_cpu_cycles__destroy (skel); +} + +void test_cpu_cycles (void ) +{ +if (test__start_subtest ("cpu_cycles" )) +cpu_cycles (); +}
tools/testing/selftests/bpf/progs/test_cpu_cycles.c new file +25 -0
@@ -0,0 +1,25 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2024 Meta Inc. */ + +#include "vmlinux.h" +#include <bpf/bpf_helpers.h> + +extern u64 bpf_cpu_cycles_to_ns(u64 cycles) __weak __ksym; +extern u64 bpf_get_cpu_cycles(void) __weak __ksym; + +__u64 cycles, ns; + +SEC("syscall") +int bpf_cpu_cycles (void ) +{ +struct bpf_pidns_info pidns; +__u64 start; + + start =bpf_get_cpu_cycles (); +bpf_get_ns_current_pid_tgid (0 ,0 , &pidns,sizeof (struct bpf_pidns_info )); + cycles =bpf_get_cpu_cycles () - start; + ns =bpf_cpu_cycles_to_ns (cycles); +return 0 ; +} + +char _license[] SEC("license") = "GPL";
Signature · 1 line
2.43.5
kernel test robot
build botkernel test robot noticed the following build errors:
Hi Vadim,
kernel test robot noticed the following build errors:
[auto build test ERROR on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Vadim-Fedorenko/bpf-add-bpf_cpu_cycles_to_ns-helper/20241108-051950 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master patch link: https://lore.kernel.org/r/20241107211206.2814069-1-vadfed%40meta.com patch subject: [PATCH bpf-next v4 1/4] bpf: add bpf_get_cpu_cycles kfunc config: arm-randconfig-003-20241108 (https://download.01.org/0day-ci/archive/20241108/[email protected]/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241108/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
kernel/bpf/helpers.c:3029:18: warning: extra tokens at end of #ifdef directive [-Wextra-tokens]
#ifdef IS_ENABLED(CONFIG_GENERIC_GETTIMEOFDAY)
^
//
>> kernel/bpf/helpers.c:3032:9: error: call to undeclared function '__arch_get_hw_counter'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
return __arch_get_hw_counter(1, NULL);
^
kernel/bpf/helpers.c:3128:18: warning: extra tokens at end of #ifdef directive [-Wextra-tokens]
#ifdef IS_ENABLED(CONFIG_GENERIC_GETTIMEOFDAY)
^
//2 warnings and 1 error generated.
vim +/__arch_get_hw_counter +3032 kernel/bpf/helpers.c
3028
3029 #ifdef IS_ENABLED(CONFIG_GENERIC_GETTIMEOFDAY)
3030 __bpf_kfunc u64 bpf_get_cpu_cycles(void)
3031 {
> 3032 return __arch_get_hw_counter(1, NULL);
3033 }
3034 #endif
3035
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
kernel test robot
build botkernel test robot noticed the following build errors:
Hi Vadim,
kernel test robot noticed the following build errors:
[auto build test ERROR on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Vadim-Fedorenko/bpf-add-bpf_cpu_cycles_to_ns-helper/20241108-051950 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master patch link: https://lore.kernel.org/r/20241107211206.2814069-1-vadfed%40meta.com patch subject: [PATCH bpf-next v4 1/4] bpf: add bpf_get_cpu_cycles kfunc config: arm-randconfig-004-20241108 (https://download.01.org/0day-ci/archive/20241108/[email protected]/config) compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241108/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
In file included from kernel/bpf/helpers.c:4:
In file included from include/linux/bpf.h:21:
In file included from include/linux/kallsyms.h:13:
In file included from include/linux/mm.h:2213:
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
kernel/bpf/helpers.c:117:36: warning: bitwise operation between different enumeration types ('enum bpf_arg_type' and 'enum bpf_type_flag') [-Wenum-enum-conversion]
117 | .arg2_type = ARG_PTR_TO_MAP_VALUE | MEM_UNINIT | MEM_WRITE,
| ~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
kernel/bpf/helpers.c:130:36: warning: bitwise operation between different enumeration types ('enum bpf_arg_type' and 'enum bpf_type_flag') [-Wenum-enum-conversion]
130 | .arg2_type = ARG_PTR_TO_MAP_VALUE | MEM_UNINIT | MEM_WRITE,
| ~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
kernel/bpf/helpers.c:541:30: warning: bitwise operation between different enumeration types ('enum bpf_arg_type' and 'enum bpf_type_flag') [-Wenum-enum-conversion]
541 | .arg1_type = ARG_PTR_TO_MEM | MEM_RDONLY,
| ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
kernel/bpf/helpers.c:544:41: warning: bitwise operation between different enumeration types ('enum bpf_arg_type' and 'enum bpf_type_flag') [-Wenum-enum-conversion]
544 | .arg4_type = ARG_PTR_TO_FIXED_SIZE_MEM | MEM_UNINIT | MEM_WRITE | MEM_ALIGNED,
| ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
kernel/bpf/helpers.c:569:30: warning: bitwise operation between different enumeration types ('enum bpf_arg_type' and 'enum bpf_type_flag') [-Wenum-enum-conversion]
569 | .arg1_type = ARG_PTR_TO_MEM | MEM_RDONLY,
| ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
kernel/bpf/helpers.c:572:41: warning: bitwise operation between different enumeration types ('enum bpf_arg_type' and 'enum bpf_type_flag') [-Wenum-enum-conversion]
572 | .arg4_type = ARG_PTR_TO_FIXED_SIZE_MEM | MEM_UNINIT | MEM_WRITE | MEM_ALIGNED,
| ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
kernel/bpf/helpers.c:585:30: warning: bitwise operation between different enumeration types ('enum bpf_arg_type' and 'enum bpf_type_flag') [-Wenum-enum-conversion]
585 | .arg1_type = ARG_PTR_TO_MEM | MEM_RDONLY,
| ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
kernel/bpf/helpers.c:655:35: warning: bitwise operation between different enumeration types ('enum bpf_arg_type' and 'enum bpf_type_flag') [-Wenum-enum-conversion]
655 | .arg4_type = ARG_PTR_TO_MEM | MEM_RDONLY,
| ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
kernel/bpf/helpers.c:727:39: warning: bitwise operation between different enumeration types ('enum bpf_return_type' and 'enum bpf_type_flag') [-Wenum-enum-conversion]
727 | .ret_type = RET_PTR_TO_MEM_OR_BTF_ID | PTR_MAYBE_NULL | MEM_RDONLY,
| ~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
kernel/bpf/helpers.c:740:39: warning: bitwise operation between different enumeration types ('enum bpf_return_type' and 'enum bpf_type_flag') [-Wenum-enum-conversion]
740 | .ret_type = RET_PTR_TO_MEM_OR_BTF_ID | MEM_RDONLY,
| ~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
kernel/bpf/helpers.c:1082:30: warning: bitwise operation between different enumeration types ('enum bpf_arg_type' and 'enum bpf_type_flag') [-Wenum-enum-conversion]
1082 | .arg4_type = ARG_PTR_TO_MEM | PTR_MAYBE_NULL | MEM_RDONLY,
| ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
kernel/bpf/helpers.c:1643:44: warning: bitwise operation between different enumeration types ('enum bpf_arg_type' and 'enum bpf_type_flag') [-Wenum-enum-conversion]
1643 | .arg2_type = ARG_PTR_TO_BTF_ID_OR_NULL | OBJ_RELEASE,
| ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~
kernel/bpf/helpers.c:1748:33: warning: bitwise operation between different enumeration types ('enum bpf_arg_type' and 'enum bpf_type_flag') [-Wenum-enum-conversion]
1748 | .arg4_type = ARG_PTR_TO_DYNPTR | DYNPTR_TYPE_LOCAL | MEM_UNINIT | MEM_WRITE,
| ~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~
kernel/bpf/helpers.c:1791:33: warning: bitwise operation between different enumeration types ('enum bpf_arg_type' and 'enum bpf_type_flag') [-Wenum-enum-conversion]
1791 | .arg3_type = ARG_PTR_TO_DYNPTR | MEM_RDONLY,
| ~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
kernel/bpf/helpers.c:1839:33: warning: bitwise operation between different enumeration types ('enum bpf_arg_type' and 'enum bpf_type_flag') [-Wenum-enum-conversion]
1839 | .arg1_type = ARG_PTR_TO_DYNPTR | MEM_RDONLY,
| ~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
kernel/bpf/helpers.c:1841:30: warning: bitwise operation between different enumeration types ('enum bpf_arg_type' and 'enum bpf_type_flag') [-Wenum-enum-conversion]
1841 | .arg3_type = ARG_PTR_TO_MEM | MEM_RDONLY,
| ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
kernel/bpf/helpers.c:1881:33: warning: bitwise operation between different enumeration types ('enum bpf_arg_type' and 'enum bpf_type_flag') [-Wenum-enum-conversion]
1881 | .arg1_type = ARG_PTR_TO_DYNPTR | MEM_RDONLY,
| ~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
kernel/bpf/helpers.c:3029:18: warning: extra tokens at end of #ifdef directive [-Wextra-tokens]
3029 | #ifdef IS_ENABLED(CONFIG_GENERIC_GETTIMEOFDAY)
| ^
| //
>> kernel/bpf/helpers.c:3032:9: error: call to undeclared function '__arch_get_hw_counter'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
3032 | return __arch_get_hw_counter(1, NULL);
| ^
kernel/bpf/helpers.c:3128:18: warning: extra tokens at end of #ifdef directive [-Wextra-tokens]
3128 | #ifdef IS_ENABLED(CONFIG_GENERIC_GETTIMEOFDAY)
| ^
| //20 warnings and 1 error generated.
vim +/__arch_get_hw_counter +3032 kernel/bpf/helpers.c
3028
3029 #ifdef IS_ENABLED(CONFIG_GENERIC_GETTIMEOFDAY)
3030 __bpf_kfunc u64 bpf_get_cpu_cycles(void)
3031 {
> 3032 return __arch_get_hw_counter(1, NULL);
3033 }
3034 #endif
3035
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki