Skip to contentSkip to conversation

linux-next: build failure after merge of the ftrace tree

DISCUSSION Stephen Rothwell 4 participants 10 messages Nov 8, 2024 – Nov 9, 2024

Subsystems (2)
Linux-next tree Rust
lore
Share & tools
lore

Stephen Rothwell

author
#0 lore raw

Hi all,

After merging the ftrace tree, today's linux-next build (x86_64 allmodconfig) failed like this:

ERROR: modpost: missing MODULE_LICENSE() in samples/rust/rust_print_events.o
ERROR: modpost: "__tracepoint_rust_sample_loaded" [samples/rust/rust_print.ko] undefined!
ERROR: modpost: "rust_do_trace_rust_sample_loaded" [samples/rust/rust_print.ko] undefined!

Caused by commit

91d39024e1b0 ("rust: samples: add tracepoint to Rust sample")

I have used the ftrace tree from next-20241107 for today.

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 5 lines · On Fri, 8 Nov 2024 15:21:49 +1100 Stephen Rothwell <[email protected]> wrote:

Hi all,

After merging the ftrace tree, today's linux-next build (x86_64 allmodconfig) failed like this:

Quoted 7 lines

ERROR: modpost: missing MODULE_LICENSE() in samples/rust/rust_print_events.o
ERROR: modpost: "__tracepoint_rust_sample_loaded" [samples/rust/rust_print.ko] undefined!
ERROR: modpost: "rust_do_trace_rust_sample_loaded" [samples/rust/rust_print.ko] undefined!

Caused by commit

91d39024e1b0 ("rust: samples: add tracepoint to Rust sample")

Alice,

Can you send a patch to fix this?

Quoted 3 lines

I have used the ftrace tree from next-20241107 for today.

I'll remove my rust topic branch until we have a fix.

Thanks,

-- Steve

reviewer
#2 lore raw
Quoted 13 lines · Steven Rostedt
Quoted 9 lines · On Fri, 8 Nov 2024 15:21:49 +1100 Stephen Rothwell <[email protected]> wrote:

Hi all,

After merging the ftrace tree, today's linux-next build (x86_64 allmodconfig) failed like this:

ERROR: modpost: missing MODULE_LICENSE() in samples/rust/rust_print_events.o
ERROR: modpost: "__tracepoint_rust_sample_loaded" [samples/rust/rust_print.ko] undefined!
ERROR: modpost: "rust_do_trace_rust_sample_loaded" [samples/rust/rust_print.ko] undefined!

Quoted 7 lines
Quoted 3 lines

Caused by commit

91d39024e1b0 ("rust: samples: add tracepoint to Rust sample")

Alice,

Can you send a patch to fix this?

I'm working on it as we speak, but I haven't figured out how to reproduce the problem yet. Using allmodconfig builds fine for me. Any ideas?

Stephen, is there any more information you can share about this? What versions of rustc, bindgen, and clang are you using?

Alice

#3 lore raw
Quoted 2 lines · On Fri, 8 Nov 2024 16:09:33 +0100 Alice Ryhl <[email protected]> wrote:

Stephen, is there any more information you can share about this? What versions of rustc, bindgen, and clang are you using?

I can reproduce it with the attached config.

-- Steve

#4 lore raw
Quoted 2 lines · Steven Rostedt

I can reproduce it with the attached config.

Something like this should work I think:

samples/rust/Makefile +0 -1
index f29280ec4820..37c15f05cb81 100644
@@ -2,6 +2,8 @@
 ccflags-y += -I$(src)                          # needed for trace events
 
 obj-$(CONFIG_SAMPLE_RUST_MINIMAL)              += rust_minimal.o
-obj-$(CONFIG_SAMPLE_RUST_PRINT)                        +=

rust_print.o rust_print_events.o
+
+obj-$(CONFIG_SAMPLE_RUST_PRINT) += rust_print_combined.o +rust_print_combined-y := rust_print.o rust_print_events.o

subdir-$(CONFIG_SAMPLE_RUST_HOSTPROGS) += hostprogs

Cheers,
Miguel

#7 lore raw
Quoted 2 lines · Steven Rostedt

Are you going to take this or do you want me to?

This requires the patch that it fixes, which you are carrying, so I can't take it, no? Or am I confused?

Quoted 1 line

If you want me to take it, can you send it to [email protected]?

Sure (assuming the above is correct).

Thanks!

Cheers,
Miguel

#8 lore raw
Quoted 7 lines · Miguel Ojeda
Quoted 2 lines · Steven Rostedt

Are you going to take this or do you want me to?

This requires the patch that it fixes, which you are carrying, so I can't take it, no? Or am I confused?

No, I'm currently traveling and thought your change just touched what's upstream. I'll take it.

-- Steve

Quoted 8 lines
Quoted 1 line

If you want me to take it, can you send it to [email protected]?

Sure (assuming the above is correct).

Thanks!

Cheers,
Miguel