clk: amlogic: axg-audio: fix Kconfig dependency on RESET_MESON_AUX
PATCH 1/1 clk: amlogic: axg-audio: fix Kconfig dependency on RESET_MESON_AUX
From: Arnd Bergmann <[email protected]>
As in most cases, using 'imply' is wrong here and does not prevent build failures since that code may not be visible to a built-in clk driver:
axg-audio.c:(.text+0x15c): undefined reference to `devm_meson_rst_aux_register'
Replace the incorrt 'imply' with the necessary 'depends on'.
--- drivers/clk/meson/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/meson/Kconfig +1 -1
@@ -106,7 +106,7 @@ config COMMON_CLK_AXG_AUDIO select COMMON_CLK_MESON_SCLK_DIV select COMMON_CLK_MESON_CLKC_UTILS select REGMAP_MMIO - imply RESET_MESON_AUX + depends on RESET_MESON_AUX help Support for the audio clock controller on AmLogic A113D devices, aka axg, Say Y if you want audio subsystem to work.
Signature · 1 line
2.39.5
Quoted 7 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
As in most cases, using 'imply' is wrong here and does not prevent build failures since that code may not be visible to a built-in clk driver:
axg-audio.c:(.text+0x15c): undefined reference to `devm_meson_rst_aux_register'
The function registering the aux driver was in clock in some old version (imply was ok at that point) and I forgot to change that when it moved to reset.
Thanks for catching this
Stephen, This fixes the PR you applied. I guess how to pick this up depends on how you want to deal with the Fixes tag problem reported by Stephen Rothwell.
Quoted 22 lines
Replace the incorrt 'imply' with the necessary 'depends on'.
Fixes 664988eb47dd ("clk: amlogic: axg-audio: use the auxiliary reset driver")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/clk/meson/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clk/meson/Kconfig +1
-1@@ -106,7 +106,7 @@ config COMMON_CLK_AXG_AUDIO select COMMON_CLK_MESON_SCLK_DIV select COMMON_CLK_MESON_CLKC_UTILS select REGMAP_MMIO - imply RESET_MESON_AUX + depends on RESET_MESON_AUX help Support for the audio clock controller on AmLogic A113D devices, aka axg, Say Y if you want audio subsystem to work.
Signature · 1 line
Jerome
Quoting Arnd Bergmann (2024-11-11 02:29:21)
Quoted 6 lines
From: Arnd Bergmann <[email protected]>
As in most cases, using 'imply' is wrong here and does not prevent build failures since that code may not be visible to a built-in clk driver:
Quoted 7 lines
axg-audio.c:(.text+0x15c): undefined reference to `devm_meson_rst_aux_register'
Replace the incorrt 'imply' with the necessary 'depends on'.
Fixes 664988eb47dd ("clk: amlogic: axg-audio: use the auxiliary reset driver")Signed-off-by Arnd Bergmann <[email protected]>---
Applied to clk-next