dt-bindings: spi: add compatibles for mt7988

PATCH In review Frank Wunderlich 5 participants 5 messages Nov 9, 2024 – Mar 14, 2025

Subsystems (3)

Device tree bindings Arm MediaTek SPI

lore

Share & tools

lore

Frank Wunderlich

author

2024-11-09 10:50 UTC #0 lore raw

PATCH 1/1 dt-bindings: spi: add compatibles for mt7988

From: Frank Wunderlich <[email protected]>

MT7988 has 2 different spi controllers. Add their compatibles.

Signed-off-by Frank Wunderlich <[email protected]>

---
 Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 2 ++
 1 file changed, 2 insertions(+)

Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml +2 -0

index e1f5bfa4433c..ed17815263a8 100644
@@ -35,6 +35,8 @@ properties:
           - enum:
               - mediatek,mt7981-spi-ipm
               - mediatek,mt7986-spi-ipm
+              - mediatek,mt7988-spi-quad
+              - mediatek,mt7988-spi-single
               - mediatek,mt8188-spi-ipm
           - const: mediatek,spi-ipm
       - items:

Signature · 1 line

2.43.0

Conor Dooley

Acked-by on v1 1/1

2024-11-11 19:45 UTC #1 lore raw

Quoted 5 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>
MT7988 has 2 different spi controllers. Add their compatibles.
Signed-off-by Frank Wunderlich <[email protected]>

Acked-by Conor Dooley <[email protected]>

Rob Herring

maintainer

2024-11-11 20:38 UTC #2 lore raw

In reply to Frank Wunderlich

Quoted 14 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>
MT7988 has 2 different spi controllers. Add their compatibles.
Signed-off-by Frank Wunderlich <[email protected]>
---
 Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml +0 -0
index e1f5bfa4433c..ed17815263a8 100644

Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml properties: · line 41

Quoted 7 lines

Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml +2 -0

@@ -35,6 +35,8 @@ properties:
           - enum:
               - mediatek,mt7981-spi-ipm
               - mediatek,mt7986-spi-ipm
+              - mediatek,mt7988-spi-quad
+              - mediatek,mt7988-spi-single
               - mediatek,mt8188-spi-ipm
           - const: mediatek,spi-ipm

Does the fallback make sense for both? Is there some common subset of functionality where they are the same?

Rob

> Gesendet: Montag, 11. November 2024 um 21:38
> Von: "Rob Herring" <[email protected]>
> An: "Frank Wunderlich" <[email protected]>
> CC: "Mark Brown" <[email protected]>, "Krzysztof Kozlowski" <[email protected]>, "Conor Dooley" <[email protected]>, "Matthias Brugger" <[email protected]>, "AngeloGioacchino Del Regno" <[email protected]>, "Frank Wunderlich" <[email protected]>, "Leilk Liu" <[email protected]>, [email protected], [email protected], [email protected], [email protected], [email protected] > Betreff: Re: [PATCH] dt-bindings: spi: add compatibles for mt7988
>
> On Sat, Nov 09, 2024 at 11:50:28AM +0100, Frank Wunderlich wrote:
> > From: Frank Wunderlich <[email protected]>
> >
> > MT7988 has 2 different spi controllers. Add their compatibles.
> >
> > Signed-off-by: Frank Wunderlich <[email protected]>
> > ---
> > Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> > index e1f5bfa4433c..ed17815263a8 100644
> > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> > @@ -35,6 +35,8 @@ properties:
> > - enum:

&gt; &gt;                - mediatek,mt7981-spi-ipm
&gt; &gt;                - mediatek,mt7986-spi-ipm
&gt; &gt; +              - mediatek,mt7988-spi-quad
&gt; &gt; +              - mediatek,mt7988-spi-single
&gt; &gt;                - mediatek,mt8188-spi-ipm

> > - const: mediatek,spi-ipm
>
> Does the fallback make sense for both? Is there some common subset of > functionality where they are the same?

currently they work only with the fallback compatible, but we see in SDK that there are 2 types...in SDK non-soc specific compatibles are used which was rejected last time.

> Rob
> </[email protected]></[email protected]></[email protected]></[email protected]></[email protected]></[email protected]></[email protected]></[email protected]></[email protected]></[email protected]></[email protected]>

Mark Brown

maintainer

2025-03-14 15:53 UTC #4 lore raw

In reply to Frank Wunderlich

Quoted 3 lines · Frank Wunderlich

MT7988 has 2 different spi controllers. Add their compatibles.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] dt-bindings: spi: add compatibles for mt7988

      commit: 3b2e1b87ad0870ad37ee8f2ca0ea6ede19a29795

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark