Skip to contentSkip to conversation

listmount.2: fix verbiage about continuing the iteration

PATCH Applied Jeff Layton 2 participants 4 messages Nov 13, 2024 – Nov 17, 2024

Subsystems (3)
VFS Arm STM32 Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7
lore
Share & tools
lore

Jeff Layton

author
#0 lore raw

PATCH 1/1 listmount.2: fix verbiage about continuing the iteration

The "+1" is wrong, since the kernel already increments the last_id. Fix the manpage verbiage.

Cc Josef Bacik <[email protected]>
Cc Miklos Szeredi <[email protected]>
Signed-off-by Jeff Layton <[email protected]>
---
 man/man2/listmount.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man/man2/listmount.2 +1 -1
index 717581b85e12dc172b7c478b4608665e9da74933..00ac6a60c0cfead5c462fcac44e61647d841ffe5 100644
@@ -67,7 +67,7 @@ is used to tell the kernel what mount ID to start the list from.
 This is useful if multiple calls to
 .BR listmount (2)
 are required.
-This can be set to the last mount ID returned + 1 in order to
+This can be set to the last mount ID returned in order to
 resume from a previous spot in the list.
 .SH RETURN VALUE
 On success, the number of entries filled into

---
base-commit: df69651a5c1abb61bd0d7ba0791f65f427923f75
change-id: 20241113-main-192abec3348e

Best regards,

Signature · 1 line
Jeff Layton <[email protected]>
maintainer
#1 lore raw

Hi Jeff,

Quoted 2 lines · Jeff Layton

The "+1" is wrong, since the kernel already increments the last_id. Fix the manpage verbiage.

If it's not too difficult, could you show a small example program that shows this? Thanks!

Have a lovely day!
Alex

Quoted 31 lines
Cc Josef Bacik <[email protected]>
Cc Miklos Szeredi <[email protected]>
Signed-off-by Jeff Layton <[email protected]>
---
 man/man2/listmount.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man/man2/listmount.2 +1 -2
index 717581b85e12dc172b7c478b4608665e9da74933..00ac6a60c0cfead5c462fcac44e61647d841ffe5 100644
@@ -67,7 +67,7 @@ is used to tell the kernel what mount ID to start the list from.
 This is useful if multiple calls to
 .BR listmount (2)
 are required.
-This can be set to the last mount ID returned + 1 in order to
+This can be set to the last mount ID returned in order to
 resume from a previous spot in the list.
 .SH RETURN VALUE
 On success, the number of entries filled into
 
---

base-commit: df69651a5c1abb61bd0d7ba0791f65f427923f75
change-id: 20241113-main-192abec3348e

Best regards,

Signature · 1 line
Jeff Layton <[email protected]>
Signature · 1 line
<https://www.alejandro-colomar.es/>
author
#2 lore raw
Quoted 12 lines · Alejandro Colomar

Hi Jeff,

Quoted 2 lines · Jeff Layton

The "+1" is wrong, since the kernel already increments the last_id. Fix the manpage verbiage.

If it's not too difficult, could you show a small example program that shows this? Thanks!

Have a lovely day!
Alex

It's not too small, but I proposed this program as a sample for the kernel:

    https://lore.kernel.org/linux-fsdevel/[email protected]/

It has a bug though that Miklos pointed out, since I followed the manpage. I'll be fixing that soon.

Quoted 32 lines
Quoted 31 lines
Cc Josef Bacik <[email protected]>
Cc Miklos Szeredi <[email protected]>
Signed-off-by Jeff Layton <[email protected]>
---
 man/man2/listmount.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man/man2/listmount.2 +1 -2
index 717581b85e12dc172b7c478b4608665e9da74933..00ac6a60c0cfead5c462fcac44e61647d841ffe5 100644
@@ -67,7 +67,7 @@ is used to tell the kernel what mount ID to start the list from.
 This is useful if multiple calls to
 .BR listmount (2)
 are required.
-This can be set to the last mount ID returned + 1 in order to
+This can be set to the last mount ID returned in order to
 resume from a previous spot in the list.
 .SH RETURN VALUE
 On success, the number of entries filled into
 
---

base-commit: df69651a5c1abb61bd0d7ba0791f65f427923f75
change-id: 20241113-main-192abec3348e

Best regards,

Signature · 1 line
Jeff Layton <[email protected]>
Signature · 1 line
Jeff Layton <[email protected]>
maintainer Applied
#3 lore raw

Hi Jeff,

Quoted 14 lines · Jeff Layton
Quoted 12 lines · Alejandro Colomar

Hi Jeff,

Quoted 2 lines · Jeff Layton

The "+1" is wrong, since the kernel already increments the last_id. Fix the manpage verbiage.

If it's not too difficult, could you show a small example program that shows this? Thanks!

Have a lovely day!
Alex

Quoted 7 lines

It's not too small, but I proposed this program as a sample for the kernel:

    https://lore.kernel.org/linux-fsdevel/[email protected]/

It has a bug though that Miklos pointed out, since I followed the manpage. I'll be fixing that soon.

Thanks!

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Cc Josef Bacik <[email protected]>
Cc Miklos Szeredi <[email protected]>
Signed-off-by Jeff Layton <[email protected]>

I've applied the patch, with some tweaks to the commit message.
<https://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/?h=contrib&id=dfa492a21fd01e36c1858b9f8d66323e49011a96>

Have a lovely night!
Alex

Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
---
 man/man2/listmount.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man/man2/listmount.2 +1 -1
index 717581b85e12dc172b7c478b4608665e9da74933..00ac6a60c0cfead5c462fcac44e61647d841ffe5 100644
@@ -67,7 +67,7 @@ is used to tell the kernel what mount ID to start the list from.
 This is useful if multiple calls to
 .BR listmount (2)
 are required.
-This can be set to the last mount ID returned + 1 in order to
+This can be set to the last mount ID returned in order to
 resume from a previous spot in the list.
 .SH RETURN VALUE
 On success, the number of entries filled into
Signature · 1 line
<https://www.alejandro-colomar.es/>