Skip to contentSkip to conversation

clk:sophgo: Remove uninitialized variable for CV1800 PLL

PATCH Superseded Ragavendra 2 participants 3 messages Nov 13, 2024 – Nov 14, 2024

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Ragavendra

author
#0 lore raw

PATCH 1/1 clk:sophgo: Remove uninitialized variable for CV1800 PLL

Updating the detected value to 0 in the ipll_find_rate and removing it from the method parameters as it does not depend on external input. Updating the calls to ipll_find_rate as well and removing the u32 val variable from ipll_determine_rate.

Fixes 80fd61ec4612 ("clk: sophgo: Add clock support for CV1800 SoC")
---
 drivers/clk/sophgo/clk-cv18xx-pll.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)
drivers/clk/sophgo/clk-cv18xx-pll.c +4 -7
index 29e24098bf5f..350195d4ac46 100644
@@ -45,14 +45,13 @@ static unsigned long ipll_recalc_rate(struct clk_hw *hw,
 }
 
 static int ipll_find_rate(const struct cv1800_clk_pll_limit *limit,
-			  unsigned long prate, unsigned long *rate,
-			  u32 *value)
+			  unsigned long prate, unsigned long *rate)
 {
 	unsigned long best_rate = 0;
 	unsigned long trate = *rate;
 	unsigned long pre_div_sel = 0, div_sel = 0, post_div_sel = 0;
 	unsigned long pre, div, post;
-	u32 detected = *value;
+	u32 detected = 0;
 	unsigned long tmp;
 
 	for_each_pll_limit_range(pre, &limit->pre_div) {
@@ -77,7 +76,6 @@ static int ipll_find_rate(const struct cv1800_clk_pll_limit *limit,
 		detected = PLL_SET_PRE_DIV_SEL(detected, pre_div_sel);
 		detected = PLL_SET_POST_DIV_SEL(detected, post_div_sel);
 		detected = PLL_SET_DIV_SEL(detected, div_sel);
-		*value = detected;
 		*rate = best_rate;
 		return 0;
 	}
@@ -87,11 +85,10 @@ static int ipll_find_rate(const struct cv1800_clk_pll_limit *limit,
 
 static int ipll_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)
 {
-	u32 val;
 	struct cv1800_clk_pll *pll = hw_to_cv1800_clk_pll(hw);
 
 	return ipll_find_rate(pll->pll_limit, req->best_parent_rate,
-			      &req->rate, &val);
+			      &req->rate);
 }
 
 static void pll_get_mode_ctrl(unsigned long div_sel,
@@ -134,7 +131,7 @@ static int ipll_set_rate(struct clk_hw *hw, unsigned long rate,
 	unsigned long flags;
 	struct cv1800_clk_pll *pll = hw_to_cv1800_clk_pll(hw);
 
-	ipll_find_rate(pll->pll_limit, parent_rate, &rate, &detected);
+	ipll_find_rate(pll->pll_limit, parent_rate, &rate);
 	pll_get_mode_ctrl(PLL_GET_DIV_SEL(detected),
 			  ipll_check_mode_ctrl_restrict,
 			  pll->pll_limit, &detected);
Signature · 1 line
2.46.1
#1 lore raw

Hi, Ragavendra,

This patch should be revision for another https://lore.kernel.org/linux-clk/[email protected], right? If so you need add version info in the patch title and changelogs etc. Please read https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format carefully and re-post the patch.

Kindly reminder, better declare dropping of this patch email and repost v2.

Thanks,

Chen

Quoted 62 lines · Ragavendra

Updating the detected value to 0 in the ipll_find_rate and removing it from the method parameters as it does not depend on external input. Updating the calls to ipll_find_rate as well and removing the u32 val variable from ipll_determine_rate.

Fixes 80fd61ec4612 ("clk: sophgo: Add clock support for CV1800 SoC")
---
  drivers/clk/sophgo/clk-cv18xx-pll.c | 11 ++++-------
  1 file changed, 4 insertions(+), 7 deletions(-)
drivers/clk/sophgo/clk-cv18xx-pll.c +4 -7
index 29e24098bf5f..350195d4ac46 100644
@@ -45,14 +45,13 @@ static unsigned long ipll_recalc_rate(struct clk_hw *hw,
  }
 
  static int ipll_find_rate(const struct cv1800_clk_pll_limit *limit,
-			  unsigned long prate, unsigned long *rate,
-			  u32 *value)
+			  unsigned long prate, unsigned long *rate)
  {
  	unsigned long best_rate = 0;
  	unsigned long trate = *rate;
  	unsigned long pre_div_sel = 0, div_sel = 0, post_div_sel = 0;
  	unsigned long pre, div, post;
-	u32 detected = *value;
+	u32 detected = 0;
  	unsigned long tmp;
 
  	for_each_pll_limit_range(pre, &limit->pre_div) {
@@ -77,7 +76,6 @@ static int ipll_find_rate(const struct cv1800_clk_pll_limit *limit,
  		detected = PLL_SET_PRE_DIV_SEL(detected, pre_div_sel);
  		detected = PLL_SET_POST_DIV_SEL(detected, post_div_sel);
  		detected = PLL_SET_DIV_SEL(detected, div_sel);
-		*value = detected;
  		*rate = best_rate;
  		return 0;
  	}
@@ -87,11 +85,10 @@ static int ipll_find_rate(const struct cv1800_clk_pll_limit *limit,
 
  static int ipll_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)
  {
-	u32 val;
  	struct cv1800_clk_pll *pll = hw_to_cv1800_clk_pll(hw);
 
  	return ipll_find_rate(pll->pll_limit, req->best_parent_rate,
-			      &req->rate, &val);
+			      &req->rate);
  }
 
  static void pll_get_mode_ctrl(unsigned long div_sel,
@@ -134,7 +131,7 @@ static int ipll_set_rate(struct clk_hw *hw, unsigned long rate,
  	unsigned long flags;
  	struct cv1800_clk_pll *pll = hw_to_cv1800_clk_pll(hw);
 
-	ipll_find_rate(pll->pll_limit, parent_rate, &rate, &detected);
+	ipll_find_rate(pll->pll_limit, parent_rate, &rate);
  	pll_get_mode_ctrl(PLL_GET_DIV_SEL(detected),
  			  ipll_check_mode_ctrl_restrict,
  			  pll->pll_limit, &detected);
#2 lore raw
Quoted 62 lines · Chen Wang

Hi, Ragavendra,

This patch should be revision for another https://lore.kernel.org/linux-clk/[email protected],
right? If so you need add version info in the patch title and changelogs
etc. Please read https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
carefully and re-post the patch.

Kindly reminder, better declare dropping of this patch email and repost v2.

Thanks,

Chen

Quoted 48 lines · Ragavendra

Updating the detected value to 0 in the ipll_find_rate and removing it from the method parameters as it does not depend on external input. Updating the calls to ipll_find_rate as well and removing the u32 val variable from ipll_determine_rate.

Fixes 80fd61ec4612 ("clk: sophgo: Add clock support for CV1800 SoC")
---
  drivers/clk/sophgo/clk-cv18xx-pll.c | 11 ++++-------
  1 file changed, 4 insertions(+), 7 deletions(-)
drivers/clk/sophgo/clk-cv18xx-pll.c +3 -6
index 29e24098bf5f..350195d4ac46 100644
@@ -45,14 +45,13 @@ static unsigned long ipll_recalc_rate(struct clk_hw *hw,
  }
  static int ipll_find_rate(const struct cv1800_clk_pll_limit *limit,
-			  unsigned long prate, unsigned long *rate,
-			  u32 *value)
+			  unsigned long prate, unsigned long *rate)
  {
  	unsigned long best_rate = 0;
  	unsigned long trate = *rate;
  	unsigned long pre_div_sel = 0, div_sel = 0, post_div_sel = 0;
  	unsigned long pre, div, post;
-	u32 detected = *value;
+	u32 detected = 0;
  	unsigned long tmp;
  	for_each_pll_limit_range(pre, &limit->pre_div) {
@@ -77,7 +76,6 @@ static int ipll_find_rate(const struct cv1800_clk_pll_limit *limit,
  		detected = PLL_SET_PRE_DIV_SEL(detected, pre_div_sel);
  		detected = PLL_SET_POST_DIV_SEL(detected, post_div_sel);
  		detected = PLL_SET_DIV_SEL(detected, div_sel);
-		*value = detected;
  		*rate = best_rate;
  		return 0;
  	}
@@ -87,11 +85,10 @@ static int ipll_find_rate(const struct cv1800_clk_pll_limit *limit,
  static int ipll_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)
  {
-	u32 val;
  	struct cv1800_clk_pll *pll = hw_to_cv1800_clk_pll(hw);
  	return ipll_find_rate(pll->pll_limit, req->best_parent_rate,
-			      &req->rate, &val);
+			      &req->rate);
  }
  static void pll_get_mode_ctrl(unsigned long div_sel,
Quoted 8 lines

drivers/clk/sophgo/clk-cv18xx-pll.c static int ipll_set_rate(struct clk_hw *hw, unsigned long rate, · line 136

Quoted 8 lines
drivers/clk/sophgo/clk-cv18xx-pll.c +1 -1
@@ -134,7 +131,7 @@ static int ipll_set_rate(struct clk_hw *hw, unsigned long rate,
  	unsigned long flags;
  	struct cv1800_clk_pll *pll = hw_to_cv1800_clk_pll(hw);
-	ipll_find_rate(pll->pll_limit, parent_rate, &rate, &detected);
+	ipll_find_rate(pll->pll_limit, parent_rate, &rate);
  	pll_get_mode_ctrl(PLL_GET_DIV_SEL(detected),
  			  ipll_check_mode_ctrl_restrict,
  			  pll->pll_limit, &detected);

hi Chen,

This patch is the revision for the https://lore.kernel.org/linux-clk/[email protected] . I will update the version info and all and send in another email.

Please feel free to drop this patch email. I will shortly send v2 with the suggested updates.

--
Thanks,
Ragavendra N