ubifs: fix uninitialized variable usage
Subsystems (2)
PATCH 1/1 ubifs: fix uninitialized variable usage
In ubifs_jnl_write_inode(), when an inode cannot be deleted due to too many xattrs, err is passed to ubifs_ro_mode() uninitialized, thus leading to bogus error reporting.
Fix this case by passing -EPERM, which is the same value that ubifs_jnl_write_inode() is going to return to the caller.
This fixes 1 UNINIT issue reported by Coverity
Report: CID 1601860: Uninitialized scalar variable (UNINIT)
--- fs/ubifs/journal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ubifs/journal.c +1 -1
@@ -983,7 +983,7 @@ int ubifs_jnl_write_inode(struct ubifs_info *c, const struct inode *inode)if (kill_xattrs && ui->xattr_cnt >ubifs_xattr_max_cnt (c)) {ubifs_err (c,"Cannot delete inode, it has too much xattrs!" ); -ubifs_ro_mode (c, err); +ubifs_ro_mode (c, -EPERM );return -EPERM ; }
Signature · 1 line
2.45.2
Zhihao Cheng
reviewerQuoted 10 lines · Antonio Quartulli
In
ubifs_jnl_write_inode(), when an inode cannot be deleted due to too many xattrs, err is passed toubifs_ro_mode()uninitialized, thus leading to bogus error reporting.Fix this case by passing
-EPERM, which is the same value thatubifs_jnl_write_inode()is going to return to the caller.This fixes 1 UNINIT issue reported by Coverity
Report: CID 1601860: Uninitialized scalar variable (UNINIT)
Quoted 7 lines
Cc Richard Weinberger <[email protected]>Cc Zhihao Cheng <[email protected]>Cc [email protected] (open list)Signed-off-by Antonio Quartulli <[email protected]>--- fs/ubifs/journal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Hi Antonio, thanks for the patch. Nathan has sent a patch to fix it.
https://lore.kernel.org/linux-mtd/[email protected]/T/#t
Quoted 15 lines
fs/ubifs/journal.c +1
-1@@ -983,7 +983,7 @@ int ubifs_jnl_write_inode(struct ubifs_info *c, const struct inode *inode)if (kill_xattrs && ui->xattr_cnt >ubifs_xattr_max_cnt (c)) {ubifs_err (c,"Cannot delete inode, it has too much xattrs!" ); -ubifs_ro_mode (c, err); +ubifs_ro_mode (c, -EPERM );return -EPERM ; }
Quoted 19 lines · Zhihao Cheng
Quoted 10 lines · Antonio Quartulli
In
ubifs_jnl_write_inode(), when an inode cannot be deleted due to too many xattrs, err is passed toubifs_ro_mode()uninitialized, thus leading to bogus error reporting.Fix this case by passing
-EPERM, which is the same value thatubifs_jnl_write_inode()is going to return to the caller.This fixes 1 UNINIT issue reported by Coverity
Report: CID 1601860: Uninitialized scalar variable (UNINIT)Quoted 7 lines
Cc Richard Weinberger <[email protected]>Cc Zhihao Cheng <[email protected]>Cc [email protected] (open list)Signed-off-by Antonio Quartulli <[email protected]>---
fs/ubifs/journal.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 2 lines
Hi Antonio, thanks for the patch. Nathan has sent a patch to fix it.
https://lore.kernel.org/linux-mtd/ [email protected]/T/#t
Perfect!
Thanks for letting me know.
Regards,
Signature · 5 lines
Antonio Quartulli CEO and Co-Founder Mandelbit Srl https://www.mandelbit.com