Skip to contentSkip to conversation

bitbake.conf: set FILESYSTEM_PERMS_TABLES using ??=

PATCH In review Rasmus Villemoes 2 participants 3 messages Nov 21, 2024 – Nov 22, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bitbake.conf: set FILESYSTEM_PERMS_TABLES using ??=

From: Rasmus Villemoes <[email protected]>

This default value of FILESYSTEM_PERMS_TABLES is set before local.conf, ${DISTRO}.conf etc. are parsed. So in order for ${DISTRO}.conf to define the value, it has to use =. But that then precludes the ${MACHINE}.conf from having final say, unless one there resorts to some override hack.

Demote this default setting to a weak default. Then local.conf, ${DISTRO}.conf, ${MACHINE}.conf etc. can each use ?= with the expected precedence.

---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/bitbake.conf +1 -1
index 02bbf0e7a5..daf2d952e4 100644
@@ -381,7 +381,7 @@ FILESEXTRAPATHS ?= "__default:"
 #  base_prefix, prefix, exec_prefix, base_bindir, base_sbindir, base_libdir,
 #  datadir, sysconfdir, servicedir, sharedstatedir, localstatedir, infodir,
 #  mandir, docdir, bindir, sbindir, libexecdir, libdir and includedir
-FILESYSTEM_PERMS_TABLES ?=  "files/fs-perms.txt \
+FILESYSTEM_PERMS_TABLES ??= "files/fs-perms.txt \
                              files/fs-perms-volatile-log.txt \
                              files/fs-perms-volatile-tmp.txt"
 
Signature · 1 line
2.47.0
#1 lore raw
Quoted 38 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Rasmus Villemoes via lists.openembedded.org
Sent: den 21 november 2024 10:09
To: [email protected]
Cc: Richard Purdie <[email protected]>; Changqing Li <[email protected]>; [email protected]; Rasmus Villemoes <[email protected]>
Subject: [OE-core] [PATCH] bitbake.conf: set FILESYSTEM_PERMS_TABLES using ??=

From: Rasmus Villemoes <[email protected]>

This default value of FILESYSTEM_PERMS_TABLES is set before local.conf, ${DISTRO}.conf etc. are parsed. So in order for ${DISTRO}.conf to define the value, it has to use =. But that then precludes the ${MACHINE}.conf from having final say, unless one there resorts to some override hack.

Demote this default setting to a weak default. Then local.conf, ${DISTRO}.conf, ${MACHINE}.conf etc. can each use ?= with the expected precedence.

---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/bitbake.conf +1 -2
index 02bbf0e7a5..daf2d952e4 100644
@@ -381,7 +381,7 @@ FILESEXTRAPATHS ?= "__default:"
 #  base_prefix, prefix, exec_prefix, base_bindir, base_sbindir, base_libdir,
 #  datadir, sysconfdir, servicedir, sharedstatedir, localstatedir, infodir,
 #  mandir, docdir, bindir, sbindir, libexecdir, libdir and includedir
-FILESYSTEM_PERMS_TABLES ?=  "files/fs-perms.txt \
+FILESYSTEM_PERMS_TABLES ??= "files/fs-perms.txt \
                              files/fs-perms-volatile-log.txt \
                              files/fs-perms-volatile-tmp.txt"
 
--
Quoted 1 line

2.47.0

Careful now. Changing ?= to ??= means that it is no longer possible to use FILESYSTEM_PERMS_TABLES += "..." in, e.g., a ${DISTRO}.conf (something we do in our layers). Instead it requires that FILESYSTEM_PERMS_TABLES:append is used.

I guess there are pros and cons to both choices, but if it is changed then there needs to be a note about in the migration guide.

//Peter

#2 lore raw
Quoted 26 lines · Peter Kjellerstedt
Quoted 26 lines

From: Rasmus Villemoes <[email protected]>

This default value of FILESYSTEM_PERMS_TABLES is set before local.conf, ${DISTRO}.conf etc. are parsed. So in order for ${DISTRO}.conf to define the value, it has to use =. But that then precludes the ${MACHINE}.conf from having final say, unless one there resorts to some override hack.

Demote this default setting to a weak default. Then local.conf, ${DISTRO}.conf, ${MACHINE}.conf etc. can each use ?= with the expected precedence.

---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/bitbake.conf +0 -1
index 02bbf0e7a5..daf2d952e4 100644
@@ -381,7 +381,7 @@ FILESEXTRAPATHS ?= "__default:"
 #  base_prefix, prefix, exec_prefix, base_bindir, base_sbindir, base_libdir,
 #  datadir, sysconfdir, servicedir, sharedstatedir, localstatedir, infodir,
 #  mandir, docdir, bindir, sbindir, libexecdir, libdir and includedir
-FILESYSTEM_PERMS_TABLES ?=  "files/fs-perms.txt \
Quoted 9 lines

meta/conf/bitbake.conf FILESEXTRAPATHS ?= "__default:" · line 387

Quoted 4 lines
meta/conf/bitbake.conf +1 -0
+FILESYSTEM_PERMS_TABLES ??= "files/fs-perms.txt \
                              files/fs-perms-volatile-log.txt \
                              files/fs-perms-volatile-tmp.txt"
 

Careful now. Changing ?= to ??= means that it is no longer possible to use FILESYSTEM_PERMS_TABLES += "..." in, e.g., a ${DISTRO}.conf (something we do in our layers). Instead it requires that FILESYSTEM_PERMS_TABLES:append is used.

Ah, good point. I only considered the various forms of assignment people might have in the distro conf etc, not the various kinds of appends.

What prompted me to send this was that we'd like to have persistent logs, and the documentation says "remove files/fs-perms-volatile-log.txt from FILESYSTEM_PERMS_TABLES" - but I/we would rather not do that in our distro conf by using the :remove operator; we would rather set a default value for FILESYSTEM_PERMS_TABLES that derived distros or individual machines could then have final say over.

Commits 91128c651706 and 8d1ae67b89c4 don't offer much explanation why the individual flags were removed, but it does seem to make things somewhat less flexible.

As always, an extra level of indirection might be introduced (i.e. FILESYSTEM_PERMS_TABLE_LOG ??= "files/fs-perms-volatile-log.txt" and rewriting bitbake.conf's definition in terms of that...), but I'm loath to actually suggest that until I understand the actual motivation for those two commits.

Rasmus