genksyms: reduce indentation in export_symbol()
PATCH 1/1 genksyms: reduce indentation in export_symbol()
Modify this function to return earlier when find_symbol() returns NULL, reducing the level of improve readability.
No functional changes are intended.
Signed-off-by Masahiro Yamada <[email protected]>
---
scripts/genksyms/genksyms.c | 89 +++++++++++++++++++------------------ 1 file changed, 45 insertions(+), 44 deletions(-)
scripts/genksyms/genksyms.c +45 -44
@@ -632,54 +632,55 @@ static unsigned long expand_and_crc_sym(struct symbol *sym, unsigned long crc)void export_symbol (const char *name) {struct symbol *sym; +unsigned long crc; +int has_changed =0 ; sym =find_symbol (name,SYM_NORMAL ,0 ); -if (!sym) +if (!sym) {error_with_pos ("export undefined symbol %s" , name); -else { -unsigned long crc; -int has_changed =0 ; - -if (flag_dump_defs) -fprintf (debugfile,"Export %s == <" , name); - - expansion_trail = (struct symbol *)-1L ; - - sym->expansion_trail = expansion_trail; - expansion_trail = sym; - crc =expand_and_crc_sym (sym,0xffffffff ) ^0xffffffff ; - - sym = expansion_trail; -while (sym != (struct symbol *)-1L ) { -struct symbol *n = sym->expansion_trail; - -if (sym->status !=STATUS_UNCHANGED ) { -if (!has_changed) { -print_location (); -fprintf (stderr,"%s: %s: modversion " -"changed because of changes " -"in " , flag_preserve ?"error" : -"warning" , name); - }else -fprintf (stderr,", " ); -print_type_name (sym->type, sym->name); -if (sym->status ==STATUS_DEFINED ) -fprintf (stderr," (became defined)" ); - has_changed =1 ; -if (flag_preserve) - errors++; - } - sym->expansion_trail =0 ; - sym = n; - } -if (has_changed) -fprintf (stderr,"\n" ); - -if (flag_dump_defs) -fputs (">\n" , debugfile); - -printf ("#SYMVER %s 0x%08lx\n" , name, crc); +return ; } + +if (flag_dump_defs) +fprintf (debugfile,"Export %s == <" , name); + + expansion_trail = (struct symbol *)-1L ; + + sym->expansion_trail = expansion_trail; + expansion_trail = sym; + crc =expand_and_crc_sym (sym,0xffffffff ) ^0xffffffff ; + + sym = expansion_trail; +while (sym != (struct symbol *)-1L ) { +struct symbol *n = sym->expansion_trail; + +if (sym->status !=STATUS_UNCHANGED ) { +if (!has_changed) { +print_location (); +fprintf (stderr, +"%s: %s: modversion changed because of changes in " , + flag_preserve ?"error" :"warning" , + name); + }else { +fprintf (stderr,", " ); + } +print_type_name (sym->type, sym->name); +if (sym->status ==STATUS_DEFINED ) +fprintf (stderr," (became defined)" ); + has_changed =1 ; +if (flag_preserve) + errors++; + } + sym->expansion_trail =0 ; + sym = n; + } +if (has_changed) +fprintf (stderr,"\n" ); + +if (flag_dump_defs) +fputs (">\n" , debugfile); + +printf ("#SYMVER %s 0x%08lx\n" , name, crc); }/*----------------------------------------------------------------------*/
Signature · 1 line
2.43.0