Skip to contentSkip to conversation

lib: sbom30: Prefix aliases with "http://spdx.org/spdxdocs/"

PATCH In review Joshua Watt 2 participants 2 messages Nov 22, 2024 – Nov 23, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib: sbom30: Prefix aliases with "http://spdx.org/spdxdocs/"

While the SPDX ID aliases are primarily intended for internal use by the SPDX code, they are used in places where a valid SPDX ID is expected. In order to make sure that they still conform to this, prefix them with "http://spdx.org/spdxdocs/openembedded-alias"

---
 meta/lib/oe/sbom30.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/lib/oe/sbom30.py +3 -1
index 56cdd7ba4c6..7acb5234db2 100644
@@ -344,7 +344,9 @@ class ObjectSet(oe.spdx30.SHACLObjectSet):
                 alias_ext = set_alias(
                     e,
                     e._id.replace(unihash, "UNIHASH").replace(
-                        namespace, self.d.getVar("PN")
+                        namespace,
+                        "http://spdx.org/spdxdocs/openembedded-alias/"
+                        + self.d.getVar("PN"),
                     ),
                 )
 
Signature · 1 line
2.47.0
#1 lore raw

Hi Joshua,

This patch conflicts with '[PATCH V2 1/3] sbom30/spdx30: add link prefix and name to namespace of spdxId and alias '[1], would you have suggestions about review '[RR V2][NULL][0/3] SPDX 3.0: Reduce redundant spdxid-hash symlinks to save inode on host '[2]? Should I rebase my review along with your patch?

[1]https://lists.openembedded.org/g/openembedded-core/message/207412?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2C%2C20%2C2%2C0%2C109680229%2Cd%253D4&d=4 [2]https://lists.openembedded.org/g/openembedded-core/topic/109680228#msg207411

//Hongxu