Skip to contentSkip to conversation

xfs: don't call xfs_bmap_same_rtgroup in xfs_bmap_add_extent_hole_delay

PATCH Applied Christoph Hellwig 2 participants 2 messages Nov 26, 2024 – Nov 28, 2024 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: don't call xfs_bmap_same_rtgroup in xfs_bmap_add_extent_hole_delay

xfs_bmap_add_extent_hole_delay works entirely on delalloc extents, for which xfs_bmap_same_rtgroup doesn't make sense.

---
 fs/xfs/libxfs/xfs_bmap.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
fs/xfs/libxfs/xfs_bmap.c +2 -4
index e7f768a43724..d1e700213550 100644
@@ -2617,8 +2617,7 @@ xfs_bmap_add_extent_hole_delay(
 	 */
 	if ((state & BMAP_LEFT_VALID) && (state & BMAP_LEFT_DELAY) &&
 	    left.br_startoff + left.br_blockcount == new->br_startoff &&
-	    left.br_blockcount + new->br_blockcount <= XFS_MAX_BMBT_EXTLEN &&
-	    xfs_bmap_same_rtgroup(ip, whichfork, &left, new))
+	    left.br_blockcount + new->br_blockcount <= XFS_MAX_BMBT_EXTLEN)
 		state |= BMAP_LEFT_CONTIG;
 
 	if ((state & BMAP_RIGHT_VALID) && (state & BMAP_RIGHT_DELAY) &&
@@ -2626,8 +2625,7 @@ xfs_bmap_add_extent_hole_delay(
 	    new->br_blockcount + right.br_blockcount <= XFS_MAX_BMBT_EXTLEN &&
 	    (!(state & BMAP_LEFT_CONTIG) ||
 	     (left.br_blockcount + new->br_blockcount +
-	      right.br_blockcount <= XFS_MAX_BMBT_EXTLEN)) &&
-	    xfs_bmap_same_rtgroup(ip, whichfork, new, &right))
+	      right.br_blockcount <= XFS_MAX_BMBT_EXTLEN)))
 		state |= BMAP_RIGHT_CONTIG;
 
 	/*
Signature · 1 line
2.45.2
maintainer Applied
#1 lore raw
Quoted 4 lines · Christoph Hellwig

xfs_bmap_add_extent_hole_delay works entirely on delalloc extents, for which xfs_bmap_same_rtgroup doesn't make sense.

Applied to for-next, thanks!

[1/1] xfs: don't call xfs_bmap_same_rtgroup in xfs_bmap_add_extent_hole_delay

      commit: cc2dba08cc33daf8acd6e560957ef0e0f4d034ed

Best regards,

Signature · 1 line
Carlos Maiolino <[email protected]>