Place __kernel_entry at the beginning of text section
PATCH v2 1/1 Place __kernel_entry at the beginning of text section
Mark __kernel_entry as ".head.text" and place HEAD_TEXT before TEXT_TEXT in the linker script. This ensures that __kernel_entry will be placed at the beginning of text section.
Drop mips from scripts/head-object-list.txt.
--- arch/mips/kernel/head.S | 1 + arch/mips/kernel/vmlinux.lds.S | 1 + scripts/head-object-list.txt | 1 - 3 files changed, 2 insertions(+), 1 deletion(-)
arch/mips/kernel/head.S +1 -0
@@ -59,6 +59,7 @@ #endif .endm + __HEAD #ifndef CONFIG_NO_EXCEPT_FILL /* * Reserved space for exception handlers.
arch/mips/kernel/vmlinux.lds.S +1 -0
@@ -62,6 +62,7 @@ SECTIONS _text = .; /* Text and read-only data */ _stext = .; .text : { + HEAD_TEXT TEXT_TEXT SCHED_TEXT LOCK_TEXT
scripts/head-object-list.txt +0 -1
@@ -23,7 +23,6 @@ arch/m68k/coldfire/head.o arch/m68k/kernel/head.o arch/m68k/kernel/sun3-head.o arch/microblaze/kernel/head.o -arch/mips/kernel/head.o arch/nios2/kernel/head.o arch/openrisc/kernel/head.o arch/parisc/kernel/head.o
base-commit: 3596c721c4348b2a964e43f9296a0c01509ba927
Signature · 1 line
2.47.0.338.g60cca15819-goog
I forgot to add the changelog for this V2: The change was to move __HEAD down based on Chris Packham's review.
-Rong
Quoted 58 lines · Rong Xu
Mark
__kernel_entryas ".head.text" and placeHEAD_TEXTbeforeTEXT_TEXTin the linker script. This ensures that__kernel_entrywill be placed at the beginning of text section.Drop mips from
scripts/head-object-list.txt.Signed-off-by Rong Xu <[email protected]>Reported-by Chris Packham <[email protected]>Tested-by Chris Packham <[email protected]>--- arch/mips/kernel/head.S | 1 + arch/mips/kernel/vmlinux.lds.S | 1 + scripts/head-object-list.txt | 1 - 3 files changed, 2 insertions(+), 1 deletion(-)arch/mips/kernel/head.S +1
-0@@ -59,6 +59,7 @@ #endif .endm + __HEAD #ifndef CONFIG_NO_EXCEPT_FILL /* * Reserved space for exception handlers.arch/mips/kernel/vmlinux.lds.S +1
-0@@ -62,6 +62,7 @@ SECTIONS _text = .; /* Text and read-only data */ _stext = .; .text : { + HEAD_TEXT TEXT_TEXT SCHED_TEXT LOCK_TEXTscripts/head-object-list.txt +0
-1@@ -23,7 +23,6 @@ arch/m68k/coldfire/head.o arch/m68k/kernel/head.o arch/m68k/kernel/sun3-head.o arch/microblaze/kernel/head.o -arch/mips/kernel/head.o arch/nios2/kernel/head.o arch/openrisc/kernel/head.o arch/parisc/kernel/head.obase-commit:
3596c721c4348b2a964e43f9296a0c01509ba927--
2.47.0.338.g60cca15819-goog
Quoted 11 lines · Rong Xu
Mark
__kernel_entryas ".head.text" and placeHEAD_TEXTbeforeTEXT_TEXTin the linker script. This ensures that__kernel_entrywill be placed at the beginning of text section.Drop mips from
scripts/head-object-list.txt.Signed-off-by Rong Xu <[email protected]>Reported-by Chris Packham <[email protected]>Tested-by Chris Packham <[email protected]>
Applied to linux-kbuild.
(Inserted before the offending commit)
Thanks!
Signature · 2 lines
Best Regards Masahiro Yamada
arch/mips/kernel/head.S line 65
Quoted 12 lines · Rong Xu
arch/mips/kernel/head.S +1
-0@@ -59,6 +59,7 @@ #endif .endm + __HEAD #ifndef CONFIG_NO_EXCEPT_FILL /* * Reserved space for exception handlers.
A new line would be preferable afterwards so as to visually separate the
directive from the conditional part that follows. It looks messy as it stands (and we have prior art further down the file with __REF). Please send a fix.
Maciej
Sure. I'll send a separate patch for this format change (not v3 as this patch was already submitted).
Thanks!
-Rong
Quoted 22 lines · Maciej W. Rozycki
arch/mips/kernel/head.S line 65
Quoted 12 lines · Rong Xu
arch/mips/kernel/head.S +1
-0@@ -59,6 +59,7 @@ #endif .endm + __HEAD #ifndef CONFIG_NO_EXCEPT_FILL /* * Reserved space for exception handlers.A new line would be preferable afterwards so as to visually separate the
directive from the conditional part that follows. It looks messy as it stands (and we have prior art further down the file with__REF). Please send a fix.Maciej