Skip to contentSkip to conversation

scsi: pm80xx: Increase reserved tags from 8 to 128

PATCH Applied Salomon Dushimirimana 2 participants 3 messages Nov 26, 2024 – Dec 10, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: pm80xx: Increase reserved tags from 8 to 128

From: Igor Pylypiv <[email protected]>

Increase the number of reserved tags to prevent command processing failures when the driver is under stress. 8 reserved tags are quickly getting all used up leading to errors when command completions are delayed.

The driver needs ~512 ccbs/tags for maximum I/O utilization:
16 (max disks) * 32 (max SATA queue depth) = ~512 ccbs/tags.

By reserving 128 tags the driver will still have plenty of tags/ccbs
left: 1024 (max ccbs) - 128 (reserved slot) = 896 tags/ccbs left.

---
 drivers/scsi/pm8001/pm8001_defs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/pm8001/pm8001_defs.h +1 -1
index 501b574239e8..abe6560a5817 100644
@@ -90,7 +90,7 @@ enum port_type {
 #define	PM8001_MAX_PORTS	 16	/* max. possible ports */
 #define	PM8001_MAX_DEVICES	 2048	/* max supported device */
 #define	PM8001_MAX_MSIX_VEC	 64	/* max msi-x int for spcv/ve */
-#define	PM8001_RESERVE_SLOT	 8
+#define	PM8001_RESERVE_SLOT	 128
 
 #define	CONFIG_SCSI_PM8001_MAX_DMA_SG	528
 #define PM8001_MAX_DMA_SG	CONFIG_SCSI_PM8001_MAX_DMA_SG
Signature · 1 line
2.47.0.338.g60cca15819-goog
#1 lore raw

Salomon,

Quoted 4 lines

Increase the number of reserved tags to prevent command processing failures when the driver is under stress. 8 reserved tags are quickly getting all used up leading to errors when command completions are delayed.

Applied to 6.14/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#2 lore raw
In reply to Salomon Dushimirimana
Quoted 9 lines · Salomon Dushimirimana

Increase the number of reserved tags to prevent command processing failures when the driver is under stress. 8 reserved tags are quickly getting all used up leading to errors when command completions are delayed.

The driver needs ~512 ccbs/tags for maximum I/O utilization:
16 (max disks) * 32 (max SATA queue depth) = ~512 ccbs/tags.

[...]

Applied to 6.14/scsi-queue, thanks!

[1/1] scsi: pm80xx: Increase reserved tags from 8 to 128

      https://git.kernel.org/mkp/scsi/c/b64004dbcd23
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering