mailbox: tegra-hsp: Clear mailbox before using message
Subsystems (2)
PATCH 1/1 mailbox: tegra-hsp: Clear mailbox before using message
From: Pekka Pessi <[email protected]>
Some clients depend on mailbox being empty before processing the message. On RT kernel, the thread processing the message may be on different CPU or running with higher priority than the interrupt handler thread and they may act on the message before mailbox is emptied.
--- drivers/mailbox/tegra-hsp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mailbox/tegra-hsp.c +2 -1
@@ -388,7 +388,6 @@ static void tegra_hsp_sm_recv32(struct tegra_hsp_channel *channel) value =tegra_hsp_channel_readl (channel,HSP_SM_SHRD_MBOX ); value &= ~HSP_SM_SHRD_MBOX_FULL ; msg = (void *)(unsigned long )value; -mbox_chan_received_data (channel->chan, msg);/* * Need to clear all bits here since some producers, such as TCU, depend
@@ -398,6 +397,8 @@ static void tegra_hsp_sm_recv32(struct tegra_hsp_channel *channel)* explicitly, so we have to make sure we cover all possible cases. */ tegra_hsp_channel_writel (channel,0x0 ,HSP_SM_SHRD_MBOX ); + +mbox_chan_received_data (channel->chan, msg); }static const struct tegra_hsp_sm_ops tegra_hsp_sm_32bit_ops = {
Signature · 1 line
2.47.0
Jon Hunter
maintainerQuoted 10 lines · Kartik Rajput
From: Pekka Pessi <[email protected]>
Some clients depend on mailbox being empty before processing the message. On RT kernel, the thread processing the message may be on different CPU or running with higher priority than the interrupt handler thread and they may act on the message before mailbox is emptied.
Signed-off-by Pekka Pessi <[email protected]>Signed-off-by Kartik Rajput <[email protected]>
We should include a fixes tag here. I believe that this would be a good candidate for stable too and so worth CC stable on this.
Thanks!
Jon
Signature · 1 line
nvpublic