Skip to contentSkip to conversation

bindings: python: fix license tags

PATCH In review Bartosz Golaszewski 3 participants 4 messages Nov 27, 2024 – Dec 5, 2024 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bindings: python: fix license tags

From: Bartosz Golaszewski <[email protected]>

Several files under bindings/python/ have wrong license tags.

In general:
- Makefiles should be covered by GPL
- all python sources under bindings/python/gpiod/ and bindings/python/tests/ that are part of importable modules should be licensed under LGPL
- executable examples should be licensed under GPL

---
Kent, Vincent:

This patch doesn't really relicense the code. It just makes the licensing consistent across the python bindings. However - as the only two authors of the affected files other than me - could you please leave your acks?

 bindings/python/gpiod/Makefile.am            | 2 +-
 bindings/python/gpiod/_internal.py           | 2 +-
 bindings/python/gpiod/ext/Makefile.am        | 2 +-
 bindings/python/tests/Makefile.am            | 2 +-
 bindings/python/tests/gpiosim/Makefile.am    | 2 +-
 bindings/python/tests/gpiosim/__init__.py    | 2 +-
 bindings/python/tests/helpers.py             | 2 +-
 bindings/python/tests/system/Makefile.am     | 2 +-
 bindings/python/tests/system/__init__.py     | 2 +-
 bindings/python/tests/tests_line.py          | 2 +-
 bindings/python/tests/tests_line_settings.py | 2 +-
 11 files changed, 11 insertions(+), 11 deletions(-)
bindings/python/gpiod/Makefile.am +1 -1
index 49addcc..7e37b8d 100644
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <[email protected]>
 
 SUBDIRS = ext
bindings/python/gpiod/_internal.py +1 -1
index c9b5d28..37f6661 100644
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: GPL-2.0-or-later
+# SPDX-License-Identifier: LGPL-2.1-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <[email protected]>
 
 from datetime import timedelta
bindings/python/gpiod/ext/Makefile.am +1 -1
index 9c81b17..3a8a0d1 100644
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <[email protected]>
 
 EXTRA_DIST = \
bindings/python/tests/Makefile.am +1 -1
index d6e3ea3..1809206 100644
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <[email protected]>
 
 SUBDIRS = gpiosim system
bindings/python/tests/gpiosim/Makefile.am +1 -1
index b403f3c..cc8c11a 100644
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <[email protected]>
 
 EXTRA_DIST = \
bindings/python/tests/gpiosim/__init__.py +1 -1
index 64a1551..ddb59be 100644
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: GPL-2.0-or-later
+# SPDX-License-Identifier: LGPL-2.1-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <[email protected]>
 
 from .chip import Chip
bindings/python/tests/helpers.py +1 -1
index 2126901..ad272a1 100644
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: GPL-2.0-or-later
+# SPDX-License-Identifier: LGPL-2.1-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <[email protected]>
 
 from __future__ import annotations
bindings/python/tests/system/Makefile.am +1 -1
index dbc8e64..3590be3 100644
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <[email protected]>
 
 EXTRA_DIST = \
bindings/python/tests/system/__init__.py +1 -1
index cba9b92..99fde9c 100644
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: GPL-2.0-or-later
+# SPDX-License-Identifier: LGPL-2.1-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <[email protected]>
 
 from ._ext import check_kernel_version, set_process_name
bindings/python/tests/tests_line.py +1 -1
index c96f6de..5bc742a 100644
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
 # SPDX-FileCopyrightText: 2024 Kent Gibson <[email protected]>
 
 from unittest import TestCase
bindings/python/tests/tests_line_settings.py +1 -1
index 66e01df..ad70921 100644
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <[email protected]>
 
 import datetime
Signature · 1 line
2.45.2
Acked-by on v1 1/1
#1 lore raw

RE: [External] - [libgpiod][PATCH] bindings: python: fix license tags

Quoted 26 lines

-----Original Message-----
From: Bartosz Golaszewski <[email protected]>
Sent: Wednesday, November 27, 2024 9:05 AM
To: Vincent Fazio <[email protected]>; Phil Howard <[email protected]>; Kent Gibson <[email protected]>; Linus Walleij <[email protected]>
Cc: [email protected]; Bartosz Golaszewski <[email protected]>
Subject: [External] - [libgpiod][PATCH] bindings: python: fix license tags

From: Bartosz Golaszewski <[email protected]>

Several files under bindings/python/ have wrong license tags.

In general:
- Makefiles should be covered by GPL
- all python sources under bindings/python/gpiod/ and bindings/python/tests/ that are part of importable modules should be licensed under LGPL
- executable examples should be licensed under GPL

Quoted 6 lines

---
Kent, Vincent:

This patch doesn't really relicense the code. It just makes the licensing consistent across the python bindings. However - as the only two authors of the affected files other than me - could you please leave your acks?

#2 lore raw
In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Quoted 10 lines · Bartosz Golaszewski

Several files under bindings/python/ have wrong license tags.

In general:
- Makefiles should be covered by GPL
- all python sources under bindings/python/gpiod/ and bindings/python/tests/ that are part of importable modules should be licensed under LGPL
- executable examples should be licensed under GPL

[...]

I haven't heard from Kent but I doubt he would object so patch applied.

[1/1] bindings: python: fix license tags

      commit: 6d9133a259e64da5e03c7e7784f0f27de7b3e59f

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>
#3 lore raw
Quoted 13 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Quoted 9 lines · Bartosz Golaszewski

Several files under bindings/python/ have wrong license tags.

In general:
- Makefiles should be covered by GPL
- all python sources under bindings/python/gpiod/ and bindings/python/tests/ that are part of importable modules should be licensed under LGPL
- executable examples should be licensed under GPL

Quoted 4 lines
Quoted 1 line

[...]

I haven't heard from Kent but I doubt he would object so patch applied.

Sorry - missed this one, but I have no objections.

Cheers,
Kent.