arm64: dts: rockchip: add support for device tree overlays for Radxa devices
Subsystems (2)
PATCH 1/1 arm64: dts: rockchip: add support for device tree overlays for Radxa devices
since Radxa devices use device tree overlays[1][2][3], make base .dts support them.
[1] arch/arm64/boot/dts/rockchip/rk3588-rock-5b-pcie-ep.dtso
[2] arch/arm64/boot/dts/rockchip/rk3588-rock-5b-pcie-srns.dtso
[3] https://github.com/radxa-pkg/radxa-overlays
--- arch/arm64/boot/dts/rockchip/Makefile | 28 +++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)
arch/arm64/boot/dts/rockchip/Makefile +28 -0
@@ -1,4 +1,32 @@ # SPDX-License-Identifier: GPL-2.0 + +# Enables support for device tree overlays for Radxa devices +DTC_FLAGS_rk3308-rock-pi-s := -@ +DTC_FLAGS_rk3308-rock-s0 := -@ +DTC_FLAGS_rk3328-rock-pi-e := -@ +DTC_FLAGS_rk3399-rock-4c-plus := -@ +DTC_FLAGS_rk3399-rock-4se := -@ +DTC_FLAGS_rk3399-rock-pi-4a-plus := -@ +DTC_FLAGS_rk3399-rock-pi-4a := -@ +DTC_FLAGS_rk3399-rock-pi-4b-plus := -@ +DTC_FLAGS_rk3399-rock-pi-4b := -@ +DTC_FLAGS_rk3399-rock-pi-4c := -@ +DTC_FLAGS_rk3399pro-rock-pi-n10 := -@ +DTC_FLAGS_rk3528-radxa-e20c := -@ +DTC_FLAGS_rk3566-radxa-cm3-io := -@ +DTC_FLAGS_rk3566-radxa-cm3.dtsi := -@ +DTC_FLAGS_rk3566-radxa-zero-3e := -@ +DTC_FLAGS_rk3566-radxa-zero-3w := -@ +DTC_FLAGS_rk3566-rock-3c := -@ +DTC_FLAGS_rk3568-radxa-cm3i.dtsi := -@ +DTC_FLAGS_rk3568-radxa-e25 := -@ +DTC_FLAGS_rk3568-rock-3a := -@ +DTC_FLAGS_rk3568-rock-3b := -@ +DTC_FLAGS_rk3588-rock-5-itx := -@ +DTC_FLAGS_rk3588-rock-5b := -@ +DTC_FLAGS_rk3588s-rock-5a := -@ +DTC_FLAGS_rk3588s-rock-5c := -@ + dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-evb.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2-of10.dtb
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Heiko Stübner
maintainerHey,
Am Freitag, 29. November 2024, 01:24:19 CET schrieb FUKAUMI Naoki:
Quoted 2 lines
since Radxa devices use device tree overlays[1][2][3], make base .dts support them.
this essentially doubles the sizes of generated DTBs.
In previous iterations there were concerns that this might overload allocated memory in legacy firmware that might still run on people's devices.
I'm not sure if someone did look deeper into that meanwhile and you can't of course not require people to update u-boot just for a kernel upgrade. Hence previous overlays do not enable those options but instead depend on "distributions" to handle that.
So I'm definitly not sure how to proceed with this.
Heiko
Quoted 47 lines
[1]
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-pcie-ep.dtso
[2]arch/arm64/boot/dts/rockchip/rk3588-rock-5b-pcie-srns.dtso
[3] https://github.com/radxa-pkg/radxa-overlaysSigned-off-by FUKAUMI Naoki <[email protected]>--- arch/arm64/boot/dts/rockchip/Makefile | 28 +++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)arch/arm64/boot/dts/rockchip/Makefile +28
-0@@ -1,4 +1,32 @@ # SPDX-License-Identifier: GPL-2.0 + +# Enables support for device tree overlays for Radxa devices +DTC_FLAGS_rk3308-rock-pi-s := -@ +DTC_FLAGS_rk3308-rock-s0 := -@ +DTC_FLAGS_rk3328-rock-pi-e := -@ +DTC_FLAGS_rk3399-rock-4c-plus := -@ +DTC_FLAGS_rk3399-rock-4se := -@ +DTC_FLAGS_rk3399-rock-pi-4a-plus := -@ +DTC_FLAGS_rk3399-rock-pi-4a := -@ +DTC_FLAGS_rk3399-rock-pi-4b-plus := -@ +DTC_FLAGS_rk3399-rock-pi-4b := -@ +DTC_FLAGS_rk3399-rock-pi-4c := -@ +DTC_FLAGS_rk3399pro-rock-pi-n10 := -@ +DTC_FLAGS_rk3528-radxa-e20c := -@ +DTC_FLAGS_rk3566-radxa-cm3-io := -@ +DTC_FLAGS_rk3566-radxa-cm3.dtsi := -@ +DTC_FLAGS_rk3566-radxa-zero-3e := -@ +DTC_FLAGS_rk3566-radxa-zero-3w := -@ +DTC_FLAGS_rk3566-rock-3c := -@ +DTC_FLAGS_rk3568-radxa-cm3i.dtsi := -@ +DTC_FLAGS_rk3568-radxa-e25 := -@ +DTC_FLAGS_rk3568-rock-3a := -@ +DTC_FLAGS_rk3568-rock-3b := -@ +DTC_FLAGS_rk3588-rock-5-itx := -@ +DTC_FLAGS_rk3588-rock-5b := -@ +DTC_FLAGS_rk3588s-rock-5a := -@ +DTC_FLAGS_rk3588s-rock-5c := -@ + dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-evb.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2-of10.dtb
Hi,
Quoted 10 lines · Heiko Stübner
Am Freitag, 29. November 2024, 01:24:19 CET schrieb FUKAUMI Naoki:
Quoted 2 lines
since Radxa devices use device tree overlays[1][2][3], make base .dts support them.
this essentially doubles the sizes of generated DTBs.
In previous iterations there were concerns that this might overload allocated memory in legacy firmware that might still run on people's devices.
Quoted 6 lines
I'm not sure if someone did look deeper into that meanwhile and you can't of course not require people to update u-boot just for a kernel upgrade. Hence previous overlays do not enable those options but instead depend on "distributions" to handle that.
So I'm definitly not sure how to proceed with this.
In my recollection this was brought up when the restructuring of the arm (not arm64) dts 'tree' was discussed.
So hopefully Rob can recall the details?
But IIRC, the objection was about enabling it *globally* and instead it should be done more granually, be it on the SoC manufacturer level ('rockchip') or on the SoC ('rk3588') or on the board level as is proposed in this patch.
e925743edc0d ("arm: dts: bcm: Enable device-tree overlay support for RPi devices") is where it got enabled for RPi devices
I can't speak for the Debian kernel team, but the general approach is:
get it fixed (or in this case enabled) *upstream*.
That's why Aurelien Jarno (who's a DD) send it upstream.
HTH,
Diederik
Quoted 46 lines
Quoted 46 lines
[1]
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-pcie-ep.dtso
[2]arch/arm64/boot/dts/rockchip/rk3588-rock-5b-pcie-srns.dtso
[3] https://github.com/radxa-pkg/radxa-overlaysSigned-off-by FUKAUMI Naoki <[email protected]>--- arch/arm64/boot/dts/rockchip/Makefile | 28 +++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)arch/arm64/boot/dts/rockchip/Makefile +28
-0@@ -1,4 +1,32 @@ # SPDX-License-Identifier: GPL-2.0 + +# Enables support for device tree overlays for Radxa devices +DTC_FLAGS_rk3308-rock-pi-s := -@ +DTC_FLAGS_rk3308-rock-s0 := -@ +DTC_FLAGS_rk3328-rock-pi-e := -@ +DTC_FLAGS_rk3399-rock-4c-plus := -@ +DTC_FLAGS_rk3399-rock-4se := -@ +DTC_FLAGS_rk3399-rock-pi-4a-plus := -@ +DTC_FLAGS_rk3399-rock-pi-4a := -@ +DTC_FLAGS_rk3399-rock-pi-4b-plus := -@ +DTC_FLAGS_rk3399-rock-pi-4b := -@ +DTC_FLAGS_rk3399-rock-pi-4c := -@ +DTC_FLAGS_rk3399pro-rock-pi-n10 := -@ +DTC_FLAGS_rk3528-radxa-e20c := -@ +DTC_FLAGS_rk3566-radxa-cm3-io := -@ +DTC_FLAGS_rk3566-radxa-cm3.dtsi := -@ +DTC_FLAGS_rk3566-radxa-zero-3e := -@ +DTC_FLAGS_rk3566-radxa-zero-3w := -@ +DTC_FLAGS_rk3566-rock-3c := -@ +DTC_FLAGS_rk3568-radxa-cm3i.dtsi := -@ +DTC_FLAGS_rk3568-radxa-e25 := -@ +DTC_FLAGS_rk3568-rock-3a := -@ +DTC_FLAGS_rk3568-rock-3b := -@ +DTC_FLAGS_rk3588-rock-5-itx := -@ +DTC_FLAGS_rk3588-rock-5b := -@ +DTC_FLAGS_rk3588s-rock-5a := -@ +DTC_FLAGS_rk3588s-rock-5c := -@ + dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-evb.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2-of10.dtb
Heiko Stübner
maintainerAm Freitag, 29. November 2024, 13:46:12 CET schrieb Diederik de Haas:
Quoted 29 lines
Hi,
Quoted 10 lines · Heiko Stübner
Am Freitag, 29. November 2024, 01:24:19 CET schrieb FUKAUMI Naoki:
Quoted 2 lines
since Radxa devices use device tree overlays[1][2][3], make base .dts support them.
this essentially doubles the sizes of generated DTBs.
In previous iterations there were concerns that this might overload allocated memory in legacy firmware that might still run on people's devices.
Quoted 6 lines
I'm not sure if someone did look deeper into that meanwhile and you can't of course not require people to update u-boot just for a kernel upgrade. Hence previous overlays do not enable those options but instead depend on "distributions" to handle that.
So I'm definitly not sure how to proceed with this.
In my recollection this was brought up when the restructuring of the arm (not arm64) dts 'tree' was discussed.
So hopefully Rob can recall the details?But IIRC, the objection was about enabling it *globally* and instead it should be done more granually, be it on the SoC manufacturer level ('rockchip') or on the SoC ('rk3588') or on the board level as is proposed in this patch.
Quoted 6 lines
e925743edc0d("arm: dts: bcm: Enable device-tree overlay support for RPi devices") is where it got enabled for RPi devicesI can't speak for the Debian kernel team, but the general approach is:
get it fixed (or in this case enabled) *upstream*.
That's why Aurelien Jarno (who's a DD) send it upstream.
I actually meant that less broadly and way more Rockchip-specific ;-)
I.e. I think it was Dragan that brought it up that old firmware binaries (u-boot, tf-a, ...) may occupy memory regions that may run over by an overly large dtb, but can't find the mail right now.
Hence when unsuspecting people update their kernel on a
(i.e. Radxa-)device with really old firmware there might be a possibility that stuff may break when the dtb handed around doubles in size.
Heiko
Quoted 7 lines · Heiko Stübner
Am Freitag, 29. November 2024, 13:46:12 CET schrieb Diederik de Haas:
Quoted 4 lines
But IIRC, the objection was about enabling it *globally* and instead it should be done more granually, be it on the SoC manufacturer level ('rockchip') or on the SoC ('rk3588') or on the board level as is proposed in this patch.
I actually meant that less broadly and way more Rockchip-specific ;-)
Ah, sorry, then I misunderstood.