Skip to contentSkip to conversation

interconnect: icc-clk: check return values of devm_kasprintf()

PATCH In review Bartosz Golaszewski 2 participants 3 messages Dec 2, 2024 – Dec 16, 2024 Interconnect API

lore
Share & tools
lore

Bartosz Golaszewski

author
#0 lore raw

PATCH 1/1 interconnect: icc-clk: check return values of devm_kasprintf()

From: Bartosz Golaszewski <[email protected]>

devm_kasprintf() can fail and return NULL, add missing return value checks.

Fixes 0ac2a08f42ce ("interconnect: add clk-based icc provider support")
Signed-off-by Bartosz Golaszewski <[email protected]>
---
 drivers/interconnect/icc-clk.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/interconnect/icc-clk.c +10 -0
index b956e4050f381..88f311c110207 100644
@@ -116,6 +116,11 @@ struct icc_provider *icc_clk_register(struct device *dev,
 		}
 
 		node->name = devm_kasprintf(dev, GFP_KERNEL, "%s_master", data[i].name);
+		if (!node->name) {
+			ret = -ENOMEM;
+			goto err;
+		}
+
 		node->data = &qp->clocks[i];
 		icc_node_add(node, provider);
 		/* link to the next node, slave */

@@ -129,6 +134,11 @@ struct icc_provider *icc_clk_register(struct device *dev,
 		}
 
 		node->name = devm_kasprintf(dev, GFP_KERNEL, "%s_slave", data[i].name);
+		if (!node->name) {
+			ret = -ENOMEM;
+			goto err;
+		}
+
 		/* no data for slave node */
 		icc_node_add(node, provider);
 		onecell->nodes[j++] = node;
Signature · 1 line
2.45.2
author
#1 lore raw
Quoted 11 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

devm_kasprintf() can fail and return NULL, add missing return value checks.

Fixes 0ac2a08f42ce ("interconnect: add clk-based icc provider support")
Signed-off-by Bartosz Golaszewski <[email protected]>
---
 drivers/interconnect/icc-clk.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

Gentle ping.

Bart

Reviewed-by on v1 1/1
#2 lore raw
In reply to Bartosz Golaszewski
Quoted 11 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

devm_kasprintf() can fail and return NULL, add missing return value checks.

Fixes 0ac2a08f42ce ("interconnect: add clk-based icc provider support")
Signed-off-by Bartosz Golaszewski <[email protected]>
---
 drivers/interconnect/icc-clk.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
Reviewed-by Dmitry Baryshkov <[email protected]>
Signature · 2 lines
With best wishes
Dmitry