Skip to contentSkip to conversation

f2fs: Add check for deleted inode

PATCH In review Leo Stone 2 participants 2 messages Dec 2, 2024 – Dec 3, 2024 F2FS file system

lore
Share & tools
lore

Leo Stone

author
#0 lore raw

PATCH v3 1/1 f2fs: Add check for deleted inode

The syzbot reproducer mounts a f2fs image, then tries to unlink an existing file. However, the unlinked file already has a link count of 0 when it is read for the first time in do_read_inode().

Add a check to sanity_check_inode() for i_nlink == 0.

Reported-by [email protected]
Fixes 39a53e0ce0df ("f2fs: add superblock and major in-memory structure")

---
v3: Correct "Fixes" line again. Sorry for my confusion.
v2: https://lore.kernel.org/linux-f2fs-devel/[email protected]/T/
v1: https://lore.kernel.org/all/[email protected]/T/

---
 fs/f2fs/inode.c | 6 ++++++
 1 file changed, 6 insertions(+)
fs/f2fs/inode.c +6 -0
index 1ed86df343a5..65f1dc32f173 100644
@@ -372,6 +372,12 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page)
 		return false;
 	}
 
+	if (inode->i_nlink == 0) {
+		f2fs_warn(sbi, "%s: inode (ino=%lx) has a link count of 0",
+			  __func__, inode->i_ino);
+		return false;
+	}
+
 	return true;
 }
 
Signature · 1 line
2.43.0
maintainer Reviewed-by on v3 1/1
#1 lore raw
Quoted 10 lines · Leo Stone

The syzbot reproducer mounts a f2fs image, then tries to unlink an existing file. However, the unlinked file already has a link count of 0 when it is read for the first time in do_read_inode().

Add a check to sanity_check_inode() for i_nlink == 0.

Reported-by [email protected]
Fixes 39a53e0ce0df ("f2fs: add superblock and major in-memory structure")

Thanks,