Skip to contentSkip to conversation

ASoC: Correct *-objs usages

PATCH In review Takashi Iwai 2 participants 7 messages Dec 3, 2024

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover ASoC: Correct *-objs usages

I stumbled upon the use of *-objs in Makefile in a few places in ASoC. Here are trivial patches to correct those.

Takashi

===

Takashi Iwai (5):
ASoC: cs40l50: Use *-y for Makefile
ASoC: mediatek: mt8365: Use *-y for Makefile
ASoC: SDCA: Use *-y for Makefile
ASoC: cs42l84: Use *-y for Makefile
ASoC: wcd937x: Use *-y for Makefile

 sound/soc/codecs/Makefile          | 8 ++++----
 sound/soc/mediatek/mt8365/Makefile | 2 +-
 sound/soc/sdca/Makefile            | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)
Signature · 1 line
2.43.0
#1 lore raw

PATCH 1/5 ASoC: cs40l50: Use *-y for Makefile

We should use *-y instead of *-objs in Makefile for the module objects. *-objs is used rather for host programs.

Fixes c486def5b3ba ("ASoC: cs40l50: Support I2S streaming to CS40L50")
---
 sound/soc/codecs/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/Makefile +1 -1
index f37e82ddb7a1..57d3aab27d2f 100644
@@ -80,7 +80,7 @@ snd-soc-cs35l56-shared-y := cs35l56-shared.o
 snd-soc-cs35l56-i2c-y := cs35l56-i2c.o
 snd-soc-cs35l56-spi-y := cs35l56-spi.o
 snd-soc-cs35l56-sdw-y := cs35l56-sdw.o
-snd-soc-cs40l50-objs := cs40l50-codec.o
+snd-soc-cs40l50-y := cs40l50-codec.o
 snd-soc-cs42l42-y := cs42l42.o
 snd-soc-cs42l42-i2c-y := cs42l42-i2c.o
 snd-soc-cs42l42-sdw-y := cs42l42-sdw.o
Signature · 1 line
2.43.0
#2 lore raw

PATCH 2/5 ASoC: mediatek: mt8365: Use *-y for Makefile

In reply to Takashi Iwai

We should use *-y instead of *-objs in Makefile for the module objects. *-objs is used rather for host programs.

Fixes 5bbfdad8cf8d ("ASoC: mediatek: Add MT8365 support")
---
 sound/soc/mediatek/mt8365/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/mediatek/mt8365/Makefile +1 -1
index 52ba45a8498a..b197025e34bb 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 
 # MTK Platform driver
-snd-soc-mt8365-pcm-objs := \
+snd-soc-mt8365-pcm-y := \
 	mt8365-afe-clk.o \
 	mt8365-afe-pcm.o \
 	mt8365-dai-adda.o \
Signature · 1 line
2.43.0
#3 lore raw

PATCH 3/5 ASoC: SDCA: Use *-y for Makefile

In reply to Takashi Iwai

We should use *-y instead of *-objs in Makefile for the module objects. *-objs is used rather for host programs.

Fixes 3a513da1ae33 ("ASoC: SDCA: add initial module")
---
 sound/soc/sdca/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/sdca/Makefile +1 -1
index c296bd5a0a7c..5d1ddbbfbf62 100644
@@ -1,5 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0-only
 
-snd-soc-sdca-objs	:= sdca_functions.o sdca_device.o
+snd-soc-sdca-y	:= sdca_functions.o sdca_device.o
 
 obj-$(CONFIG_SND_SOC_SDCA)	+= snd-soc-sdca.o
Signature · 1 line
2.43.0
#4 lore raw

PATCH 4/5 ASoC: cs42l84: Use *-y for Makefile

In reply to Takashi Iwai

We should use *-y instead of *-objs in Makefile for the module objects. *-objs is used rather for host programs.

Fixes 250304a0fb34 ("ASoC: cs42l84: Add new codec driver")
---
 sound/soc/codecs/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/Makefile +1 -1
index 57d3aab27d2f..5a83ee963966 100644
@@ -92,7 +92,7 @@ snd-soc-cs42l52-y := cs42l52.o
 snd-soc-cs42l56-y := cs42l56.o
 snd-soc-cs42l73-y := cs42l73.o
 snd-soc-cs42l83-i2c-y := cs42l83-i2c.o
-snd-soc-cs42l84-objs := cs42l84.o
+snd-soc-cs42l84-y := cs42l84.o
 snd-soc-cs4234-y := cs4234.o
 snd-soc-cs4265-y := cs4265.o
 snd-soc-cs4270-y := cs4270.o
Signature · 1 line
2.43.0
#5 lore raw

PATCH 5/5 ASoC: wcd937x: Use *-y for Makefile

In reply to Takashi Iwai

We should use *-y instead of *-objs in Makefile for the module objects. *-objs is used rather for host programs.

Fixes 313e978df7fc ("ASoC: codecs: wcd937x: add audio routing and Kconfig")
---
 sound/soc/codecs/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/Makefile +2 -2
index 5a83ee963966..d7ad795603c1 100644
@@ -334,8 +334,8 @@ snd-soc-wcd-classh-y := wcd-clsh-v2.o
 snd-soc-wcd-mbhc-y := wcd-mbhc-v2.o
 snd-soc-wcd9335-y := wcd9335.o
 snd-soc-wcd934x-y := wcd934x.o
-snd-soc-wcd937x-objs := wcd937x.o
-snd-soc-wcd937x-sdw-objs := wcd937x-sdw.o
+snd-soc-wcd937x-y := wcd937x.o
+snd-soc-wcd937x-sdw-y := wcd937x-sdw.o
 snd-soc-wcd938x-y := wcd938x.o
 snd-soc-wcd938x-sdw-y := wcd938x-sdw.o
 snd-soc-wcd939x-y := wcd939x.o
Signature · 1 line
2.43.0
maintainer
#6 lore raw
In reply to Takashi Iwai
Quoted 9 lines · Takashi Iwai

I stumbled upon the use of *-objs in Makefile in a few places in ASoC. Here are trivial patches to correct those.

Takashi

===

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/5] ASoC: cs40l50: Use *-y for Makefile

      commit: 3f0b8d367db5b0c0a0096b1c2ff02ec7c5c893b6
[2/5] ASoC: mediatek: mt8365: Use *-y for Makefile
      commit: e9d2a2f49244d9737f0ec33f4b7f3580faecd805
[3/5] ASoC: SDCA: Use *-y for Makefile
      commit: f60646d9c3bd5b390728ed1a1caa9ded53d47afc
[4/5] ASoC: cs42l84: Use *-y for Makefile
      commit: 7916a8d8782d4e53fe0133c8dace20a925e0204e
[5/5] ASoC: wcd937x: Use *-y for Makefile
      commit: 582057d2233a5a38e1aec3f4a6d66b362b42076c

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark