mm: don't use __GFP_HARDWALL when migrating remote pages
Subsystems (3)
cover mm: don't use __GFP_HARDWALL when migrating remote pages
Resending via a known-working SMTP setup.
---
__GFP_HARDWALL means that we will be respecting the cpuset of the caller when allocating a page. However, when we are migrating remote allocations (pages allocated from other context), the cpuset of the current context is irrelevant.
For memory offlining + alloc_contig_*(), this is rather obvious. There might be other such page migration users, let's start with the obvious ones.
David Hildenbrand (2):
mm/page_alloc: don't use __GFP_HARDWALL when migrating pages via
alloc_contig*()
mm/memory_hotplug: don't use __GFP_HARDWALL when migrating pages via
memory offlining
mm/memory_hotplug.c | 2 +- mm/page_alloc.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
2.47.1
PATCH RESEND 1/2 mm/page_alloc: don't use __GFP_HARDWALL when migrating pages via alloc_contig*()
We'll migrate pages allocated by other contexts; respecting the cpuset of the alloc_contig*() caller when allocating a migration target does not make sense.
Drop the __GFP_HARDWALL.
Note that in an ideal world, migration code could figure out the cpuset of the original context and take that into consideration.
--- mm/page_alloc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
mm/page_alloc.c +3 -3
@@ -6410,11 +6410,11 @@ static int __alloc_contig_verify_gfp_mask(gfp_t gfp_mask, gfp_t *gfp_cc_mask)* page range. Migratable pages are movable, __GFP_MOVABLE is implied * for them. * -* Traditionally we always had __GFP_HARDWALL|__GFP_RETRY_MAYFAIL set, -* keep doing that to not degrade callers. +* Traditionally we always had __GFP_RETRY_MAYFAIL set, keep doing that +* to not degrade callers. */ *gfp_cc_mask = (gfp_mask & (reclaim_mask | cc_action_mask)) | - __GFP_HARDWALL | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL; + __GFP_MOVABLE | __GFP_RETRY_MAYFAIL;return 0 ; }
Signature · 1 line
2.47.1
Re: [PATCH RESEND v1 1/2] mm/page_alloc: don't use __GFP_HARDWALL when migrating pages via alloc_contig*()
Quoted 11 lines · David Hildenbrand
We'll migrate pages allocated by other contexts; respecting the cpuset of the alloc_contig*() caller when allocating a migration target does not make sense.
Drop the
__GFP_HARDWALL.Note that in an ideal world, migration code could figure out the cpuset of the original context and take that into consideration.
Suggested-by Vlastimil Babka <[email protected]>Signed-off-by David Hildenbrand <[email protected]>
Quoted 23 lines
--- mm/page_alloc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)mm/page_alloc.c +3
-3@@ -6410,11 +6410,11 @@ static int __alloc_contig_verify_gfp_mask(gfp_t gfp_mask, gfp_t *gfp_cc_mask)* page range. Migratable pages are movable, __GFP_MOVABLE is implied * for them. * -* Traditionally we always had __GFP_HARDWALL|__GFP_RETRY_MAYFAIL set, -* keep doing that to not degrade callers. +* Traditionally we always had __GFP_RETRY_MAYFAIL set, keep doing that +* to not degrade callers. */ *gfp_cc_mask = (gfp_mask & (reclaim_mask | cc_action_mask)) | - __GFP_HARDWALL | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL; + __GFP_MOVABLE | __GFP_RETRY_MAYFAIL;return 0 ; }
PATCH RESEND 2/2 mm/memory_hotplug: don't use __GFP_HARDWALL when migrating pages via memory offlining
In reply to David HildenbrandWe'll migrate pages allocated by other context; respecting the cpuset of the memory offlining context when allocating a migration target does not make sense.
Drop the __GFP_HARDWALL by using GFP_KERNEL.
Note that in an ideal world, migration code could figure out the cpuset of the original context and take that into consideration.
--- mm/memory_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/memory_hotplug.c +1 -1
@@ -1838,7 +1838,7 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)nodemask_t nmask = node_states[N_MEMORY ];struct migration_target_control mtc = { .nmask = &nmask, - .gfp_mask =GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL, + .gfp_mask =GFP_KERNEL | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL, .reason =MR_MEMORY_HOTPLUG , };int ret;
Signature · 1 line
2.47.1
Re: [PATCH RESEND v1 2/2] mm/memory_hotplug: don't use __GFP_HARDWALL when migrating pages via memory offlining
Quoted 11 lines · David Hildenbrand
We'll migrate pages allocated by other context; respecting the cpuset of the memory offlining context when allocating a migration target does not make sense.
Drop the
__GFP_HARDWALLby usingGFP_KERNEL.Note that in an ideal world, migration code could figure out the cpuset of the original context and take that into consideration.
Suggested-by Vlastimil Babka <[email protected]>Signed-off-by David Hildenbrand <[email protected]>
Thanks!
Quoted 17 lines
--- mm/memory_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/memory_hotplug.c +1
-1@@ -1838,7 +1838,7 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)nodemask_t nmask = node_states[N_MEMORY ];struct migration_target_control mtc = { .nmask = &nmask, - .gfp_mask =GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL, + .gfp_mask =GFP_KERNEL | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL, .reason =MR_MEMORY_HOTPLUG , };int ret;
Oscar Salvador
maintainerQuoted 4 lines · David Hildenbrand
Resending via a known-working SMTP setup.
---
Quoted 8 lines
__GFP_HARDWALLmeans that we will be respecting the cpuset of the caller when allocating a page. However, when we are migrating remote allocations (pages allocated from other context), the cpuset of the current context is irrelevant.For memory offlining + alloc_contig_*(), this is rather obvious. There might be other such page migration users, let's start with the obvious ones.
After the insight we gained from yesterday's discussion, this makes a lot of sense, and I suspect this was one of those "that code makes it that way, let's copy it just in case".
I will go through the patches later today and give me ack.
As you mentioned, migration code could potentially derive the policy of the old pages and try to respect that when __HARDWALL.
It might not be possible though, but I guess it is a worth a shot. I will try to investigate and see whether that is feasible.
Signature · 2 lines
Oscar Salvador SUSE Labs