Skip to contentSkip to conversation

dtc: correct the tests option

PATCH In review Alexander Kanavin 2 participants 3 messages Dec 5, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dtc: correct the tests option

From: Alexander Kanavin <[email protected]>

---
 meta/recipes-kernel/dtc/dtc_1.7.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-kernel/dtc/dtc_1.7.2.bb +1 -1
index b17cfa85e79..3df95ec1ee3 100644
@@ -22,7 +22,7 @@ inherit meson pkgconfig
 EXTRA_OEMESON = "-Dpython=disabled -Dvalgrind=disabled"
 
 PACKAGECONFIG ??= "tools"
-PACKAGECONFIG[tests] = "-Dtestss=true,-Dtests=false,"
+PACKAGECONFIG[tests] = "-Dtests=true,-Dtests=false,"
 PACKAGECONFIG[tools] = "-Dtools=true,-Dtools=false,flex-native bison-native"
 PACKAGECONFIG[yaml] = "-Dyaml=enabled,-Dyaml=disabled,libyaml"
 
Signature · 1 line
2.39.5
#1 lore raw

PATCH 2/2 libtool: restore recipe-specific application of 0008-libtool-Avoid-relinking-when-cross-compiling-its-poi.patch

From: Alexander Kanavin <[email protected]>

It was pointed out that it
"potentially has side effects for native builds. It breaks the ability to run files in the .libs directory which in the cross case we don't care about but some natives did once used to do that. The risk is they find host things instead."

---
 meta/recipes-devtools/libtool/libtool-2.5.4.inc          | 1 -
 meta/recipes-devtools/libtool/libtool-cross_2.5.4.bb     | 1 +
 meta/recipes-devtools/libtool/nativesdk-libtool_2.5.4.bb | 2 ++
 3 files changed, 3 insertions(+), 1 deletion(-)
meta/recipes-devtools/libtool/libtool-2.5.4.inc +0 -1
index 86ce446916a..6b533a0d00e 100644
@@ -16,7 +16,6 @@ SRC_URI = "${GNU_MIRROR}/libtool/libtool-${PV}.tar.gz \
            file://0005-libtool-Check-for-static-libs-for-internal-compiler-.patch \
            file://0006-libtool-Fix-tools-path-issues.patch \
            file://0007-libtool-Fix-problem-with-libtoolize-in-multilib.patch \
-           file://0008-libtool-Avoid-relinking-when-cross-compiling-its-poi.patch \
           "
 
 SRC_URI[sha256sum] = "da8ebb2ce4dcf46b90098daf962cffa68f4b4f62ea60f798d0ef12929ede6adf"
meta/recipes-devtools/libtool/libtool-cross_2.5.4.bb +1 -0
index 32d03c2f8ac..33ea706adbe 100644
@@ -1,6 +1,7 @@
 require libtool-${PV}.inc
 
 PACKAGES = ""
+SRC_URI += "file://0008-libtool-Avoid-relinking-when-cross-compiling-its-poi.patch"
 
 datadir = "${STAGING_DIR_TARGET}${target_datadir}"
 
meta/recipes-devtools/libtool/nativesdk-libtool_2.5.4.bb +2 -0
index 3669c8ba2ea..2e39a1e1d76 100644
@@ -3,6 +3,8 @@ require remove-buildpaths.inc
 
 FILESEXTRAPATHS =. "${FILE_DIRNAME}/libtool:"
 
+SRC_URI += "file://0008-libtool-Avoid-relinking-when-cross-compiling-its-poi.patch"
+
 inherit nativesdk
 
 S = "${WORKDIR}/libtool-${PV}"
Signature · 1 line
2.39.5
#2 lore raw

Patchtest results for [PATCH 2/2] libtool: restore recipe-specific application of 0008-libtool-Avoid-relinking-when-cross-compiling-its-poi.patch

Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information:

---
Testing patch /home/patchtest/share/mboxes/2-2-libtool-restore-recipe-specific-application-of-0008-libtool-Avoid-relinking-when-cross-compiling-its-poi.patch.patch

FAIL: test shortlog length: Edit shortlog so that it is 90 characters or less (currently 111 characters) (test_mbox.TestMbox.test_shortlog_length)

PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files)
PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!