ubi-utils: ubirsvol: Fix integer overflow in ubirsvol.c
PATCH 1/1 ubi-utils: ubirsvol: Fix integer overflow in ubirsvol.c
Report of the static analyzer:
The value of an arithmetic expression 'vol_info.leb_size * args.lebs' is a subject to overflow because its operands are not cast to a larger data type before performing arithmetic
Corrections explained:
the fix ensures values are checked before multiplication.
an exception check for the negativity of vol_info.leb_size and args.lebs was added, as well as casting vol_info.leb_size to long long
Triggers found by static analyzer Svace.
Signed-off-by Anton Moryakov <[email protected]>
--- ubi-utils/ubirsvol.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
ubi-utils/ubirsvol.c +4 -2
@@ -230,8 +230,10 @@ int main(int argc, char * const argv[]) } } -if (args.lebs !=-1 ) - args.bytes = vol_info.leb_size * args.lebs; +if (args.lebs !=-1 ){ +if (vol_info.leb_size >0 && args.lebs >0 ) + args.bytes = (long long )vol_info.leb_size * args.lebs; + } err =ubi_rsvol (libubi, args.node, args.vol_id, args.bytes);if (err) {
Signature · 6 lines
2.30.2 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/