perf bench: Fix undefined behavior in cmpworker()
Subsystems (2)
PATCH 1/1 perf bench: Fix undefined behavior in cmpworker()
The comparison function cmpworker() does not comply with the C standard's requirements for qsort() comparison functions. Specifically, it returns 0 when w1->tid < w2->tid, which is incorrect. According to the standard, the function must return a negative value in such cases to preserve proper ordering.
This violation causes undefined behavior, potentially leading to issues such as memory corruption in certain versions of glibc [1].
Fix the issue by returning -1 when w1->tid < w2->tid, ensuring compliance with the C standard and preventing undefined behavior.
--- tools/perf/bench/epoll-wait.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/bench/epoll-wait.c +1 -1
@@ -420,7 +420,7 @@ static int cmpworker(const void *p1, const void *p2)struct worker *w1 = (struct worker *) p1;struct worker *w2 = (struct worker *) p2; -return w1->tid > w2->tid; +return w1->tid > w2->tid ?1 :-1 ; }int bench_epoll_wait (int argc,const char **argv)
Signature · 1 line
2.34.1
Quoted 6 lines · Kuan-Wei Chiu
The comparison function
cmpworker()does not comply with the C standard's requirements forqsort()comparison functions. Specifically, it returns 0 whenw1->tid<w2->tid, which is incorrect. According to the standard, the function must return a negative value in such cases to preserve proper ordering.
Quoted 6 lines
This violation causes undefined behavior, potentially leading to issues such as memory corruption in certain versions of glibc [1].
Fix the issue by returning -1 when
w1->tid<w2->tid, ensuring compliance with the C standard and preventing undefined behavior.
I reviewed my commit message again and thought it might be clearer to explicitly mention, as in the previous patch, that the issue stems from violating symmetry and transitivity. The current cmpworker() can result in x > y but y = x, leading to undefined behavior. I'll wait for review comments before updating the patch description.
Regards,
Kuan-Wei