Skip to contentSkip to conversation

rust: document `bindgen` 0.71.0 regression

PATCH Applied Miguel Ojeda 4 participants 4 messages Dec 9, 2024 – Jan 10, 2025 Rust

lore
Share & tools
lore

Miguel Ojeda

author maintainer
#0 lore raw

PATCH 1/1 rust: document `bindgen` 0.71.0 regression

bindgen 0.71.0 regressed [1] on the "--version requires header" issue which appared in 0.69.0 first [2] and was fixed in 0.69.1. It has been fixed again in 0.71.1 [3].

Thus document it so that, when we upgrade the minimum past 0.69.0 in the future, we do not forget that we cannot remove the workaround until we arrive at 0.71.1 at least.

---
 init/Kconfig                 | 6 ++++--
 scripts/rust_is_available.sh | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)
init/Kconfig +4 -2
index a20e6efd3f0f..e8d2b5128f87 100644
@@ -1989,8 +1989,10 @@ config BINDGEN_VERSION_TEXT
 	string
 	depends on RUST
 	# The dummy parameter `workaround-for-0.69.0` is required to support 0.69.0
-	# (https://github.com/rust-lang/rust-bindgen/pull/2678). It can be removed when
-	# the minimum version is upgraded past that (0.69.1 already fixed the issue).
+	# (https://github.com/rust-lang/rust-bindgen/pull/2678) and 0.71.0
+	# (https://github.com/rust-lang/rust-bindgen/pull/3040). It can be removed
+	# when the minimum version is upgraded past the latter (0.69.1 and 0.71.1
+	# both fixed the issue).
 	default "$(shell,$(BINDGEN) --version workaround-for-0.69.0 2>/dev/null)"
 
 #
scripts/rust_is_available.sh +4 -2
index 93c0ef7fb3fb..d2323de0692c 100755
@@ -123,8 +123,10 @@ fi
 # Non-stable and distributions' versions may have a version suffix, e.g. `-dev`.
 #
 # The dummy parameter `workaround-for-0.69.0` is required to support 0.69.0
-# (https://github.com/rust-lang/rust-bindgen/pull/2678). It can be removed when
-# the minimum version is upgraded past that (0.69.1 already fixed the issue).
+# (https://github.com/rust-lang/rust-bindgen/pull/2678) and 0.71.0
+# (https://github.com/rust-lang/rust-bindgen/pull/3040). It can be removed when
+# the minimum version is upgraded past the latter (0.69.1 and 0.71.1 both fixed
+# the issue).
 rust_bindings_generator_output=$( \
 	LC_ALL=C "$BINDGEN" --version workaround-for-0.69.0 2>/dev/null
 ) || rust_bindings_generator_code=$?

base-commit: fac04efc5c793dccbd07e2d59af9f90b7fc0dca4

Signature · 1 line
2.47.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Miguel Ojeda

bindgen 0.71.0 regressed [1] on the "--version requires header" issue which appared in 0.69.0 first [2] and was fixed in 0.69.1. It has been fixed again in 0.71.1 [3].

Quoted 8 lines

Thus document it so that, when we upgrade the minimum past 0.69.0 in the future, we do not forget that we cannot remove the workaround until we arrive at 0.71.1 at least.

Quoted 43 lines
---
 init/Kconfig                 | 6 ++++--
 scripts/rust_is_available.sh | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)
init/Kconfig +4 -2
index a20e6efd3f0f..e8d2b5128f87 100644
@@ -1989,8 +1989,10 @@ config BINDGEN_VERSION_TEXT
 	string
 	depends on RUST
 	# The dummy parameter `workaround-for-0.69.0` is required to support 0.69.0
-	# (https://github.com/rust-lang/rust-bindgen/pull/2678). It can be removed when
-	# the minimum version is upgraded past that (0.69.1 already fixed the issue).
+	# (https://github.com/rust-lang/rust-bindgen/pull/2678) and 0.71.0
+	# (https://github.com/rust-lang/rust-bindgen/pull/3040). It can be removed
+	# when the minimum version is upgraded past the latter (0.69.1 and 0.71.1
+	# both fixed the issue).
 	default "$(shell,$(BINDGEN) --version workaround-for-0.69.0 2>/dev/null)"
 
 #
scripts/rust_is_available.sh +4 -2
index 93c0ef7fb3fb..d2323de0692c 100755
@@ -123,8 +123,10 @@ fi
 # Non-stable and distributions' versions may have a version suffix, e.g. `-dev`.
 #
 # The dummy parameter `workaround-for-0.69.0` is required to support 0.69.0
-# (https://github.com/rust-lang/rust-bindgen/pull/2678). It can be removed when
-# the minimum version is upgraded past that (0.69.1 already fixed the issue).
+# (https://github.com/rust-lang/rust-bindgen/pull/2678) and 0.71.0
+# (https://github.com/rust-lang/rust-bindgen/pull/3040). It can be removed when
+# the minimum version is upgraded past the latter (0.69.1 and 0.71.1 both fixed
+# the issue).
 rust_bindings_generator_output=$( \
 	LC_ALL=C "$BINDGEN" --version workaround-for-0.69.0 2>/dev/null
 ) || rust_bindings_generator_code=$?

base-commit: fac04efc5c793dccbd07e2d59af9f90b7fc0dca4

Signature · 1 line
2.47.1
reviewer Reviewed-by on v1 1/1
#2 lore raw
In reply to Miguel Ojeda
Quoted 5 lines · Miguel Ojeda

bindgen 0.71.0 regressed [1] on the "--version requires header" issue which appared in 0.69.0 first [2] and was fixed in 0.69.1. It has been fixed again in 0.71.1 [3].

Quoted 8 lines

Thus document it so that, when we upgrade the minimum past 0.69.0 in the future, we do not forget that we cannot remove the workaround until we arrive at 0.71.1 at least.

Applied
#3 lore raw
In reply to Miguel Ojeda
Quoted 5 lines · Miguel Ojeda

bindgen 0.71.0 regressed [1] on the "--version requires header" issue which appared in 0.69.0 first [2] and was fixed in 0.69.1. It has been fixed again in 0.71.1 [3].

Quoted 8 lines

Thus document it so that, when we upgrade the minimum past 0.69.0 in the future, we do not forget that we cannot remove the workaround until we arrive at 0.71.1 at least.

Applied to rust-next -- thanks everyone!

Cheers,
Miguel