Skip to contentSkip to conversation

dt-bindings: arm: rockchip: add Radxa ROCK 5C Lite

PATCH In review FUKAUMI Naoki 2 participants 6 messages Dec 11, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: arm: rockchip: add Radxa ROCK 5C Lite

The Radxa ROCK 5C Lite uses a different SoC (RK3582) compared to the Radxa ROCK 5C (RK3588S2), but the two are compatible from a software perspective.

Fixes df4e08a5eed1 ("dt-bindings: arm: rockchip: add Radxa ROCK 5C")
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/rockchip.yaml +1 -1
index 753199a12923..2254ee079094 100644
@@ -895,7 +895,7 @@ properties:
           - const: radxa,rock-5b
           - const: rockchip,rk3588
 
-      - description: Radxa ROCK 5C
+      - description: Radxa ROCK 5C/5C Lite
         items:
           - const: radxa,rock-5c
           - const: rockchip,rk3588s
Signature · 7 lines
2.43.0


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#1 lore raw

Hello Fukaumi,

Quoted 16 lines · FUKAUMI Naoki

The Radxa ROCK 5C Lite uses a different SoC (RK3582) compared to the Radxa ROCK 5C (RK3588S2), but the two are compatible from a software perspective.

Fixes df4e08a5eed1 ("dt-bindings: arm: rockchip: add Radxa ROCK 5C")
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/rockchip.yaml +0 -0
index 753199a12923..2254ee079094 100644

Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 901

Quoted 8 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +1 -1
@@ -895,7 +895,7 @@ properties:
           - const: radxa,rock-5b
           - const: rockchip,rk3588
 
-      - description: Radxa ROCK 5C
+      - description: Radxa ROCK 5C/5C Lite
         items:
           - const: radxa,rock-5c
           - const: rockchip,rk3588s

I think it would be better to use "rockchip,rk3582" here, to allow us to possibly use that information later. For example, we might want to be able to recognize RK3582-based boards in U-Boot without the need to look into the e-fuses at some point, for which purpose having a clear designator in the DT would fit perfectly.

As a reminder, using "rockchip,rk3582" would also require a small addition to drivers/irqchip/irq-gic-v3-its.c.

#2 lore raw

Hi Dragan,

Quoted 22 lines · Dragan Simic

Hello Fukaumi,

Quoted 19 lines · FUKAUMI Naoki

The Radxa ROCK 5C Lite uses a different SoC (RK3582) compared to the Radxa ROCK 5C (RK3588S2), but the two are compatible from a software perspective.

Fixes df4e08a5eed1 ("dt-bindings: arm: rockchip: add Radxa ROCK 5C")

---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/rockchip.yaml +0 -0
index 753199a12923..2254ee079094 100644
@@ -895,7 +895,7 @@ properties:

           - const: radxa,rock-5b
           - const: rockchip,rk3588

Quoted 11 lines
Quoted 5 lines

-      - description: Radxa ROCK 5C
+      - description: Radxa ROCK 5C/5C Lite
         items:
           - const: radxa,rock-5c
           - const: rockchip,rk3588s

I think it would be better to use "rockchip,rk3582" here, to allow us to possibly use that information later.  For example, we might want to be able to recognize RK3582-based boards in U-Boot without the need to look into the e-fuses at some point, for which purpose having a clear designator in the DT would fit perfectly.

It may be okay to introduce "rockchip,rk3582", but reading e-fuse is still required in U-Boot because which unit (cpu coreX, gpu, etc) is broken cannot be determined without reading e-fuse at run-time.

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Quoted 3 lines

As a reminder, using "rockchip,rk3582" would also require a small addition to drivers/irqchip/irq-gic-v3-its.c.

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

#3 lore raw

just FYI,

https://lore.kernel.org/linux-rockchip/?q=e52c

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Quoted 37 lines · FUKAUMI Naoki

Hi Dragan,

Quoted 22 lines · Dragan Simic

Hello Fukaumi,

Quoted 19 lines · FUKAUMI Naoki

The Radxa ROCK 5C Lite uses a different SoC (RK3582) compared to the Radxa ROCK 5C (RK3588S2), but the two are compatible from a software perspective.

Fixes df4e08a5eed1 ("dt-bindings: arm: rockchip: add Radxa ROCK 5C")

---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/rockchip.yaml +0 -0
index 753199a12923..2254ee079094 100644
@@ -895,7 +895,7 @@ properties:

           - const: radxa,rock-5b
           - const: rockchip,rk3588

Quoted 11 lines
Quoted 5 lines

-      - description: Radxa ROCK 5C
+      - description: Radxa ROCK 5C/5C Lite
         items:
           - const: radxa,rock-5c
           - const: rockchip,rk3588s

I think it would be better to use "rockchip,rk3582" here, to allow us to possibly use that information later.  For example, we might want to be able to recognize RK3582-based boards in U-Boot without the need to look into the e-fuses at some point, for which purpose having a clear designator in the DT would fit perfectly.

Quoted 13 lines

It may be okay to introduce "rockchip,rk3582", but reading e-fuse is still required in U-Boot because which unit (cpu coreX, gpu, etc) is broken cannot be determined without reading e-fuse at run-time.

Best regards,

Signature · 2 lines
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 3 lines

As a reminder, using "rockchip,rk3582" would also require a small addition to drivers/irqchip/irq-gic-v3-its.c.

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

#4 lore raw
Quoted 3 lines · FUKAUMI Naoki

just FYI,

https://lore.kernel.org/linux-rockchip/?q=e52c

AFAICT, it isn't too late to introduce "rockchip,rk3582". :)

Quoted 40 lines · FUKAUMI Naoki
Quoted 39 lines · Dragan Simic
Quoted 20 lines · FUKAUMI Naoki
Quoted 19 lines

The Radxa ROCK 5C Lite uses a different SoC (RK3582) compared to the Radxa ROCK 5C (RK3588S2), but the two are compatible from a software perspective.

Fixes df4e08a5eed1 ("dt-bindings: arm: rockchip: add Radxa ROCK 5C")

---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/rockchip.yaml +0 -0
index 753199a12923..2254ee079094 100644
@@ -895,7 +895,7 @@ properties:

           - const: radxa,rock-5b
           - const: rockchip,rk3588

Quoted 11 lines
Quoted 5 lines

-      - description: Radxa ROCK 5C
+      - description: Radxa ROCK 5C/5C Lite
         items:
           - const: radxa,rock-5c
           - const: rockchip,rk3588s

I think it would be better to use "rockchip,rk3582" here, to allow us to possibly use that information later.  For example, we might want to be able to recognize RK3582-based boards in U-Boot without the need to look into the e-fuses at some point, for which purpose having a clear designator in the DT would fit perfectly.

It may be okay to introduce "rockchip,rk3582", but reading e-fuse is still required in U-Boot because which unit (cpu coreX, gpu, etc) is broken cannot be determined without reading e-fuse at run-time.

Quoted 2 lines

As a reminder, using "rockchip,rk3582" would also require a small addition to drivers/irqchip/irq-gic-v3-its.c.

#5 lore raw
In reply to FUKAUMI Naoki
Quoted 33 lines · FUKAUMI Naoki
Quoted 20 lines · Dragan Simic
Quoted 19 lines · FUKAUMI Naoki

The Radxa ROCK 5C Lite uses a different SoC (RK3582) compared to the Radxa ROCK 5C (RK3588S2), but the two are compatible from a software perspective.

Fixes df4e08a5eed1 ("dt-bindings: arm: rockchip: add Radxa ROCK 5C")

---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/rockchip.yaml +0 -0
index 753199a12923..2254ee079094 100644
@@ -895,7 +895,7 @@ properties:

           - const: radxa,rock-5b
           - const: rockchip,rk3588

Quoted 11 lines
Quoted 5 lines

-      - description: Radxa ROCK 5C
+      - description: Radxa ROCK 5C/5C Lite
         items:
           - const: radxa,rock-5c
           - const: rockchip,rk3588s

I think it would be better to use "rockchip,rk3582" here, to allow us to possibly use that information later.  For example, we might want to be able to recognize RK3582-based boards in U-Boot without the need to look into the e-fuses at some point, for which purpose having a clear designator in the DT would fit perfectly.

Quoted 3 lines

It may be okay to introduce "rockchip,rk3582", but reading e-fuse is still required in U-Boot because which unit (cpu coreX, gpu, etc) is broken cannot be determined without reading e-fuse at run-time.

Sure, but I think it would be rather bad to miss this opportunity to introduce a clear DT designator for RK3582-based boards. It's better to have the designator unused, than to bang our heads later, if we conclude that we need it at some point. :)

Quoted 2 lines
Quoted 2 lines

As a reminder, using "rockchip,rk3582" would also require a small addition to drivers/irqchip/irq-gic-v3-its.c.