brcmfmac: add missing header include for brcmf_dbg
PATCH 1/1 brcmfmac: add missing header include for brcmf_dbg
Including the fwil.h header file can lead to a build error:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h: \
In function ‘brcmf_fil_cmd_int_set’:drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h:90:9: error: implicit \
declaration of function ‘brcmf_dbg’ [-Werror=implicit-function-declaration]
90 | brcmf_dbg(FIL, "ifidx=%d, cmd=%d, value=%d\n", ifp->ifidx, cmd, data);
| ^~~~~~~~~The error is often avoided because the debug.h header file is included before the fwil.h header file.
This makes sure the header include order is irrelevant by explicitly adding the debug.h header.
--- drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h +2 -0
@@ -6,6 +6,8 @@#ifndef _fwil_h_#define _fwil_h_ +#include "debug.h" +/******************************************************************************* * Dongle command codes that are interpreted by firmware ******************************************************************************/
Signature · 1 line
2.34.1
Quoted 7 lines · Marcel Hamer
Including the
fwil.hheader file can lead to a build error:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h: \
In function ‘brcmf_fil_cmd_int_set’:drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h:90:9: error: implicit \
declaration of function ‘brcmf_dbg’ [-Werror=implicit-function-declaration]
90 | brcmf_dbg(FIL, "ifidx=%d, cmd=%d, value=%d\n",ifp->ifidx,
Quoted 8 lines
cmd, data); | ^~~~~~~~~The error is often avoided because the
debug.hheader file is included before thefwil.hheader file.This makes sure the header include order is irrelevant by explicitly adding the
debug.hheader.
I understand the change, but not sure if it is actually solving anything. Then again there are plenty of include files including others so...
Quoted 5 lines
Fixes 31343230abb1 ("wifi: brcmfmac: export firmware interface functions")Signed-off-by Marcel Hamer <[email protected]>---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h| 2 ++1 file changed, 2 insertions(+)
Re: wifi: brcmfmac: add missing header include for brcmf_dbg
In reply to Marcel HamerQuoted 12 lines · Marcel Hamer
Including the
fwil.hheader file can lead to a build error:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h: \
In function ‘brcmf_fil_cmd_int_set’:drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h:90:9: error: implicit \
declaration of function ‘brcmf_dbg’ [-Werror=implicit-function-declaration]90 | brcmf_dbg(FIL, "ifidx=%d, cmd=%d, value=%d\n", ifp->ifidx, cmd, data); | ^~~~~~~~~The error is often avoided because the
debug.hheader file is included before thefwil.hheader file.
Quoted 6 lines
This makes sure the header include order is irrelevant by explicitly adding the
debug.hheader.Fixes 31343230abb1 ("wifi: brcmfmac: export firmware interface functions")Signed-off-by Marcel Hamer <[email protected]>Acked-by Arend van Spriel <[email protected]>
Patch applied to wireless-next.git, thanks.
b05d30c2b6df wifi: brcmfmac: add missing header include for brcmf_dbg
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches