Skip to contentSkip to conversation

brcmfmac: add missing header include for brcmf_dbg

PATCH In review Marcel Hamer 3 participants 3 messages Dec 11, 2024 – Dec 13, 2024 Broadcom BRCM80211 IEEE802.11 wireless drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 brcmfmac: add missing header include for brcmf_dbg

Including the fwil.h header file can lead to a build error:

drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h: \
In function ‘brcmf_fil_cmd_int_set’:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h:90:9: error: implicit \
declaration of function ‘brcmf_dbg’ [-Werror=implicit-function-declaration]

   90 |         brcmf_dbg(FIL, "ifidx=%d, cmd=%d, value=%d\n", ifp->ifidx, cmd, data);
      |         ^~~~~~~~~

The error is often avoided because the debug.h header file is included before the fwil.h header file.

This makes sure the header include order is irrelevant by explicitly adding the debug.h header.

Fixes 31343230abb1 ("wifi: brcmfmac: export firmware interface functions")
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h +2 -0
index 31e080e4da66..ab3d6cfcb02b 100644
@@ -6,6 +6,8 @@
 #ifndef _fwil_h_
 #define _fwil_h_
 
+#include "debug.h"
+
 /*******************************************************************************
  * Dongle command codes that are interpreted by firmware
  ******************************************************************************/
Signature · 1 line
2.34.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Marcel Hamer

Including the fwil.h header file can lead to a build error:

drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h: \
In function ‘brcmf_fil_cmd_int_set’:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h:90:9: error: implicit \
declaration of function ‘brcmf_dbg’ [-Werror=implicit-function-declaration]
90 | brcmf_dbg(FIL, "ifidx=%d, cmd=%d, value=%d\n", ifp->ifidx,

Quoted 8 lines
  cmd, data);
     |         ^~~~~~~~~

The error is often avoided because the debug.h header file is included before the fwil.h header file.

This makes sure the header include order is irrelevant by explicitly adding the debug.h header.

I understand the change, but not sure if it is actually solving anything. Then again there are plenty of include files including others so...

Quoted 5 lines
Fixes 31343230abb1 ("wifi: brcmfmac: export firmware interface functions")

---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h | 2 ++

1 file changed, 2 insertions(+)
#2 lore raw

Re: wifi: brcmfmac: add missing header include for brcmf_dbg

In reply to Marcel Hamer
Quoted 12 lines · Marcel Hamer

Including the fwil.h header file can lead to a build error:

drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h: \
In function ‘brcmf_fil_cmd_int_set’:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h:90:9: error: implicit \
declaration of function ‘brcmf_dbg’ [-Werror=implicit-function-declaration]

   90 |         brcmf_dbg(FIL, "ifidx=%d, cmd=%d, value=%d\n", ifp->ifidx, cmd, data);
      |         ^~~~~~~~~

The error is often avoided because the debug.h header file is included before the fwil.h header file.

Quoted 6 lines

This makes sure the header include order is irrelevant by explicitly adding the debug.h header.

Fixes 31343230abb1 ("wifi: brcmfmac: export firmware interface functions")

Patch applied to wireless-next.git, thanks.

b05d30c2b6df wifi: brcmfmac: add missing header include for brcmf_dbg

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches