staging: gpib: Wrapped macro in parentheses to ensure the correct evaluation order
PATCH 1/1 staging: gpib: Wrapped macro in parentheses to ensure the correct evaluation order
From: Santosh Mahto <[email protected]>
ERROR found by checkpatch.pl script
Signed-off-by Santosh Mahto <[email protected]>
--- drivers/staging/gpib/gpio/gpib_bitbang.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/gpib/gpio/gpib_bitbang.c +4 -4
@@ -44,10 +44,10 @@ pr_info("%s:%s - " frm, NAME, __func__, ## __VA_ARGS__); } \ while (0) -#define LINVAL gpiod_get_value(DAV), \ - gpiod_get_value(NRFD), \ - gpiod_get_value(NDAC), \ - gpiod_get_value(SRQ) +#define LINVAL (gpiod_get_value(DAV), \ + gpiod_get_value(NRFD), \ + gpiod_get_value(NDAC), \ + gpiod_get_value(SRQ))#define LINFMT "DAV: %d NRFD:%d NDAC: %d SRQ: %d"#include "gpibP.h"
Signature · 1 line
2.25.1
Quoted 6 lines · On Thu, Dec 12, 2024 at 12:52:04AM +0530, [email protected] wrote:
From: Santosh Mahto <[email protected]>
ERROR found by checkpatch.pl script
Signed-off-by Santosh Mahto <[email protected]>---
Checkpatch isn't always right. Adding parentheses breaks the build.
regards,
dan carpenter