powerpc/pseries/eeh: Fix get PE state translation
PATCH v3 1/1 powerpc/pseries/eeh: Fix get PE state translation
The PE Reset State "0" obtained from RTAS calls ibm_read_slot_reset_[state|state2] indicates that the Reset is deactivated and the PE is not in the MMIO Stopped or DMA Stopped state.
With PE Reset State "0", the MMIO and DMA is allowed for the PE. The function pseries_eeh_get_state() is currently not indicating that to the caller because of which the drivers are unable to resume the MMIO and DMA activity. The patch fixes that by reflecting what is actually allowed.
---
Changelog:
V1:https://lore.kernel.org/all/[email protected]/ --added Fixes tag for "powerpc/pseries: Cleanup on pseries_eeh_get_state()". V2:https://lore.kernel.org/stable/20241212075044.10563-1-nnmlinux%40linux.ibm.com --Updated the patch description to include it in the stable kernel tree.
--- arch/powerpc/platforms/pseries/eeh_pseries.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
arch/powerpc/platforms/pseries/eeh_pseries.c +4 -2
@@ -580,8 +580,10 @@ static int pseries_eeh_get_state(struct eeh_pe *pe, int *delay)switch (rets[0 ]) {case 0 : - result =EEH_STATE_MMIO_ACTIVE | -EEH_STATE_DMA_ACTIVE ; + result =EEH_STATE_MMIO_ACTIVE | +EEH_STATE_DMA_ACTIVE | +EEH_STATE_MMIO_ENABLED | +EEH_STATE_DMA_ENABLED ;break ;case 1 : result = EEH_STATE_RESET_ACTIVE |
Signature · 1 line
2.47.1
Quoted 11 lines · Narayana Murty N
The PE Reset State "0" obtained from RTAS calls ibm_read_slot_reset_[state|state2] indicates that the Reset is deactivated and the PE is not in the MMIO Stopped or DMA Stopped state.
With PE Reset State "0", the MMIO and DMA is allowed for the PE. The function
pseries_eeh_get_state()is currently not indicating that to the caller because of which the drivers are unable to resume the MMIO and DMA activity. The patch fixes that by reflecting what is actually allowed.
Quoted 7 lines
Fixes 00ba05a12b3c ("powerpc/pseries: Cleanup on pseries_eeh_get_state()")Cc <[email protected]>Signed-off-by Narayana Murty N <[email protected]>---
Changelog:
V1:https://lore.kernel.org/all/[email protected]/
As discussed in v1, powernv already does this and this is needed for pseries as well for the callers to know, whether the eeh recovery is completed.
This looks good to me. Please feel free to add -
-ritesh